Date:   Wed, 15 Mar 2023 17:18:26 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>,
        Ira Weiny <ira.weiny@intel.com>, <gregkh@linuxfoundation.org>
CC:     <outreachy@lists.linux.dev>, <martyn@welchs.me.uk>,
        <manohar.vanga@gmail.com>, <zoo868e@gmail.com>,
        <jerrykang026@gmail.com>, <cuigaosheng1@huawei.com>,
        <arnd@arndb.de>, <linux-kernel@vger.kernel.org>,
        <linux-staging@lists.linux.dev>
Subject: Re: [PATCH 1/2] staging: vme_user: add space around operators
Message-ID: <64126052e09c0_2595222947e@iweiny-mobl.notmuch>
References: <b56c7b94e59a4051373af8b5d90a0685dfc9233a.1678882204.git.eng.mennamahmoud.mm@gmail.com>
 <641212c8d481f_253a1e29437@iweiny-mobl.notmuch>
 <f9988309-d4f1-8e50-555d-3fd813952893@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f9988309-d4f1-8e50-555d-3fd813952893@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0lWVXRTeWhOVGpzN0ZSZHQ2VG5WanhoenZxcE1EV2E3OVdyVHNBYk5mOS93?=
 =?utf-8?B?OHMrVlY3KzBYL1NtQi93eGVVREpkL25rTS9iZGI3blBoY3hoQzY4TjRoWFNy?=
 =?utf-8?B?TnloSnA4a2RDWGgycVN3QjF6Y1ZzdWxrQUpCS0FXUFgrc3U3RXJXWWJBTjJn?=
 =?utf-8?B?OWVCOVI3QURPYmY5enJtdS9rU0o2OVhrU0t1YS82a0NMd2dmM3BVd1krNjRj?=
 =?utf-8?B?N2F6cStwNndGS2lyUkc4SWY3d1VwT3o1Ky9jL1cydlFHRlVPVC9vY0x3TjQy?=
 =?utf-8?B?VzdzamR4QmZ5MVcvdzcxVXJPZjZER0c2b0lQZ2J3bGM5azFqajVZNnBXaFRE?=
 =?utf-8?B?QW1HS2tJcEVmbHRWMldGOXU3SjhnZWEzMHRaUkYrSHVncXI2ZEdBTWxSd1Ew?=
 =?utf-8?B?cmVEa0F4bzNacWZjK3Fmbkt2WE9DRXkxZnNpSW14SEZmY0hzMDBmS2kvWit0?=
 =?utf-8?B?Sy8weG5YS2dOR0E5RkZ6VWFDZ3JMSTkycGdqREExVWVJZmJSUUxmUVduUFlO?=
 =?utf-8?B?eW5yZFZ0ZG1mM3UwOHFPMWVGRW95Ujh4U1RaZkRwY2F5S280aGFyZXJEajJR?=
 =?utf-8?B?Y3VXWWNqYWV4WHpxWFdPMHB1anNwSUgxRzllcll3MDJsS0Q1NkVUcVFMZnEw?=
 =?utf-8?B?Vm8ydDlERVhrRHE3UTB1TXM3akNHbDhDRmFNUFc1TWxpVGh1dXlsb1M4ZTFR?=
 =?utf-8?B?TUJZUWhFNHlZZkROUGQ4ci9ZYVY2dlEyU29rQ0UwcmVhbnFkQXNaenlkaEFn?=
 =?utf-8?B?OEo4cTZQV20waVRzRUxQTndsUVYwcGhqVVFwekJYSk9RdlpzMC83UnJVS3Za?=
 =?utf-8?B?RmZXbGRsR2c2azlsaWhBTTNKN1pFTHljRk13bzU1SWJ4TzVLUUVMajFYRlVI?=
 =?utf-8?B?RHJ4dWhBNTVUbElOSXFRQXJFaE53MVQvaHVmUUhPTTVzY0Fzak42bitpSzkv?=
 =?utf-8?B?K1lWZzI4MGM4R244SWtVNHdjaFE2bmRLUDZjbGM4ZVVwbWZLb3VLZ0pCVCtM?=
 =?utf-8?B?dGxhS1dSS0dZUFpTWHJXZlpuTXJ5a3ZMMEoyNDZrZlJMc2hmeXFweldWWlZo?=
 =?utf-8?B?a3JKZ20rVmZlcGQzNGpTcXNUSHNxeVp2TWdRNk40bVlRbHZtUjhja2lxZUVX?=
 =?utf-8?B?bHpIUTFHaVFzVkdPOW1ZWndmSUc0NjRnVlpSb00wTHhYbVdxbklSWUdhV0tu?=
 =?utf-8?B?Vlcya3NSeWNyUm5jTGVOWWdtVHBNRkpOeGY2U0hoekhnZUhZdlBDaW1MblEy?=
 =?utf-8?B?V215QkgwVWY4bE9JQ2VteEhiMWtaQVlYajgzYW45eHRaZENZeDBuSjlieHlN?=
 =?utf-8?B?LzBXQVZNMFdIS2tXc0V2ZE4xZk9JY2tSWUpmV3JOWHBJZTRnZkdJdXgxZkxz?=
 =?utf-8?B?QmNSRlZJVUtVUnRVVXNKU2lhT1FrNWJPSktudEh2dlpqdzM5VG82cEtJT3NF?=
 =?utf-8?B?RnJqZWVmVU0raWE4bVVWazdpdG10OHZMRmkzQUFiOXpMK3NaRHR3SUliUE9Z?=
 =?utf-8?B?UWZUY2xDMU1mdkJCUlM5VkgxNDdhY1JpZ0IzVDFqZkY4MGZrVDA5Y1JzRjl3?=
 =?utf-8?B?MkJYYWJucXBCOEc5RFh0L3pFSmhWSEhkb3F5dS81V204eVEyd1ZTV1RXdVdl?=
 =?utf-8?B?YXVKT2lheGdmeTdkUzFibCtPTkRSdTROOTlESDQyOHplY0ZGbnIyOVZVL3BQ?=
 =?utf-8?B?NkdMWEJjb3MvZVh1a3JSSEo1bXQzclZIcCtDZDJBc1BGMEZWL2QybmM5M1h2?=
 =?utf-8?B?aTc2R2dpcG9zMU1nOVR1Z0I3Und0M0djN2JXY3BmS0dnOS83NWw3ZFhkZThw?=
 =?utf-8?B?VzlEdWRMeDBicVVIODBrOVIrL2hEeE9OSjdzNkJrMkRMeFhCRGVOYTRyOHZG?=
 =?utf-8?B?NVliazJXQTdPVTZQQnkraVdXdk5iZnp3aGh3YXFidGwyZXRKZWh4VGJabkZh?=
 =?utf-8?B?OUE3bW8yOG5YSzlzSUhIWEdwYXVzRDVqc1FwQmFUQzkzWCtHd3NtUWt4UnBN?=
 =?utf-8?B?dkc2VEhkSkxEbXpDUlZGRzMzRkNvY2t6alFyeXlkRDMxWExWSjY5NTZDQUN5?=
 =?utf-8?B?RUJoUEk2NkIweEZzeXFhRGc0cU10NXYvb2pUSlczeXFzNCtqT2ZQcHhTL1dC?=
 =?utf-8?B?S2JESHpBc0U1R3BNL1ZDU0c2ZEx6NjF0MWFwWnBlbEk3ZHBickdubFkvR3hm?=
 =?utf-8?B?RXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cd660ed-c20e-48c7-ba11-08db25b3f8c7
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 00:18:30.7988
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wb0/s3MRseKdqGucPs5eZrxkDQJQZ/zhQVn9ijB613XxcRbL0sCTR0Z9d/rDTyafHQKv+qjN6gQSXT2s3iju7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB7983
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Menna Mahmoud wrote:
> 
> On ١٥‏/٣‏/٢٠٢٣ ٢٠:٤٧, Ira Weiny wrote:
> > Menna Mahmoud wrote:
> >> add a space before and after the operator, for readability.
> >>
> >> Reported By checkpatch script:
> >>
> >> CHECK: spaces preferred around that '+' (ctx:VxV)
> >> +		image->bus_resource.name = kmalloc(VMENAMSIZ+3, GFP_ATOMIC);
> >>   		                                            ^
> >> CHECK: spaces preferred around that '<<' (ctx:VxV)
> >> +	temp_ctl &= ~(3<<4);
> >>   	               ^
> >> CHECK: spaces preferred around that '>>' (ctx:VxV)
> >> +	cbar = (cbar & TSI148_CRCSR_CBAR_M)>>3;
> >>   	                                   ^
> >> CHECK: spaces preferred around that '<<' (ctx:VxV)
> >> +		iowrite32be(cbar<<3, bridge->base + TSI148_CBAR);
> > Similar comment to what Fabio made.
> >
> > But I'll add some formatting comments.
> >
> > It looks like you have submitted a 2 patch series which fixes all the
> > checkpatch errors in the vme_user driver?
> 
> yes, each patch for specific error in multi-position.
> 
> >
> > Kudos for separating out the 2 patches for the 2 different types of
> > checkpatch errors!  And for submitting a series which fixes the entire
> > driver!
> 
> to double check that i understood right, you mean I should create one 
> patch-set for one error?

No what you did was correct.  Each patch should fix one type of error.  I
only meant you should include a cover letter which explains the group of
patches as a bundle to fix the checkpatch errors of this driver.

https://kernelnewbies.org/PatchSeries

> 
> Because I have already done that in previous patch but Julia commented 
> on it that no need to create patch-set
> 
> for the same error.
> 
> 
> > But you should also include a cover letter for your series.
> okay, I will include it.
> >
> > How are you creating this series?  Are you using 'git format-patch'?
> > 'b4'?  If not using 'b4' I strongly recommend it.[*]
> 
> yes, used ' git format-patch` but I will try b4.

While I still recomend using b4 check out the --cover-letter option to
format-patch.

    --cover-letter        generate a cover letter

Ira