Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07735C7619A for ; Thu, 16 Mar 2023 03:05:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbjCPDFY (ORCPT ); Wed, 15 Mar 2023 23:05:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbjCPDFS (ORCPT ); Wed, 15 Mar 2023 23:05:18 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FAAA1FD4 for ; Wed, 15 Mar 2023 20:05:14 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id u5so320443plq.7 for ; Wed, 15 Mar 2023 20:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1678935914; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZAJ32JUJ/u8tD4KHo0y/9csx0a9LdOuzb1AC53J8pBo=; b=Hzu3b0ypyUtxefOCDdRStwfJPseOMdTDAOe1bNFk+mdav8xOUgCe8HcAY7b/XO7hAV rcmOIxBA8lO0WvKMtn3Ydfp/CJ+lREaarW9T/J3AG0KK7O2IQhW3JYe/8WVwYf6+2nwz H8gadlIv3MUoprqeXaLCEgiWQCNSzqGJ/sSUA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678935914; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZAJ32JUJ/u8tD4KHo0y/9csx0a9LdOuzb1AC53J8pBo=; b=x9p/XsDdtCNABDX0nY8lpxe0w4N/MiabTNafi+8d+o/7jV/mcOFKXrEe8MhGNCTQiX QiHWK3paZFYDO4AqvF51SY9IFu8QNZaZFsvhLeENf4J+6EvZuEP2E/rmz/NPvR5nWL2V 2vadbGN37my/ikIlHBdYFZuH7fcNkEmwc3ps/a5pcmc3FuaVw6UcP61f9eV/GKisLe2p sghiTFncDkkDqT5WbcCRvtcGp1Th3hamGQbt75nOBszUimILxWgj6HIQS/rmp/pC00e8 rvMjjp1AH2b2R21f9hslkeXViRAkpyWYylDtwitR6MGHdSmbsYes6i7iUO+r5nNtTSMg kHVA== X-Gm-Message-State: AO0yUKXm6J3FIq9PL/70s8wwMy6Z6gYe9J7oefOGBRP05z3oqptf7R6g btAfNZL1XAu/bD8Mxs4J77Aayg== X-Google-Smtp-Source: AK7set9ZFTYHhd84dOmI9tzKAbY7LI7C7q2nN4XMZlm9R+t4OVOt2ZixXu1gQDxf1Ymcqa+7JGS2gw== X-Received: by 2002:a17:90b:4b90:b0:23d:3386:95e0 with SMTP id lr16-20020a17090b4b9000b0023d338695e0mr2226245pjb.1.1678935913875; Wed, 15 Mar 2023 20:05:13 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id x35-20020a631723000000b00502fd12bc9bsm3958818pgl.8.2023.03.15.20.05.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 20:05:13 -0700 (PDT) Date: Thu, 16 Mar 2023 12:05:08 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Cc: Laurent Pinchart , Mauro Carvalho Chehab , Sergey Senozhatsky , linux-kernel@vger.kernel.org, "hn.chen" , linux-media@vger.kernel.org Subject: Re: [PATCH v9 1/6] media: uvcvideo: Fix negative modulus calculation Message-ID: <20230316030508.GB1927922@google.com> References: <20220920-resend-hwtimestamp-v9-0-55a89f46f6be@chromium.org> <20220920-resend-hwtimestamp-v9-1-55a89f46f6be@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920-resend-hwtimestamp-v9-1-55a89f46f6be@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (23/03/15 14:30), Ricardo Ribalda wrote: > > If head is 0, last will be addressing the index 0 instead of clock->size > -1. Luckily clock->head is unsiged, otherwise it would be addressing > 0xffffffff. > > Nontheless, this is not the intented behaviour and should be fixed. > > Fixes: 66847ef013cc ("[media] uvcvideo: Add UVC timestamps support") > Signed-off-by: Ricardo Ribalda Reviewed-by: Sergey Senozhatsky