Message-ID: <b68c6baa-62ec-901a-76f9-0baef7daa3f5@nvidia.com>
Date:   Thu, 16 Mar 2023 14:57:26 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH net-next v7 5/5] net/mlx5e: TC, Add support for VxLAN GBP
 encap/decap flows offload
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        roopa@nvidia.com, eng.alaamohamedsoliman.am@gmail.com,
        bigeasy@linutronix.de, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, gavi@nvidia.com, roid@nvidia.com,
        maord@nvidia.com, saeedm@nvidia.com
References: <20230313075107.376898-1-gavinl@nvidia.com>
 <20230313075107.376898-6-gavinl@nvidia.com>
 <20230315003244.52bb841d@kernel.org>
Content-Language: en-US
From:   Gavin Li <gavinl@nvidia.com>
In-Reply-To: <20230315003244.52bb841d@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SldiOUk5ODZ5Ukd2VlpPSVVaZEFaWGpXS09qYlVBZ0Fzem8xSTVhL3RVODFU?=
 =?utf-8?B?WERTQnJObnRkeDNRaE4yQjFnV3YwV3dnVlBPcERUdDBXNGNXd1lOd2k4UWx5?=
 =?utf-8?B?bXJoRUFmMDI3RC9LRG1tR01nejBtNS9TWGZzNlRvRENWWHIyMGVpTDZNUXc5?=
 =?utf-8?B?YXIwMjd2TjJhUC9McUl0VmxsNjQ5UEkxQkIvQXRQYjVualdKYW1XNVFIbExD?=
 =?utf-8?B?aVYrSytqM0V5cmJBZlVrMEgrbXNaZmI5eDBWMEZXaSsrK2toS3pXU3JFR0tv?=
 =?utf-8?B?a1I1TXB3U1hMVC81YlVHSXErSFg5UGd3SzRVRVJsR1NhWjNHakZ1TDJrTDYv?=
 =?utf-8?B?TDE4V1czdytBa0tjNnB6amYwbkZqMWZxL2RmRVdjWGpmVWRYaEx4aU5hOGNY?=
 =?utf-8?B?YVZqdkdwTFFTSGIrem0yWW9Vc2ovR0JIZEh6Wmt5czFGbkEwbnRMOStkM1F6?=
 =?utf-8?B?RGF3ZG5VU2lBeDNXTGwvWVhGdzJDT3E4a3BqRUpIMGVqa0tuUWhWV3FqcVN5?=
 =?utf-8?B?TlhnR09rclBaR1BqSW11Qk1LZklYWEcreTJ5eGdGdU1KakhwUUtLMHB2UnZT?=
 =?utf-8?B?dEMwbzJCcG5kMEZXNTVhdHVCUlduOUVOOFNsUWlDQWtFc3RFREtDcVFTQ1ZX?=
 =?utf-8?B?bmlrSDh4RXFNRTgwTkJSZnBOSjgxOW9FWmVQQ1hHSXhXenM2YmJMMHNIUm9l?=
 =?utf-8?B?MlFZZ2kyTFJsKzVnTytGQklBRmczQmpBbU9wU25rRlVIM2trbUZ6ejlTOTdJ?=
 =?utf-8?B?RCtKbDJpRVFaUytoelo0ZWE0cFBGRWFraHFHR0dmVVhGTXJ1cnBZeHAwQlM4?=
 =?utf-8?B?NXVoMnBrSzRyYjZyMURyNUxYK1ZUZHFYeGc5bmtqNXpBNzVvN3lST2ltS1VO?=
 =?utf-8?B?TzJkd204elRXcGpaRHZNU2FsbFZud0JrOXR6Mko4QTR1NzhwZGdXc0Q3dE9E?=
 =?utf-8?B?dHNrUkZpYWdUYTl5dVdBd3JpUWpZOFdaTkkzYTFHaTZxYis5V21FN1dva1h4?=
 =?utf-8?B?SEJmRmVWNFZ2aUNyanpCRTU5Y2lucHYyQ3Z3RDA4U3lCS2VKN2U0VVJHZlRS?=
 =?utf-8?B?eGU3WDJrZjE4bFNyOWNZLzhNZC9aWVAwTzZrd2JlUUVyY0hvUDZIaGFRcnBk?=
 =?utf-8?B?dW8zYWZkUkU2cjFJdU9CVVI4dmp3ZzFlYldZbGZERWw5N3JVcWxwZ2lQT3hR?=
 =?utf-8?B?aklGWCswWnRVZHlzV3lnZlkvc3BGd3Zvbnd2TWdrUFh1bU04RFloNGxubER4?=
 =?utf-8?B?Qit6K2YwZkQyZEErbjRwL3Yrc0RTM2lvSVJ1L0JkenZaTm9OODhzYmJUSlZU?=
 =?utf-8?B?OWd0Y2E3RjIxNitZZnBOdVYwaElEa1BYOXYvODNpVVBqSEU3bExYQ0VHNjAr?=
 =?utf-8?B?dzZOV0tCUXVQb2FISTBFUmtjSE0wZjNRSHN1Nm8vUlRlaUxBaEliS0VmU1RL?=
 =?utf-8?B?UTNuYk4vMkdOYi94Smcvdi9ZVDhDc1BNZ1lNRmhoVXJLOWhsbVVkZFFsRzBt?=
 =?utf-8?B?ajk4V1l4aWtDV2hHazRSU2s1WDJiUlBIc3dqdW93eUNzOWs2cVo3aCsvVDN4?=
 =?utf-8?B?Y3dZTm03YmUzWTVNZW41cEQ2Z01SWGpWK0dDVUEwcEU0cGFVTTRTSFBINXgz?=
 =?utf-8?B?U2VET3lwRHU4N01uQ3BkMlNyMzUwanBOZFBIRldCSWxIUXRFdE9PSEJrUEtZ?=
 =?utf-8?B?OEt1UDVud2s0OHRyYUJuNDNWZkwrTjFhckZSOXgwVDhtTG5xenNSRG5JNmZU?=
 =?utf-8?B?N2JUSGN6TVRHeGxYMkxIYW9Eb1ZNOHZ3NlF2cEh5czJFNEJVdGZabHRpcW1a?=
 =?utf-8?B?OE1ORWpYT3dENFVROGs1MW5BMjNCcVJMNUlQUE9HYWhwMHEvc2lXaUUzZ1Av?=
 =?utf-8?B?aWRiR01BejhwZjgwWDYvTkVHVXBhTU1abGEzTDlhalZxREphWXRiWGU3QVhz?=
 =?utf-8?B?RHltNXZyU094KzQxNklnV003WERYU0VoUHc5VnhrQTJkSSt6d2x4aWJ4QTVh?=
 =?utf-8?B?RFBRVmJSOHVhRjY5MTVFU1BmbGpFVit0Yzh3REtnTDBLUytVRFRVckViOHlO?=
 =?utf-8?B?cC84UjBxdmw3a3BsQ2RFbXRkckVOaHdtM3RaZUJ2MVdwY3J3R2UvZllEMjE5?=
 =?utf-8?Q?ZA+p721CyX+BdpkvOTa/gSySb?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f65a28c-1e6f-4e2a-5abc-08db25ebbb61
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3835.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 06:57:39.8537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2ec7Q6Zu73pfZzpD6anIAH8PFsKyl3o2bQy/RZpEvFAJ95jS+Nwo+z6vghiwcEUNnUAiEfnlE+2A1ZhQRtSJBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7493
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/15/2023 3:32 PM, Jakub Kicinski wrote:
> External email: Use caution opening links or attachments
>
>
> On Mon, 13 Mar 2023 09:51:07 +0200 Gavin Li wrote:
>> +     if (memchr_inv(&enc_opts.mask->data, 0, sizeof(enc_opts.mask->data)) &&
>> +         !MLX5_CAP_ESW_FT_FIELD_SUPPORT_2(priv->mdev, tunnel_header_0_1)) {
>> +             NL_SET_ERR_MSG_MOD(extack, "Matching on VxLAN GBP is not supported");
>> +             netdev_warn(priv->netdev, "Matching on VxLAN GBP is not supported\n");
>> +             return -EOPNOTSUPP;
>> +     }
>> +
>> +     if (enc_opts.key->dst_opt_type != TUNNEL_VXLAN_OPT) {
>> +             NL_SET_ERR_MSG_MOD(extack, "Wrong VxLAN option type: not GBP");
>> +             netdev_warn(priv->netdev, "Wrong VxLAN option type: not GBP\n");
>> +             return -EOPNOTSUPP;
>> +     }
>> +
>> +     if (enc_opts.key->len != sizeof(*gbp) ||
>> +         enc_opts.mask->len != sizeof(*gbp_mask)) {
>> +             NL_SET_ERR_MSG_MOD(extack, "VxLAN GBP option/mask len is not 32 bits");
>> +             netdev_warn(priv->netdev, "VxLAN GBP option/mask len is not 32 bits\n");
>> +             return -EINVAL;
>> +     }
>> +
>> +     gbp = (u32 *)&enc_opts.key->data[0];
>> +     gbp_mask = (u32 *)&enc_opts.mask->data[0];
>> +
>> +     if (*gbp_mask & ~VXLAN_GBP_MASK) {
>> +             NL_SET_ERR_MSG_FMT_MOD(extack, "Wrong VxLAN GBP mask(0x%08X)\n", *gbp_mask);
>> +             netdev_warn(priv->netdev, "Wrong VxLAN GBP mask(0x%08X)\n", *gbp_mask);
>> +             return -EINVAL;
> extack only please, there's no excuse to be using both any more
ACK