Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED807C7618A for ; Thu, 16 Mar 2023 07:37:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbjCPHhM (ORCPT ); Thu, 16 Mar 2023 03:37:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbjCPHhA (ORCPT ); Thu, 16 Mar 2023 03:37:00 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6069420C; Thu, 16 Mar 2023 00:36:47 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 1423824E181; Thu, 16 Mar 2023 15:36:40 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 16 Mar 2023 15:36:40 +0800 Received: from [192.168.120.42] (171.223.208.138) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 16 Mar 2023 15:36:39 +0800 Message-ID: <9afeb36f-e95c-c459-c765-9a8ec48a257c@starfivetech.com> Date: Thu, 16 Mar 2023 15:36:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v7 3/6] dt-bindings: net: snps,dwmac: Add 'ahb' reset/reset-name Content-Language: en-US To: Krzysztof Kozlowski , , , , CC: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis , Yanhong Wang , Tommaso Merciai References: <20230316043714.24279-1-samin.guo@starfivetech.com> <20230316043714.24279-4-samin.guo@starfivetech.com> From: Guo Samin In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Re: [PATCH v7 3/6] dt-bindings: net: snps,dwmac: Add 'ahb' reset/reset-name From: Krzysztof Kozlowski to: Samin Guo , linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org data : 2023/3/16 > On 16/03/2023 05:37, Samin Guo wrote: >> According to: >> stmmac_platform.c: stmmac_probe_config_dt >> stmmac_main.c: stmmac_dvr_probe >> >> dwmac controller may require one (stmmaceth) or two (stmmaceth+ahb) >> reset signals, and the maxItems of resets/reset-names is going to be 2. >> >> The gmac of Starfive Jh7110 SOC must have two resets. >> it uses snps,dwmac-5.20 IP. >> >> Signed-off-by: Samin Guo >> Tested-by: Tommaso Merciai > > How do you test the bindings on hardware? > > Reviewed-by: Krzysztof Kozlowski > > Best regards, > Krzysztof > Hi, Krzysztof Thanks a lot. Sorry, my fault. Tomaso tested gmac based on v5 version. I should only add Tested-by to the driver and dts patches, but not to dt-bindings. I will fix it in the next version. Best regards, Samin