Message-ID: <b9a4671bef0ad931a79c2911986286f1d9bb3ae9.camel@sipsolutions.net>
Subject: Re: [PATCH next] wifi: iwlwifi: Avoid disabling GCC specific flag
 with clang
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Nathan Chancellor <nathan@kernel.org>, gregory.greenman@intel.com
Cc:     kvalo@kernel.org, ndesaulniers@google.com, trix@redhat.com,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        patches@lists.linux.dev
Date:   Thu, 16 Mar 2023 08:52:50 +0100
In-Reply-To: <20230315-iwlwifi-fix-pragma-v1-1-ad23f92c4739@kernel.org>
References: <20230315-iwlwifi-fix-pragma-v1-1-ad23f92c4739@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-03-15 at 20:28 -0700, Nathan Chancellor wrote:
> Clang errors:
>=20
>   drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c:15:32: error: unknown=
 warning group '-Wsuggest-attribute=3Dformat', ignored [-Werror,-Wunknown-w=
arning-option]
>   #pragma GCC diagnostic ignored "-Wsuggest-attribute=3Dformat"
>                                  ^
>   1 error generated.

Oops.

> The warning being disabled by this pragma is GCC specific. Guard its use
> with CONFIG_CC_IS_GCC so that it is not used with clang to clear up the
> error.
>=20

Thanks.

johannes