Date:   Thu, 16 Mar 2023 09:11:23 +0100
From:   Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v6 1/1] net: dsa: hellcreek: Get rid of custom
 led_init_default_state_get()
Message-ID: <ZBLPK0loejiHEoe5@localhost.localdomain>
References: <20230314181824.56881-1-andriy.shevchenko@linux.intel.com>
 <ZBFeUazA9X9mmWiJ@localhost.localdomain>
 <ZBHFOlwoLYn3xz2L@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZBHFOlwoLYn3xz2L@smile.fi.intel.com>
Precedence: bulk

On Wed, Mar 15, 2023 at 03:16:42PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 15, 2023 at 06:57:37AM +0100, Michal Swiatkowski wrote:
> > On Tue, Mar 14, 2023 at 08:18:24PM +0200, Andy Shevchenko wrote:
> > > LED core provides a helper to parse default state from firmware node.
> > > Use it instead of custom implementation.
> 
> ...
> 
> > You have to fix implict declaration of the led_init_default_state_get().
> 
> Seems like users have to choose between 'select NEW_LEDS' and
> 'depends on NEW_LEDS' in the Kconfig.
> 
> > I wonder if the code duplication here can be avoided:
> 
> Whether or not this is out of the scope of this patch.
> Feel free to submit one :-)
> 
> ...
>

Reasonable ;)
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>

> > Only suggestion, patch looks good.
> 
> Thank you!
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>