Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0385EC6FD1F for ; Thu, 16 Mar 2023 08:29:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229544AbjCPI3F convert rfc822-to-8bit (ORCPT ); Thu, 16 Mar 2023 04:29:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229645AbjCPI3B (ORCPT ); Thu, 16 Mar 2023 04:29:01 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBB4D7DB6; Thu, 16 Mar 2023 01:28:42 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 7A0B224E2E2; Thu, 16 Mar 2023 16:28:41 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 16 Mar 2023 16:28:41 +0800 Received: from [192.168.120.42] (171.223.208.138) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 16 Mar 2023 16:28:40 +0800 Message-ID: Date: Thu, 16 Mar 2023 16:28:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac Content-Language: en-US To: Krzysztof Kozlowski , , , , CC: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis , Yanhong Wang , Tommaso Merciai References: <20230316043714.24279-1-samin.guo@starfivetech.com> <20230316043714.24279-5-samin.guo@starfivetech.com> <93a3b4bb-35a4-da7c-6816-21225b42f79b@starfivetech.com> <9038dba0-6f72-44a1-9f57-1c08b03b9c31@linaro.org> From: Guo Samin In-Reply-To: Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -------- 原始信息 -------- 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac From: Krzysztof Kozlowski 收件人: Guo Samin , linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org 日期: 2023/3/16 > On 16/03/2023 09:15, Guo Samin wrote: >>>>> interrupts: ??? >>>>> >>>> >>>> Hi Krzysztof, >>>> >>>> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes, >>>> and the JH7110 SoC is also applicable. >>>> Maybe just add reg/interrupt/interrupt-names to the required ? >>> >>> You need to constrain them. >> >> >> I see. I will add reg constraints in the next version, thanks. >> >> I have one more question, the interrupts/interrup-names of JH7110 SoC's gmac are exactly the same as snps,dwmac.yaml, >> do these also need to be constrained? > > The interrupts on common binding are variable, so you need to constrain > them - you have fixed number of them, right? > > Best regards, > Krzysztof > Yes, JH7110 fixed is 3 pcs. Thanks, I will constrain them. Best regards, Samin