Message-ID: <ef646855-fd6b-1700-62ac-7efa9a0ad72c@oracle.com>
Date:   Thu, 16 Mar 2023 08:48:26 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH RESEND v2 01/11] scsi: scsi_debug: Don't hold driver host
 struct pointer in host->hostdata[]
To:     dgilbert@interlog.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, bvanassche@acm.org,
        linux-kernel@vger.kernel.org
References: <20230313093114.1498305-1-john.g.garry@oracle.com>
 <20230313093114.1498305-2-john.g.garry@oracle.com>
 <5f8c7ee6-fade-2060-d44a-8794d2d6e505@interlog.com>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <5f8c7ee6-fade-2060-d44a-8794d2d6e505@interlog.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3RwWVdFaTgyUytRdlFOdEJDdmpLREd5M3J0bFhiVUxNMHdKdUpXM3UxUnBS?=
 =?utf-8?B?SU1LcW5SdmUrQjRxTW9LVnp2NWJUNmNxMi85ZmVMdHhZVmE4dm1lekZ2bXZi?=
 =?utf-8?B?OVNibjlyVmw3ZUpWb2ExdDhnT3M1WTZ0Q0FvZjRveE4xYS9hcWdYN0ZWOTNL?=
 =?utf-8?B?Ty83R3AxUVJWM0xielI1YWo1TndGTC9jcEIwa0tHMzVqSDQrUTA5NjNTQ1hr?=
 =?utf-8?B?dDRQejVDbHBIUWxabjlNS0w3VjNqOWxLYkFYTExicWtuREd0QW5kckhFYUdY?=
 =?utf-8?B?TzZtM1BvMTdIcUsxT3VoN3RkcHZHZjFVVUtJdXE3OU1wZGFsK3ladFVZVmNT?=
 =?utf-8?B?R3NTYjFtL2hoeTlzc3ZtY1RmN3I0aG9FMTMvRk5uT1oyZ2dkNVVIYUx2cXJa?=
 =?utf-8?B?Sm9nanFkMTlPY2NGQmF6VEtCbnBvcW0xc0VLamNKbHYvNlRFeFp6ck0zaVNk?=
 =?utf-8?B?cmt1RGV5UGszaFA1RmMwZUY3SlZaeUVRTlhncjRKblVDcDgwb3lvalVJckRN?=
 =?utf-8?B?OXJvbHRlQTl3aVB1REdxd1lyUlpyR285Z0hpcWk1c0doVnVXQWlrZFJEVUtP?=
 =?utf-8?B?ejZ3L08zV2VaaVp3RUNaUWYzRzVNWGlPa2N5SHp5dE1UTlZ5aXVqRDlqVGxQ?=
 =?utf-8?B?d2lTdHRadFdLN2ZnY2NLdWpPZHlhSXhmak9qY2RRNjlDdWxrTHFvZG4xRXd0?=
 =?utf-8?B?NFNDZGZKVEh1TitkTnlxUG00UWFYNk9TWTlSWkdUaCttQzF0bjV5eHVWaUZm?=
 =?utf-8?B?ZFBzWHZtdVA3SmhLeHQ4aG5Zd1ZnVzhYQ3QycjFLMGpMcmx5SDJNQzN1enI4?=
 =?utf-8?B?Q0ZSMFZVcmY4amY0dEwyRnpKZ2VtS20wZ2RLU21hUWdHMnloNFowd3AxTFhN?=
 =?utf-8?B?dGEwcTFkS0NUMVlkZ1pqMWNobkczTDlGbko0YzZKRnRuQURnMllOZVdaTkFJ?=
 =?utf-8?B?SUxxNURpUWlETUFPdHRqcXJJQVFsN0htY3JMYVloSkJGRHBENkdZNmlHWFBW?=
 =?utf-8?B?WEp0MDJyTXBudHhsRGwvVEpsZEVCbkw5bGVXa05CT1drU29Pc2VXeXlTb0hV?=
 =?utf-8?B?OXloRVlsRVAwMDR6dnFLc1BrS2prcnZWT3Rnc0F5Tmkva3gvbkN1bXZISFVj?=
 =?utf-8?B?ZWNQUWJUQjNsLzBoeEtnWmtPSW0xbnNSMlpZWk9aa3A5L09SWk1yc1NiNUha?=
 =?utf-8?B?Z3VKUkI0dm01enN5MC9iZDVGU0J0aTZpeG56M2JMMkQ0RjJRcmk4RXhMbTE3?=
 =?utf-8?B?d05DaVhzVmF1TzNJemh0N01ZdlQyQ3NLZjl3eU1BOVpjOFNRNzc4Z1RrM2Y3?=
 =?utf-8?B?Uzd3eHFUMG1HenZxL0VJODF2c3A2V2VnSHpYcHE0VjVtZHdtYmhqcUtOUmxt?=
 =?utf-8?B?WHlEN1cvS0N2Wk0yY3hZY3lQSjVQYTQzUXh5REJOVGJaTU0wWnVvVVVuWjBo?=
 =?utf-8?B?K2FiaVlBQVZZeHhXTGN3enB6cUhWMWg1T29lUi9WME9HKzAySnc0S2VPZTN3?=
 =?utf-8?B?TGpsOU5FN2RiNk1IdHhMdWQ3ei9mWE1oTUNHSWF4Y1hUa3F4MUxlcXdNL0Ja?=
 =?utf-8?B?eXlLa1dNYXdoYnQwZVZjWXNhQ3FNVmhTdnR0WnpnUTl3WkRlakd3Tk8wUnVH?=
 =?utf-8?B?Uzdqa0I0dk42RTRjUVgvOGZXOVBtcTRZalQrL1JWMXVSRkpmSnplc3FHR2c5?=
 =?utf-8?B?Wm4vZmNrY2tiT2hBOUJvemF4TVowT3NOQ2NGejg5S1lNemhqT0VPTFoxeW1H?=
 =?utf-8?B?bERZRlNlQ3A2SWR4QUxTOVE2di9STVJwb3FCMkdEQnBMbXo5SDhpNkQ5Smg3?=
 =?utf-8?B?dHZpeUdRTmk3OEZsUVBKQjFlK1Rab2FrL2JZM24wSGF5bjJzL1dla1RCb0ph?=
 =?utf-8?B?VmFEYk1pWmJ5OElPcDAvOHBMcDNHOGZWTEswS2pUTkt5MDdzYlBpdWxKWk5k?=
 =?utf-8?B?UU5KMC9PdHBvSndtbFZ3dkV1SDMxZSthckZvM3lJeWRZMEdoU01FUm04bVRI?=
 =?utf-8?B?K0pQa3djZmFqeEJTNzFGQ0JrQmhQLzFuaEpqM096VE5UKzIvZGlmMThCcDBt?=
 =?utf-8?B?MnZ0NTVBb0o0eWZQcXNSVGlLbUVnNFFKTHFlNlJBMVpLN1ppbGo3WnRESzBT?=
 =?utf-8?B?TjczTi93ZldyV0pmQkorcG8rR2xuenVMaDJsczdOVXhzUk1lSXFWcEdVYUVK?=
 =?utf-8?B?ekE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Y0lq9k9JPZ25s1BaQc8/ATCZFRtPJzf/q82P1s25hlK4HUO7YF0HVwMau1Yy6pZrAqgCXqmMsC/3f4MTAZzXrSMJ+upRgNN6zswkbeTY9EOIJGhU/LzCTs9/3Q/72P7fgZYOJbZQR8zO/k+pEARsU9lSH6JiXJHWaVUZ/0ea8c4iiJhU1QXIFEtIb95C/MyP7HC5TSDHSS0QkAwaCCs9s9j5NJX4EqTOTijxzQK0rH1skdtz/GaHugf3jDgJ4kS8M7tRw1tt3BowCpmUsidjtHbbPmTaYelJdYkG1IOJnmZwcvALOFyuMiBWY/BTqig9FAoucAPFYQIdDjoInfTVQpn9k/PE8tm6XvmafWB0RFTNiRrUN2xwHtJArYEt7jdpnbITcFslHI03uLVAaBl6dWXeVVvjJvJMCI0TTqMIq7whJxILIAEMCCYLEqHjhf/w+/cIsspmwdnXgM4mo3B/RjgQYnyXzPlqTcjRzodLoJI7XQG5nmyu+2n73RYraLrzvPrbjGR+Nsi5QEJA3oyMJ3p1ToB3yXHfu+c7zUJJaAv8013jhHjIo+BaHbLTwQsIad0cecINaXR96okMCD3TCAohtP8gUHS+gWKxgvLJaNOyW2ogenM2fagUZvktJ9sHH2Zlr7ACgHw6UTmNfXgV4kVSghS0ijm1EWdw0PZeuJX9tjBo5PWNtzjw0oKNS1F+SEJXAcqif4Jpz4gXnSnRlAFqWVHQkaMXJph0K+41fcEHriOzds/eQYF8SNWzPiLJHqgnC6+lVFiJR4l7v+2SGyTBjwSvevzRHv4ivysVi7Dew18hVBqSO9SKGXNNIXV0Ccm7m7ENR1S0RDouz2QtoMeuheGYIaYhJXnIozTqJdI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef1af2df-d63a-4068-0b64-08db25fb37df
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 08:48:31.0096
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1us8/dsbIIonkKIulpyn7y0NXomBLJQaK/ZREuAobPBrKqRnM+h6xyWuByPoh6jP1JIs0TnTHIsGdpIG7TxUuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5697
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-16_06,2023-03-15_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0
 mlxlogscore=999 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303150002 definitions=main-2303160074
X-Proofpoint-ORIG-GUID: h4Ps8cOUVdj8IqyAyfqph5SKV-UARe4T
X-Proofpoint-GUID: h4Ps8cOUVdj8IqyAyfqph5SKV-UARe4T
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14/03/2023 02:34, Douglas Gilbert wrote:
> 2023-03-13 05:31, John Garry wrote:
>> This driver stores just a pointer to the driver host structure in
>> host->hostdata[]. Most other drivers actually have the driver host
>> structure allocated in host->hostdata[], but this driver is different as
>> we allocate that memory separately before allocating the shost memory.
>>
>> However there is no need to allocate this memory only in host->hostdata[]
>> when we can already look up the driver host structure from 
>> shost->dma_dev,
>> so add a macro for this - shost_to_sdebug_host(). Rename to_sdebug_host()
>> -> dev_to_sdebug_host() to avoid ambiguity.
>>
>> Also remove a check for !sdbg_host in find_build_dev_info(), as this 
>> cannot
>> be true. Other similar checks will be later removed.
>>
>> Signed-off-by: John Garry <john.g.garry@oracle.com>
> Acked-by: Douglas Gilbert <dgilbert@interlog.com>
> 
> Please apply my "ack" to the rest of this series (2 through 11).
> 

Thanks.

Hi Martin, Please let me know if you would like me to send the series 
again with Doug's tags appended.

> Good the have other eyes looking at this driver and making
> improvements.

No worries, Please check the other series which I sent when you can. I 
am not sure how to solve the issue related to the last patch there. 
Maybe a solution would be to just remove all the shosts and then re-add 
with updated can_queue.

John