From:   Geethasowjanya Akula <gakula@marvell.com>
To:     Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>
CC:     Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH] octeontx2-vf: Add missing free for alloc_percpu
Thread-Topic: [EXT] Re: [PATCH] octeontx2-vf: Add missing free for
 alloc_percpu
Thread-Index: AQHZV97GqDznRcbEGkaO+A4Ix1oUDq79GmGQ
Date:   Thu, 16 Mar 2023 09:00:57 +0000
Message-ID: <DM6PR18MB2602F8A77B07FFDC1F2B07A4CDBC9@DM6PR18MB2602.namprd18.prod.outlook.com>
References: <20230316023911.3615-1-jiasheng@iscas.ac.cn>
 <ZBLO3FSC4IhoBzl1@localhost.localdomain>
In-Reply-To: <ZBLO3FSC4IhoBzl1@localhost.localdomain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x1UfvycFzEmzxMHNycneU6X3fymgJvRAhdv/CR2MQTM5aYhNvfk3IFFkW0op?=
 =?us-ascii?Q?jKOmPQ4UPX9Yw0HO2oHdHtfp9fa/1RV1D01zNsgn9fypEY1FpCSWBELuEci3?=
 =?us-ascii?Q?cfOy4c7JHEEnFX/n07YVN2ucmrlM+hMfo6EtFyj6iRHoNVqwZP+aK9LpWFuE?=
 =?us-ascii?Q?uwc9k197jsH9X3NM1xeSdAlIKwtvERvjgkpIJ4VX0Gr6eQcQoP3qexO0JBd1?=
 =?us-ascii?Q?iguauAcE/28pXPpAycpkCLGRxNxfp5Y0nxT86m1L/FWWfYTWD1wxxvz1c0jb?=
 =?us-ascii?Q?ta+g+S/Cp40Usjbo9x5JVYy1fkR9MaBPPUe1wcPvWIkd9d+gN+8SInGOhXxC?=
 =?us-ascii?Q?F2ZsdyceQUJmzi+1HLvp+Njl/+4bguHefRLgA+K0e+Q3pQyRnDMZyA9vowbi?=
 =?us-ascii?Q?KTqoIGOsqn8RL2wWfNKAKDgnG37mRnAr4xwsNwKGYnw1JCRdkgzyphjm/T/X?=
 =?us-ascii?Q?ZDrMeV797U3CKc67T2qnaDjoohCcMPW6WstlRUih2wNS403EuiXHFfE8tU7b?=
 =?us-ascii?Q?+VizzsHMNaUjSmTvDRIhcQ+Ak1RHR8a5tiYqcKQGUP8C+hk6MJeGxm4Jm6fg?=
 =?us-ascii?Q?AYHCQv38/5OfJRHdvAw1F8JEesvUS2PBqjPFeaYFLgfhLloIaK12Wj8erENL?=
 =?us-ascii?Q?voWygGEVTi0uuGtFpvWOpIvSZ6Pvm8Dp/4W8ZJLRtG2+93akNfxsPRpaSvuN?=
 =?us-ascii?Q?n85hbvmoHCJZFL7pj2bmny6ulGJh3DcizOb2nnAYOPvbyjCMgGMuujzm0p8+?=
 =?us-ascii?Q?5DEQ2VoaAvN+Zl2UdsYJZDaJ0IWQ9NyU80vMIozh2hg+QNYbBweKrCtOvNGI?=
 =?us-ascii?Q?N+OC5UtU0uU/5c0caSWBs5ibIlkz8frYQ6bVKecH2HlwIWveHVUMp8JcN8OE?=
 =?us-ascii?Q?tOXmw+8t4032hHRrJ6hiqpPNzGYW+5pWV5UcQsM4Ls59iCVqjpyR44eu7piN?=
 =?us-ascii?Q?b8nxpKPbfYMwDoMxipoWj6Tnn2SCKP4xpy/F9rtFv6Y+OW+qRFqcA5ZsQZDS?=
 =?us-ascii?Q?in4IHON2CeLkR2V4L+UtDMJxFY2dgGJH5+J/3AJ6qAF3mFtH3cx4LqOMHfvn?=
 =?us-ascii?Q?+a5YX0Bkb/6rWQ4ailuvTmfkD+dpz1iP6PjDQqMn/Golt0pnirkGgH1Dw3jh?=
 =?us-ascii?Q?P0u/EznbXGt+JZcmY4qtr2vkwdlvHS4vCdvODklRUwg+eI0PHYnpF06F+ile?=
 =?us-ascii?Q?Zfj/IWA+Wn99bceIJ+VBKHv/253o2pq6LUq4E+Gm8EcR703ZUVyuPB/+Y+7e?=
 =?us-ascii?Q?tr4sYnLfu7XEm7eQe5TREoMYgDRWx2+/K38YViPwyshcpkDSQaD+VmqDfsIt?=
 =?us-ascii?Q?79rAsyc5cO1x2iakF8eFdKP8YUMXXEx1ESUHI/mCwog/KpHDhJKJUPTUrSjY?=
 =?us-ascii?Q?lZbE8Pm7w1teU9Q5RLzuayarKqCt5jDmRFOXRm039X+4yyuLbq0G4veR9Iox?=
 =?us-ascii?Q?TKv5nwWeZl6ImJgevRpSE3dMz49rqHa3/zKfvnOUr6SRpNLa+jafbum1W9RW?=
 =?us-ascii?Q?oMxEL5RqhRl26qUOo9bDGdCKzymLuK64RAJlckoi32WeXieq5dG7JlQ/8bb0?=
 =?us-ascii?Q?CeuhfdlbbqgJQCPtxfkP7Oa2a7DDmxrLwWxB0BPD?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB2602.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce54c7b5-54ae-413b-faa5-08db25fcf4e1
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2023 09:00:57.3181
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6stuSEsWb+T2SqQn3qzincjgnuA6V0p2tNYfblAVy9x3ZVj1zK8klvv27cAmNepZr3F9SNlnUh0/6RSZ++muOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB5146
X-Proofpoint-GUID: ybQI-JfV32GcvAKvvxjXQWcYh8vuHwsF
X-Proofpoint-ORIG-GUID: ybQI-JfV32GcvAKvvxjXQWcYh8vuHwsF
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-16_06,2023-03-15_01,2023-02-09_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>-----Original Message-----
>From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>=20
>Sent: Thursday, March 16, 2023 1:40 PM
>To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>Cc: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula <ga=
kula@marvell.com>; Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; Haripras=
ad Kelam <hkelam@marvell.com>; >davem@davemloft.net; edumazet@google.com; k=
uba@kernel.org; pabeni@redhat.com; richardcochran@gmail.com; netdev@vger.ke=
rnel.org; linux-kernel@vger.kernel.org
>Subject: [EXT] Re: [PATCH] octeontx2-vf: Add missing free for alloc_percpu

>External Email

>----------------------------------------------------------------------
>On Thu, Mar 16, 2023 at 10:39:11AM +0800, Jiasheng Jiang wrote:
>> Add the free_percpu for the allocated "vf->hw.lmt_info" in order to=20
>> avoid memory leak, same as the "pf->hw.lmt_info" in=20
>> `drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c`.
>>=20
>> Fixes: 5c0512072f65 ("octeontx2-pf: cn10k: Use runtime allocated=20
>> LMTLINE region")
>> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>> ---
>>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>=20
>> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c=20
>> b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
>> index 7f8ffbf79cf7..9db2e2d218bb 100644
>> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
>> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
>> @@ -709,6 +709,8 @@ static int otx2vf_probe(struct pci_dev *pdev,=20
>> const struct pci_device_id *id)
>>  err_ptp_destroy:
>>  	otx2_ptp_destroy(vf);
>>  err_detach_rsrc:
>> +	if (vf->hw.lmt_info)
>> +		free_percpu(vf->hw.lmt_info);
>>  	if (test_bit(CN10K_LMTST, &vf->hw.cap_flag))
>>  		qmem_free(vf->dev, vf->dync_lmt);
>I wonder if it wouldn't be more error prune when You create a function to =
unroll cn10k_lmtst_init() like cn10k_lmtst_deinit(). These two if can be th=
ere, maybe also sth else is missing.

>Otherwise it is fine
>Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>

>>  	otx2_detach_resources(&vf->mbox);
>> @@ -762,6 +764,8 @@ static void otx2vf_remove(struct pci_dev *pdev)
>>  	otx2_shutdown_tc(vf);
>>  	otx2vf_disable_mbox_intr(vf);
>>  	otx2_detach_resources(&vf->mbox);
>> +	if (vf->hw.lmt_info)
>> +		free_percpu(vf->hw.lmt_info);

Ack. Thanks for the patch.

>>  	if (test_bit(CN10K_LMTST, &vf->hw.cap_flag))
>>  		qmem_free(vf->dev, vf->dync_lmt);
>>  	otx2vf_vfaf_mbox_destroy(vf);
>> --
>> 2.25.1
>>=20

Geetha.