Date:   Thu, 16 Mar 2023 10:09:39 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 03/16] can: m_can: Remove double interrupt enable
Message-ID: <ZBLc03OYJLLhHLNj@corigine.com>
References: <20230315110546.2518305-1-msp@baylibre.com>
 <20230315110546.2518305-4-msp@baylibre.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230315110546.2518305-4-msp@baylibre.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HCN9e9jRpRPIe1tx8AN6k9BlBIRiB+wxfBD+kPDvlx1zzrRcnh07fUArS67H?=
 =?us-ascii?Q?r/9BqUdExPHvTHncyw5lwcd/MwaQz7Apx4dv7ax/btAUaVPnlblanbNgA7bg?=
 =?us-ascii?Q?mDvaDawoYO2EyONlACLH1MK+4ObiQ38c/wmFepYDwTpLEXYIrdRNKQ1BT4m9?=
 =?us-ascii?Q?R0UNRPOM2O1IRlRgZfpnos6GxpyxtECUpvhA6kNEh7n2+35qBX8PR7hZfJwg?=
 =?us-ascii?Q?42WPO8BOL7iqBfU1DAhoiXrwstfP7Ob1ihGho32jd32N/s2LnxmyEUKVE+de?=
 =?us-ascii?Q?YHasTYDd9g0rqKBty8Y99moULnli6i1tRqR6XFnFl0jKKQSd4ZuV9NI1If99?=
 =?us-ascii?Q?/TuvgZxC6kFGhqWENToKkpJ30Sbtbz8SvnwrT6u1WXGX1S29dRwmhulDcpkM?=
 =?us-ascii?Q?lys5jUEQvXMG37Ioa/i0cuL1gCIibSzgHZzsewjGYnW68ekV+P45B/QN0rfe?=
 =?us-ascii?Q?2xYJLHaqwvFlKqz8F0fzEyNd56no5szjvyOEZyqZ4s0L559v2axmOvvc8KDK?=
 =?us-ascii?Q?HzYMzgGiLSimeuVxqLkCkwf1/oSHQEH64bAEgH6TgLxN/IQWcWCjvPC/IdzX?=
 =?us-ascii?Q?34BWvmYAAxz6WsDATbWhi8qyYr+9sAXsErOB95yz0lHDEy/+SliYwmIScLUD?=
 =?us-ascii?Q?NKojgwXGJcUVBtBGSkFR2eBYyPHCRgWhmBOG/MOP3tbaFBEevW/5NygVtwE2?=
 =?us-ascii?Q?J8uJLXrPcY8efchhrvNpE8GG9VnwU9Ho13JvaQidGna0vWGBfyTPbRl3x6TV?=
 =?us-ascii?Q?xvGS7aeGNRHJ7SBVtzPxBko3pafi7S9GxC+3Cpl46mC937PuG2W1bogvyQPc?=
 =?us-ascii?Q?Bfx82oN9AzfDvBdfiAUQMopzwUTCyJEiFXe7aeCXhsnkwXUre2Vxav/xQmnT?=
 =?us-ascii?Q?LmBqgmSNTvQKAbqD+d8C1T5iZ7pNrD576yqrMNOV4yPnPWSgkn4EZ5vaqM5C?=
 =?us-ascii?Q?JpRL+u11mfe1kcKpR5CBuUjK/4tDVoGIgENllcHoS90ZsU8YlbfJFQWNcHZf?=
 =?us-ascii?Q?PzO9zFAt7QTmWQYwQn3fMjK3CQDJrydJXG68nlmKIpXnV39YZJMaUV5hmYyc?=
 =?us-ascii?Q?jmbM+C3cZDxv4vF2a8LVrTtLs2RJXbGUsS4wX6MqI/EHiSxmGpJxGhH4EA9n?=
 =?us-ascii?Q?LwOR7Q2O88ykE9NZREeyHRV7iSNiJ4scU9tXIdMIBW2NDOxBKOdugIdYecKi?=
 =?us-ascii?Q?oZAeT+cBrZlV2Gd+fl7wIjMzqKKlSIkB7a9SiGZL6fuvbBNySMarBfADIkHD?=
 =?us-ascii?Q?rnbyv2ROEKYQVoYgKR9YHPO+YGgEXa7DjWNlMQkUysCEXSwzdIXdThuKInM2?=
 =?us-ascii?Q?2ahNBgnJzjQDfeLUIWPo39kiDRevl3ozE6yTJgs/HyCOI5XitbWquJStqsdM?=
 =?us-ascii?Q?CW0Y3AzUiHSWOgEUC3Z9QE1ryVLxyOvJbRcoJfg4mlAnCaRRmWMCgs/H2qeB?=
 =?us-ascii?Q?JMni9PvczvNsKfE9qp0Cx2FBSTD7FY93a3jjzVP13cWXNls602R81/hJDfmI?=
 =?us-ascii?Q?3P6sOTA1yErgEnzDgPEsW8oh3Ipr00XABEgmw0JHH3FYFlrE1Nbt6lPZeu42?=
 =?us-ascii?Q?HUvcp7BTDtbuLY8J/CRlpGvvrYb1YEDOzFkL4O/WU1mdhVkj25tU7rov7hnD?=
 =?us-ascii?Q?h8aB6w9RpRy4mTvl3RDCxKHMLGlxN+Z931lmrZgK4gj4g+2UwbdEdetwfMTF?=
 =?us-ascii?Q?TxzijQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f81361cb-8a9b-4a10-52d0-08db25fe2f88
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 09:09:45.3704
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XVF1OZNPlqMmpE3Jxu38fZp7FhW8/CLruywcjK3Im10aWTFKk/5nUYa15KdRMHLMnu8/gO9L0jBHHbXgG6qeByzUTf3P9Z4JgqAFnuLf5xU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR13MB5112
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 15, 2023 at 12:05:33PM +0100, Markus Schneider-Pargmann wrote:
> Interrupts are enabled a few lines further down as well. Remove this
> second call to enable all interrupts.

nit: maybe 'duplicate' reads better than 'second', as this call comes first.

> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> ---
>  drivers/net/can/m_can/m_can.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index 8eb327ae3bdf..5274d9642566 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -1364,7 +1364,6 @@ static int m_can_chip_config(struct net_device *dev)
>  	m_can_write(cdev, M_CAN_TEST, test);
>  
>  	/* Enable interrupts */
> -	m_can_write(cdev, M_CAN_IR, IR_ALL_INT);
>  	if (!(cdev->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING))
>  		if (cdev->version == 30)
>  			m_can_write(cdev, M_CAN_IE, IR_ALL_INT &
> -- 
> 2.39.2
>