Date:   Thu, 16 Mar 2023 10:10:44 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 03/16] can: m_can: Remove double interrupt enable
Message-ID: <ZBLdFDMf+2YoRK6H@corigine.com>
References: <20230315110546.2518305-1-msp@baylibre.com>
 <20230315110546.2518305-4-msp@baylibre.com>
 <ZBLc03OYJLLhHLNj@corigine.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZBLc03OYJLLhHLNj@corigine.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0wgDLgV6cg3kO71bkSKw21rQPRdwROz1ls0mRD7oMEUv4MAL/dle7OsPF+9T?=
 =?us-ascii?Q?+ajajWMqk3rmUgdababm0kxniuvByiELremaCTVp61M/6OgCq6NzD5cKtpXp?=
 =?us-ascii?Q?+uE2ZIJqlbzA8Dm6avJtFFbNfuxiEYdR0fIIycvCVpvv+o+7LUr2v8cDzUXz?=
 =?us-ascii?Q?++OAOBtXHoETw0qRc5C6n4ia/SIhEeY0di7G+LAlFm+LnXP3/98yLy2DqiR9?=
 =?us-ascii?Q?T3yJIMNKGDIW5lb7dYox+U8szSegih22dqnEEjk53WDYPCRnLlYFvIJ/ZGWj?=
 =?us-ascii?Q?hZ8tzM56wqRtILrzGOzj4CfAjf9hN/AfX2b3hqYgb+ozhmBoUQK28MuNpiO+?=
 =?us-ascii?Q?ZccKAtSjEUMs3D9HGEgZlF+DUVB4tZ14B+0kAo+bEpc9oUOZtSHaO1qof+QN?=
 =?us-ascii?Q?1kdCvLpM972Q8SR/mViiOxUVU0aknY8LXbcEppDbEcKdbqVyc5IbMOrRm6QE?=
 =?us-ascii?Q?BFIcke6XLXhh58YrCzqAtAzbfN6y0mLjP/zj44k+QfjsIEhTr5GSB0vSYfqw?=
 =?us-ascii?Q?Vl6M/HoP1PTSyfNgPFNSCYzrTQvt3N+elfndJuBltXd6ygdX434kfD/ax762?=
 =?us-ascii?Q?36Duhvkh2iojuY/F4gm/fftcYdga5iFOfRlD329ttzswpCd1bk8SSAZc0MJZ?=
 =?us-ascii?Q?53LnA9hV3+sVtvxo2FRCQ74QwumTQ0GMmD2kXNZeKpZ4fid7ddLKpyR02O7z?=
 =?us-ascii?Q?A0YD8nXAgShxrInBcjnFJx2lXnMJgRKhswrYNZj+dMDnt7EuFrQ+0vmH2RGk?=
 =?us-ascii?Q?JZOMhimcTXnQsAWNFWgCxuSexevZvqYR8QYXZMWmkETeFXEKORu4doyUWpBf?=
 =?us-ascii?Q?ptPReHdjPAYmzG9lI/KLf8UkxSx5FB1Pyl5+TfzabLJaSSSqG/8OjmXSzhaK?=
 =?us-ascii?Q?cgFkq0yDBj8jkF/Bj/NJZhIFcb9NSST9rfiusmIm+ZLmBK68iCvmwdohan7A?=
 =?us-ascii?Q?vL+jLpw0pZRHie7F9F6fFYUjJRcdDPD6OI04DGy+ZfA43CqoG+mv3LnAPjZY?=
 =?us-ascii?Q?nibfl/1/ErGZrNFjPxe5jqfy5wm/th/JkY4913c6NHkg/y6+IWGg1HEjyvd4?=
 =?us-ascii?Q?XMZfCwLYu4wx4JCjoth7G7cqpVIxzpK40ag9peaTMVLv4EvbSBR+cH12O3QO?=
 =?us-ascii?Q?uLDOEMUgCdf698cSRDcuB4ohDG9zuvn0knR0u15ctlUkzPj4hN02Cr1NvULU?=
 =?us-ascii?Q?kYh4VSJMSJZdKWLzveZsP6VV7tzGjox+83/KH4IQH4Qz1P9ld3Zt2s25ykIh?=
 =?us-ascii?Q?urkchm64dCF+npQsYuKWqxLcAjCGv2/njVx6gb4F3peLsXv/ZKu23miXij7W?=
 =?us-ascii?Q?UclRD6YEPJ6lWRvF2TqPpBQTipHi86xDWIKUuKhQBdn/wMzPvmsVYEU1ub2T?=
 =?us-ascii?Q?iGJYAA9FDima2MKDdX+fwwG691pZCS0+G0wW1B6/hNgTNk60WQCRQHFz75TJ?=
 =?us-ascii?Q?7eTJsIL61SHtFrdtjxZ/rOb4mA2te90k2rVOYk7gmK1t+nVvy9RMjgu239fu?=
 =?us-ascii?Q?LHAwcp6s2HmO4bCKr/n3v4yiQELPqnma2/ldAzj501pmDlVs6rQjT4n219ie?=
 =?us-ascii?Q?Y9OJMHt9nawqQBzwUS8Ox/1NpaK1tZ9lkb055hIyPWZx8OiQRMUt1vIbw5jk?=
 =?us-ascii?Q?EvQG8pb6rkox9AcmbJLhFYJp6bY1PUl73Hd5BedNdVuk/cGCoEf0SSSjzFGZ?=
 =?us-ascii?Q?e6y8ow=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4beed0b-4ff0-470b-d5cd-08db25fe5673
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 09:10:50.6659
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XNQxhWCXONvxhm9Ig8oR6JAJx9oUCz9vwgBsfnqSbrWtjzb8T0+Q4Osq2v9ulP3/C3rY2zMlFJYkiIQdyyjf53/C/OAe9CVRQNlCFJBrKbE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR13MB5112
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 16, 2023 at 10:09:45AM +0100, Simon Horman wrote:
> On Wed, Mar 15, 2023 at 12:05:33PM +0100, Markus Schneider-Pargmann wrote:
> > Interrupts are enabled a few lines further down as well. Remove this
> > second call to enable all interrupts.
> 
> nit: maybe 'duplicate' reads better than 'second', as this call comes first.

I didn't mean to imply this should block progress.

Reviewed-by: Simon Horman <simon.horman@corigine.com>

> 
> > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> > ---
> >  drivers/net/can/m_can/m_can.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> > index 8eb327ae3bdf..5274d9642566 100644
> > --- a/drivers/net/can/m_can/m_can.c
> > +++ b/drivers/net/can/m_can/m_can.c
> > @@ -1364,7 +1364,6 @@ static int m_can_chip_config(struct net_device *dev)
> >  	m_can_write(cdev, M_CAN_TEST, test);
> >  
> >  	/* Enable interrupts */
> > -	m_can_write(cdev, M_CAN_IR, IR_ALL_INT);
> >  	if (!(cdev->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING))
> >  		if (cdev->version == 30)
> >  			m_can_write(cdev, M_CAN_IE, IR_ALL_INT &
> > -- 
> > 2.39.2
> >