Date:   Thu, 16 Mar 2023 10:15:26 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/16] can: m_can: Disable unused interrupts
Message-ID: <ZBLeLq/JSE8wLeUC@corigine.com>
References: <20230315110546.2518305-1-msp@baylibre.com>
 <20230315110546.2518305-5-msp@baylibre.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230315110546.2518305-5-msp@baylibre.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?B7DJUaZuZAvumyzYLRqb+ZzddNajqoUQcBndfFrN88x/RuiBAeH+PVtAk90T?=
 =?us-ascii?Q?iQgdaHBvvfLqxQr/hPOLUUT3WWvvLmBAv5MdTwBeDhYY6kki3lOo7bWHL7AC?=
 =?us-ascii?Q?eANEWLovUp3Gnw1JSWotyRa4pqXNQZv4TSSOdcjKoOs/Pz/rhUXo7XrdNl5w?=
 =?us-ascii?Q?BJvVnOcJiaQlSbgINXJkE4YNNT9u323LCQZ/jba9Sjga+eRhyndzv417ilTu?=
 =?us-ascii?Q?ZGg6j7WtI0yZ2pPt4g7YFrK5BZJ1dZwVY8eUYbvilktk2Zp0v+mhnwknWuUD?=
 =?us-ascii?Q?/kfXeKEdQzKZvsSEVnLL54BeZEWbSGgpt1rEMmgaqTG5qFEydLIWdKBAAcCK?=
 =?us-ascii?Q?BaMAbVPFgFlLg+XidZ4qkDspKFkSv6unsdjqf72kXS2T19nxC3bosZ8SjorT?=
 =?us-ascii?Q?yJN882vLcYgWlOA+CT4IoFdmFZh0zoCa6sIlQnuJI5lb77SuRZ9KAwCPmXaI?=
 =?us-ascii?Q?S3OA+L2HKcQPMV5cFIvxOKsQniEusGuBhbg6epIArI+q/RdPvQVOST4+Tfyb?=
 =?us-ascii?Q?AJXwha/TOY/oxly9ctBipuLSlcirLoWDjQrcnh5Lv3W5cmch49qJ1NGmU2SG?=
 =?us-ascii?Q?W0FR6KL+IdywYr1vxWNB98bQHujzgv3P8xXkLrtWHPxQwq2cljvlRO7qJVCX?=
 =?us-ascii?Q?A9JcAfWWb6UsYqbypx3oluH5U8/PYBUd5u4MYGiTrJr2LkLBA92wJEX5u4Qj?=
 =?us-ascii?Q?6G1j9BqfOqjKDvb7Q9smEYBatDmE5gUP+J2mAdozjsqmUylA3PfkfXUDHBlW?=
 =?us-ascii?Q?aWyCdhIfCqCwoOiypAmD5e4rwgeRSU5PVimQyRz2WORzgk6N+OAj3Tz9FBPS?=
 =?us-ascii?Q?2dkyEF5UbjOoFxXuJ/H9EnDr+0ihS2zogJePl/Gr7K51Um61ULiMpXx7EfgO?=
 =?us-ascii?Q?Z+ZEBaADsDE4F0DoN9vwmJwaMAQo2Gp7p7PyXVqBuCkJDm1SC4ENcoq6AO5i?=
 =?us-ascii?Q?9GBi45RDssHHjM7p8KRB67ETmE3aM2HPtoZJsy8ybmacd//l2u1vI665bZ70?=
 =?us-ascii?Q?smLgJX68dQoRORTa1tgTyj56GT7rQqFJlEdJKcyiqth85OrLKI8kKMNxUdlP?=
 =?us-ascii?Q?HJm5zsDXtW2UjXK6K6PkLToeDdvTwTdVBxRJZzq/yf9DBHG7PcGEqDXg/N/o?=
 =?us-ascii?Q?g1xMZ8R8pE4MhNpeCoQNBIpSbAW9Ki3RUvvbvCtRiFF59uABPHeNIPKkiwQm?=
 =?us-ascii?Q?vc+g8B3T1ukO9yM8jtMacbFJsz5in6DaLCzhruRRcmyE6EV9/rtjhhQdbMJr?=
 =?us-ascii?Q?tgo2jLRzZL79Ucnzp2vzLYkHDruMAA5Us8Aaz4MmGcCiqr3qGA8ZWU4lMlXW?=
 =?us-ascii?Q?aYr6JmJwLShoakn8RIKFl5qqRyf5uxFaQ+bA3SFmJ2nSo7+wK007bzA2i8F7?=
 =?us-ascii?Q?xNumFRqSQ6skrrdiMnl7jbT9WRCzEE0VTWBUX1ehyXWpwu3ceZStBVQw5ayi?=
 =?us-ascii?Q?qz02KkvRjLqXRZ15jeAmYCcDCdZeAwnqOv6aY6MeYSSJUQeMWDEWmG0hqwek?=
 =?us-ascii?Q?6zyw8sMef5yhVEl2PGXNv9h8CFCsA7qSiL1t8YJQq8Z2darHQJ4wXFGj15zO?=
 =?us-ascii?Q?tQAMBlt6mhdnqib5RqRC4ranjjMEIOUlCWvCfXGOY5q6EgYyP5n3k9KinqvL?=
 =?us-ascii?Q?DveUDHgeUonwXNlJtEeE26XpMJGCd9aaLYN+qFx0qzribIeE49OnOMbR7taM?=
 =?us-ascii?Q?sYtdAA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f56664f3-6404-4a30-828d-08db25fefe1a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 09:15:31.9378
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x4rrjYyiloPlny6Eq0NF5kOfvpNv7hZMcI6elPuDbey+ybsUvA4Wd/Ao1hOVDl+F5KNRfO40H8uUrkjpks7Faiy8ZK/dIU1lrm/4Ca1HGb8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR13MB5112
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 15, 2023 at 12:05:34PM +0100, Markus Schneider-Pargmann wrote:
> There are a number of interrupts that are not used by the driver at the
> moment. Disable all of these.
> 
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>


> ---
>  drivers/net/can/m_can/m_can.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index 5274d9642566..e7aceeba3759 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -1261,6 +1261,7 @@ static int m_can_set_bittiming(struct net_device *dev)
>  static int m_can_chip_config(struct net_device *dev)
>  {
>  	struct m_can_classdev *cdev = netdev_priv(dev);
> +	u32 interrupts = IR_ALL_INT;
>  	u32 cccr, test;
>  	int err;
>  
> @@ -1270,6 +1271,11 @@ static int m_can_chip_config(struct net_device *dev)
>  		return err;
>  	}
>  
> +	/* Disable unused interrupts */
> +	interrupts &= ~(IR_ARA | IR_ELO | IR_DRX | IR_TEFF | IR_TEFW | IR_TFE |
> +			IR_TCF | IR_HPM | IR_RF1F | IR_RF1W | IR_RF1N |
> +			IR_RF0F | IR_RF0W);
> +
>  	m_can_config_endisable(cdev, true);
>  
>  	/* RX Buffer/FIFO Element Size 64 bytes data field */
> @@ -1364,15 +1370,13 @@ static int m_can_chip_config(struct net_device *dev)
>  	m_can_write(cdev, M_CAN_TEST, test);
>  
>  	/* Enable interrupts */
> -	if (!(cdev->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING))
> +	if (!(cdev->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING)) {
>  		if (cdev->version == 30)
> -			m_can_write(cdev, M_CAN_IE, IR_ALL_INT &
> -				    ~(IR_ERR_LEC_30X));
> +			interrupts &= ~(IR_ERR_LEC_30X);
>  		else
> -			m_can_write(cdev, M_CAN_IE, IR_ALL_INT &
> -				    ~(IR_ERR_LEC_31X));
> -	else
> -		m_can_write(cdev, M_CAN_IE, IR_ALL_INT);
> +			interrupts &= ~(IR_ERR_LEC_31X);
> +	}
> +	m_can_write(cdev, M_CAN_IE, interrupts);

This now enables interrupts outside the if condition.
Which was also the case prior to patch 3/16.
Perhaps it makes sense to merge patches 3/16 and 4/16?

Perhaps not :)

Regardless,

Reviewed-by: Simon Horman <simon.horman@corigine.com>