Message-ID: <106b5618-908f-becc-6eb3-75ef136a48e4@suse.com>
Date:   Thu, 16 Mar 2023 10:23:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 1/1] Guard pci_create_sysfs_dev_files with atomic value
Content-Language: en-US
To:     Alexander Stein <alexander.stein@ew.tq-group.com>,
        Bjorn Helgaas <bhelgaas@google.com>
Cc:     Korneliusz Osmenda <korneliuszo@gmail.com>,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230316091540.494366-1-alexander.stein@ew.tq-group.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20230316091540.494366-1-alexander.stein@ew.tq-group.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OG9LMlVNQy9zcHhxQmtTckJjQlhFQUlXREdvTEFraGE3eTl4ZjJtSGVCd3pX?=
 =?utf-8?B?Y0p4WHIvSHNuN1p2d1hGeE1KTzdxRUwzZklCd2h3Tm1OOGtiZEE2WjgxR1E2?=
 =?utf-8?B?RnZyVmd3UGtKOUZIQzJ0T1Rva2kwSjM4Wk9YMkVnTWZLRkFxbUZKdXkrYmRh?=
 =?utf-8?B?MjlIdXlTZWNQamZXUEVXU0xYZ3U5Y2swU04wSXhKZDFNeTFIU1FwWEJINmpZ?=
 =?utf-8?B?blZSc2RnN3F5VUltTHYvOGtkaGVUcXIzcmRIc2dxMlFJTEpnbzRWb0MxcGtr?=
 =?utf-8?B?dUJJSHJXYy9xNWNFVlVUZkE1WlM1RmFjMlYvVmFoNmFPTWpJeDdUK3YzTHlM?=
 =?utf-8?B?UXRmN2hPUS9WbmlMazByVjREaWVnZ2pOTDh4Y3lhdVNwLzkzcHNucXZYZEI2?=
 =?utf-8?B?bkxDdk10aS9ISFFXV041ZUpkTVVnU0Rnays2NmVUdDNiM2h0SURGRHJQOFVY?=
 =?utf-8?B?R3oyVktNeC95QXRWcGF6WUx4M1F6bmF0REp4dG5xRDhZaWRTVWtuUGdRU28r?=
 =?utf-8?B?M3ZWNHN4NE9HaWZhZzBjU1lLeVd0WVJvczk5VmNCRXdjS3dFNTVMN2wxVUJs?=
 =?utf-8?B?a3NaYWtoVjVnRTFCRlFxcU9RMUx4N015N3V2Tll3L0NvbEtMbHp2VE5RYXV5?=
 =?utf-8?B?WEFkYkg5bE5uZkhYUXNBK3dDaUE4VE1MczJpamRDRnBLU0hwUXVsakE5L0pB?=
 =?utf-8?B?dEZWeXlrS09Bc0tCUGRJdW85bm5kU0wrSHJTUWtzWlhqc0VybjFDU2RlTUJP?=
 =?utf-8?B?a1NReTRCaERIb210ZmFBZVZCYWMwYitiM0w5dWhmNjRtY3JmM0tmZTBGeEYw?=
 =?utf-8?B?RVdRb1lQSEdSZk1DL3dSRWFsczhuQ3ZNV3Ywb3hzRHhtQTJTcjRlbFFQRFQ2?=
 =?utf-8?B?QUVHelRsdCtPelNYZzlETUs1dGdzSVFmd2p1K1dlYnZvbHRReEtlNjI3eFAx?=
 =?utf-8?B?bFBpR0VTQ0p0T1FMV0thVko4VzFiejVFeU9NUzlGS3lxT0FBMFBNaUg2VXEy?=
 =?utf-8?B?Rkp2MkpvTmpia0h3MVJtVmdaY05FVnJwK1VHNGxmbmNwMXpOUGVWRThtRkNs?=
 =?utf-8?B?TS9jWGdwYkFsSFJ5aXhiaXBrT1Y4WHBFTmZKZFlqMWJXZVZrSkUzUm1tYVdO?=
 =?utf-8?B?aW1IMS9OTWNxb05rSkM2c2xNOHhZMERaRlZjV1VwbEhkTU56NWtzZnl1UUhK?=
 =?utf-8?B?U3hjcGVRK3BtcHFFQmxuY0M0U09HTXcvSjRwbXJwZGtYYk1meW5pZVlNYTlU?=
 =?utf-8?B?ZzBXbnNmUU1JdW8rMTlXbzYydmdoSWNraGFRcnQ5b3Z5RFlVR3dEVFZISzZi?=
 =?utf-8?B?UW5MVmtBN3pPdzRHZXcveEg5b3VNZGxJL2VrZ3FEZHkreDRndTBKSkF5anBB?=
 =?utf-8?B?MmtHQ0Y2aXlYaUFubFBJYis4NTB5dWhjRjVXYTYwdnFkYzdKNStIZ2NqTjFU?=
 =?utf-8?B?aGFKdnlFKy9kcWE0ZUErN2VqVCtqeU9tTTY5a240Kzl1Tk9nWHpoS0ZuWGgw?=
 =?utf-8?B?eWxFcXNYL24vZ3JuM01pUWdhYVFFbDZLNnlzV25yU2pOeGZGc05BcnlLbHJ6?=
 =?utf-8?B?V2xuc2hCeXgrS1RXY2Nja250K1QxQmdiZlc3SHpEOGQ2UUZWSjVHbVY5eGxY?=
 =?utf-8?B?T3ptMCtORk5DdnhDeHp4dEEvTzdreExzWGlJVzRXMGFtRVlWNFhoS21CSi9k?=
 =?utf-8?B?RUkzVXZGNUtuL1JhZWVGd3B4bm9rakxEVS9lL0owSms4ZUx6VmpUN1doSVll?=
 =?utf-8?B?TitWc0tHKzdadU5RU1VndVp4SXNNVmQrVGxxQ1NwMmVrUW5QeE9OMWJZbTVS?=
 =?utf-8?B?YVFMamx0b0hHTnhvT2V0RFprSlBnMjArQ09BdFJVdHI4UlVsMnA4VFdtakIw?=
 =?utf-8?B?UHgrcTdZMi82LzJaSkpGdHRMRzBFQzlPZFgxVk9yUFI1OFBjbWlMWkQzVmVr?=
 =?utf-8?B?b21lczdBU0RTNmUyc3lMeVMvSnhUS3hKUm9vUFJlUmc3M3REVXRuMHFGSm9o?=
 =?utf-8?B?dm9LVUVqZU43RGN5dTNiL1RiRTRGRE1vR3dvcEF4Y3VZQ0pMTTBMVUs3UFlE?=
 =?utf-8?B?NDl4NytucW9UZ2pLTzFQRnZqajNUMCtyRU56YlI3RVpjTWdON0pQUysxZExi?=
 =?utf-8?B?ZjlvaHJaMG1vbndFUkhGVklwS0hLSHRqZDdkRVdDaEF4NnVLbUp4MERxRXFy?=
 =?utf-8?Q?eddTfmnpnExqxXs1eYZFWuqnxQYxnLhjfIJ1HOlnoH2f?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0c9ee7c-cd1d-4a1f-1355-08db26002af9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 09:23:56.6972
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A0VL7rOGYBGNMX880TImvyfA1Jt3X1J+m2b1ywY80xv6TY6KFAfKSt8eDSTv8a6JSJynsPiTCFUEt5YV+gHEGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9955
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 16.03.23 10:15, Alexander Stein wrote:
> From: Korneliusz Osmenda <korneliuszo@gmail.com>
> 
> On Gateworks Ventana there is a number of PCI devices and:
>    - imx6_pcie_probe takes longer than start of late init
>    - pci_sysfs_init sets up flag sysfs_initialized
>    - pci_sysfs_init initializes already found devices
>    - imx6_pcie_probe tries to reinitialize device
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215515
> 
> Signed-off-by: Korneliusz Osmenda <korneliuszo@gmail.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>   drivers/pci/pci-sysfs.c | 6 ++++++
>   include/linux/pci.h     | 2 ++
>   2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index dd0d9d9bc509..998e44716b6f 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -1497,6 +1497,9 @@ int __must_check pci_create_sysfs_dev_files(struct pci_dev *pdev)
>   	if (!sysfs_initialized)
>   		return -EACCES;
>   
> +	if (atomic_cmpxchg(&pdev->sysfs_init_cnt, 0, 1) == 1)
> +		return 0;		/* already added */
> +
>   	return pci_create_resource_files(pdev);

This is very likely a bug. You are returning an error in the error
case. Yet the flag stays. And simply resetting it in the error case
would be a race. There is something fishy in that design.

	Regards
		Oliver