From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Stefano Garzarella <sgarzare@redhat.com>
Cc:     Jason Wang <jasowang@redhat.com>,
        virtualization@lists.linux-foundation.org,
        Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>,
        eperezma@redhat.com, netdev@vger.kernel.org, stefanha@redhat.com,
        linux-kernel@vger.kernel.org,
        "Michael S. Tsirkin" <mst@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH v2 3/8] vringh: replace kmap_atomic() with kmap_local_page()
Date:   Thu, 16 Mar 2023 10:25:12 +0100
Message-ID: <2155970.irdbgypaU6@suse>
In-Reply-To: <CAGxU2F4k-UHxHxpLcsvKvJdvcXfb3WpV+wU=8ZpnJwMNkx0rdA@mail.gmail.com>
References: <20230302113421.174582-1-sgarzare@redhat.com> <1980067.5pFmK94fv0@suse>
 <CAGxU2F4k-UHxHxpLcsvKvJdvcXfb3WpV+wU=8ZpnJwMNkx0rdA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On gioved=C3=AC 16 marzo 2023 09:09:29 CET Stefano Garzarella wrote:
> On Wed, Mar 15, 2023 at 10:12=E2=80=AFPM Fabio M. De Francesco
>=20
> <fmdefrancesco@gmail.com> wrote:
> > On marted=C3=AC 14 marzo 2023 04:56:08 CET Jason Wang wrote:
> > > On Thu, Mar 2, 2023 at 7:34=E2=80=AFPM Stefano Garzarella <sgarzare@r=
edhat.com>
> >=20
> > wrote:
> > > > kmap_atomic() is deprecated in favor of kmap_local_page().
> > >=20
> > > It's better to mention the commit or code that introduces this.
> > >=20
> > > > With kmap_local_page() the mappings are per thread, CPU local, can=
=20
take
> > > > page-faults, and can be called from any context (including=20
interrupts).
> > > > Furthermore, the tasks can be preempted and, when they are schedule=
d=20
to
> > > > run again, the kernel virtual addresses are restored and still vali=
d.
> > > >=20
> > > > kmap_atomic() is implemented like a kmap_local_page() which also
> > > > disables
> > > > page-faults and preemption (the latter only for !PREEMPT_RT kernels,
> > > > otherwise it only disables migration).
> > > >=20
> > > > The code within the mappings/un-mappings in getu16_iotlb() and
> > > > putu16_iotlb() don't depend on the above-mentioned side effects of
> > > > kmap_atomic(),
> > >=20
> > > Note we used to use spinlock to protect simulators (at least until
> > > patch 7, so we probably need to re-order the patches at least) so I
> > > think this is only valid when:
> > >=20
> > > The vringh IOTLB helpers are not used in atomic context (e.g spinlock,
> > > interrupts).
> >=20
> > I'm probably missing some context but it looks that you are saying that
> > kmap_local_page() is not suited for any use in atomic context (you are
> > mentioning spinlocks).
> >=20
> > The commit message (that I know pretty well since it's the exact copy,=
=20
word
> > by word, of my boiler plate commits)
>=20
> I hope it's not a problem for you, should I mention it somehow?

Sorry, I had missed your last message when I wrote a another message few=20
minutes ago in this thread.

Obviously, I'm happy that my commit message it's being reused. As I said in=
=20
the other message I would appreciate some kind of crediting me as the autho=
r.

I proposed a means you can use, but feel free to ignore my suggestion and d=
o=20
differently if you prefer to.

Again thanks,

=46abio

> I searched for the last commits that made a similar change and found
> yours that explained it perfectly ;-)
>=20
> Do I need to rephrase?
>=20
> > explains that kmap_local_page() is perfectly
> > usable in atomic context (including interrupts).
> >=20
> > I don't know this code, however I am not able to see why these vringh=20
IOTLB
> > helpers cannot work if used under spinlocks. Can you please elaborate a
> > little more?
> >=20
> > > If yes, should we document this? (Or should we introduce a boolean to
> > > say whether an IOTLB variant can be used in an atomic context)?
> >=20
> > Again, you'll have no problems from the use of kmap_local_page() and so=
=20
you
> > don't need any boolean to tell whether or not the code is running in=20
atomic
> > context.
> >=20
> > Please take a look at the Highmem documentation which has been recently
> > reworked and extended by me: https://docs.kernel.org/mm/highmem.html
> >=20
> > Anyway, I have been ATK 12 or 13 hours in a row. So I'm probably missin=
g=20
the
> > whole picture.
>=20
> Thanks for your useful info!
> Stefano