Date:   Thu, 16 Mar 2023 10:27:41 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 06/16] can: m_can: Write transmit header and data in
 one transaction
Message-ID: <ZBLhDSl4a7AuCgNy@corigine.com>
References: <20230315110546.2518305-1-msp@baylibre.com>
 <20230315110546.2518305-7-msp@baylibre.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230315110546.2518305-7-msp@baylibre.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oNa6jUwPEoiX+Hg5uHpsLrImoCicQ8CxpqmWEhb3icuEioQKiu96fdk6Z0EA?=
 =?us-ascii?Q?ilYo/WejawrsDvMWvd48SIUCKHzvONciW7JHXLcpAw1cBeNcQjWN4oqAn9JJ?=
 =?us-ascii?Q?4/WKovPk6Ii9QEPCR6tN0p8JfLDat7AWruNvirde7Wni52BvizLy9O+EVxoi?=
 =?us-ascii?Q?Ub47uwOmAP+2h3NyWrQHEM4dbmSuBY/PD9xP4N7GjG69+ftfXNtcwAfNmnrc?=
 =?us-ascii?Q?ohmuHfBVZV0p2sjBSdaFu3fehyJoJV9ZPAN2IwaG7uQP+TgojxXpcww6QwRw?=
 =?us-ascii?Q?8RK+EgAvZKeV9ppro/bYmmlKD2cTHhbxDSXsUmFUzU/u4eeCjA57ZAoLeUVa?=
 =?us-ascii?Q?0KOZ3iylWTcOmTSOqj1xWCYh1BoIhnunQR1FoPlzi5FQSSNceuSL/dkMmUtD?=
 =?us-ascii?Q?HpaU9jDHI5bQleglRt2cci2i1qS4j2RN73HtPGGolmYcL9aPAh6uD7FLEJCX?=
 =?us-ascii?Q?Zdwy0KlbgqjeQZwnbI8ex0kv14EJrV/fT6reqa0tA2NOy4Er2KxC0qVwdeyX?=
 =?us-ascii?Q?3fXrecf3JXjSNTzPKOYy5ek4WKkbnXBb9OqpioghLyS/0/FhBDrdi00hp79P?=
 =?us-ascii?Q?/djYXEWesYsjPOkCVMg5hgnQFOJsrGmGRkC2+blo6x9rS0uobMqoUqbDdLCO?=
 =?us-ascii?Q?qNCStmdpwkcaSjWSX5dnMCoaAoHvhb+3I6kpkIb/o2H9NvMGya7fH2tQidmk?=
 =?us-ascii?Q?GIl0BoaupfSPLLEVKr0jzESHJGndmchhlpzkm1kCDrpZ8CnjA9uB2AHBSoLr?=
 =?us-ascii?Q?zfn/4/ZLIRNoPdQ2vShwXCjbAcHYs3K6+jNsZ24eRnOhcSUnzazU4w3DgTl5?=
 =?us-ascii?Q?Qje7dqA4AJQJSMOApEHxKg+L8dVKLeQNRFRarrcqED5+wcAmo6063YS04O5G?=
 =?us-ascii?Q?y+vtpYVqxU7rqkg/Umz1bfnje0JLB04/DB/0lcO9a+8JrLYK7SsMe/kcNaSs?=
 =?us-ascii?Q?u92X0Yzpk8D9ZqLXyF56nPLTrrlyhFzXhZU72crkHpOF+uCKpTTxsreP+MZL?=
 =?us-ascii?Q?QCNMIYPbtafCluBhZS0FisBPpkMPZ1a1K8Qb1KSnGt++TzZeZvA8eEERljoq?=
 =?us-ascii?Q?xFa8Tlzhh4r+y7m/5jK2Gs0vugWczcC78fyjlYwf56uj3o9R56XEJD5EutrX?=
 =?us-ascii?Q?OLziq0rUUy0fA+Z4A2NiL/naFF955ifN3vK41V1w9DoTZoeTGt+6CSxO6z2e?=
 =?us-ascii?Q?GsBoIA+pH9cCdXnJYxZAqTVaWTjB1qxxm5rqdubaWOi+eIXpYEEa+jGMzByH?=
 =?us-ascii?Q?Ct9DGviXJdvhJjfQE8/quZmgmOyg92NA6EVsCn882ATvB/IZcmDTb99lKaLW?=
 =?us-ascii?Q?38l6QX5jkZRr0bXeWz78/3GDp506PZMoz69bKNGb6D5GmMzPzvGL/sp3xzWF?=
 =?us-ascii?Q?Qe/mUA0CtGSntnsRjcSnMNfBwJMAza0D0Iv7bCDxSfI/APITQxYc/pQ5h2U0?=
 =?us-ascii?Q?ZKsWAug6Mv7Y3eA7KPnEy8+7vTuEnN3gIH/xw6GFySwOGiX+qSefmQ4ad+Or?=
 =?us-ascii?Q?CFUSzg1SeXsXZ/XDtWi+5xoofqvKsJf/1xgf7MtUBhY6vAcrHWbU0ro8RvYy?=
 =?us-ascii?Q?dy/+KBAsd+CacjPCah1LPT3MnZWXp7clvL8rdSXTMootzo8IIqltXVnDpGMe?=
 =?us-ascii?Q?lcKp2/0wVLXzZqTJJ+Sh1DNrCezY2SpXQcH6WmdCygH0T3ZWswLp5Jtm4M2G?=
 =?us-ascii?Q?N0Z7Og=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db3a270f-edf3-4df9-70b7-08db2600b48a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 09:27:47.5134
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6N3KIRjtT3O8YLqpn4kjFAxzfwM+zBOE32RdLIZttkJkOX0VBiALr64SuVEcup6x0zhyv1QGVTLqXWwHRA8QO4YSaaTrQsUQcoCbXEYgtiY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB4463
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 15, 2023 at 12:05:36PM +0100, Markus Schneider-Pargmann wrote:
> Combine header and data before writing to the transmit fifo to reduce
> the overhead for peripheral chips.
> 
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>

Thanks for addressing my comments on v2.

> ---
>  drivers/net/can/m_can/m_can.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index a5003435802b..35a2332464e5 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -1681,6 +1681,8 @@ static netdev_tx_t m_can_tx_handler(struct m_can_classdev *cdev)
>  		m_can_write(cdev, M_CAN_TXBAR, 0x1);
>  		/* End of xmit function for version 3.0.x */
>  	} else {
> +		char buf[TXB_ELEMENT_SIZE];
> +		u8 len_padded = DIV_ROUND_UP(cf->len, 4);
>  		/* Transmit routine for version >= v3.1.x */
>  
>  		txfqs = m_can_read(cdev, M_CAN_TXFQS);
> @@ -1720,12 +1722,11 @@ static netdev_tx_t m_can_tx_handler(struct m_can_classdev *cdev)
>  		fifo_header.dlc = FIELD_PREP(TX_BUF_MM_MASK, putidx) |
>  			FIELD_PREP(TX_BUF_DLC_MASK, can_fd_len2dlc(cf->len)) |
>  			fdflags | TX_BUF_EFC;
> -		err = m_can_fifo_write(cdev, putidx, M_CAN_FIFO_ID, &fifo_header, 2);
> -		if (err)
> -			goto out_fail;
> +		memcpy(buf, &fifo_header, 8);
> +		memcpy_and_pad(&buf[8], len_padded, &cf->data, cf->len, 0);

I'm probably missing something obvious here but I'm seeing:

* len_padded is the number of 4-byte words
* but the 2nd argument to memcpy_and_pad should be a length in bytes
* so perhaps it should be: len_padded * 4

>  
> -		err = m_can_fifo_write(cdev, putidx, M_CAN_FIFO_DATA,
> -				       cf->data, DIV_ROUND_UP(cf->len, 4));
> +		err = m_can_fifo_write(cdev, putidx, M_CAN_FIFO_ID,
> +				       buf, 2 + len_padded);

This part looks good to me :)

>  		if (err)
>  			goto out_fail;
>  
> -- 
> 2.39.2
>