Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758704AbXIRAGU (ORCPT ); Mon, 17 Sep 2007 20:06:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756759AbXIRAGN (ORCPT ); Mon, 17 Sep 2007 20:06:13 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:36900 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756648AbXIRAGM (ORCPT ); Mon, 17 Sep 2007 20:06:12 -0400 Date: Tue, 18 Sep 2007 05:38:57 +0530 (IST) From: Satyam Sharma X-X-Sender: satyam@enigma.security.iitk.ac.in To: Paul Mackerras cc: Kamalesh Babulal , linuxppc-dev@ozlabs.org, Linux Kernel Mailing List Subject: Re: [PATCH] powerpc: Avoid pointless WARN_ON(irqs_disabled()) from panic codepath In-Reply-To: Message-ID: References: <46EA5CEB.7020104@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 20 On Tue, 18 Sep 2007, Satyam Sharma wrote: > > > ------------[ cut here ]------------ > > Badness at arch/powerpc/kernel/smp.c:202 > > comes when smp_call_function_map() has been called with irqs disabled, > which is illegal. However, there is a special case, the panic() codepath, > when we do not want to warn about this -- warning at that time is pointless > anyway, and only serves to scroll away the *real* cause of the panic and > distracts from the real bug. BTW arch/ppc/ has same issue, but that's gonna be removed by next year anyways, so I think there's no point making a patch for that (?) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/