Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7EC0C6FD19 for ; Thu, 16 Mar 2023 09:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230293AbjCPJ7D (ORCPT ); Thu, 16 Mar 2023 05:59:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229807AbjCPJ6t (ORCPT ); Thu, 16 Mar 2023 05:58:49 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA64E98EAC for ; Thu, 16 Mar 2023 02:58:25 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id eg48so5090438edb.13 for ; Thu, 16 Mar 2023 02:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678960704; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7rGyVHn72S3f+yP1Dpa8iV3gyVbOxOtWl0FDsXatOAo=; b=wotGgL7cieAvnZJI1ayV9RrXnV5X/12AOH5ogveYXgGa4RTFpKtGAdB5mDKcpBO8+D 7s9zugMXv9XO4iJWNTddZo58NpTxi4FkZVJwn/6/InkPGE9hc2Zo3n8PdZCc41z/gN+L I0dNoX/+1vJ9MIeb51CJC8m0HBeXhe8KylNjXAw5JrPwgcfMy5FJGIwaW8NLsPOmaxFh suzxwhZmovIFO2X7pDnjfCboClsW+ASPPqV3xMg42Ep4BYR6aAjnRAlCWNQY0kKF+gUj JcXs8ddLMCkHZvP9D0FSskVVRkXal0qqppGP91erVttch6wFrtMzNYB5BDnx6BJKIZgx aP/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678960704; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7rGyVHn72S3f+yP1Dpa8iV3gyVbOxOtWl0FDsXatOAo=; b=aWzMsr6UQQLu1nD+MJvsetsEKxEvju9YJjMFVJrsLHWacbOQSBjjWFXRBl7XyQNcQ/ 8hd7ejyODENgHJhUDlEA8HywTVRPU2vcLzY1KpA57cyHnnqB3YL8oUuT/0n46x/Pfngw W0dx5mPQbg/RKL1meH7KBkbuC3PLMRYuRRQt3/sZHsu2HlWyDx1KsoaL3E+qfTeQX3Zp W41caBjW/cnnj+jTf4hjMvORBHkHLkRadWWJVGogQpXP6W5IzV6dtOSiIwJeAQc/fR+T xIz680JmdIgEfb1gEMHN3W/h2KP5A2tn3GoeHMMUg4Qrr6FHMe5y4K55WC0f8UU+SjVM PXPw== X-Gm-Message-State: AO0yUKW2VkqVCKDTBom0gy0DoBw+o3UUwTpZmFY/EztJZQLKyLq0lJBf 1zNPMKkWly9CeBXY1d0TJbjJ8g== X-Google-Smtp-Source: AK7set+uFvdmcmTzTE5XT99s0No3h1JbE0DG2UjhiIjcQ+/02A3xmqNlG8+ZhcJq7kpCG02F0bNZag== X-Received: by 2002:a17:907:d482:b0:8e5:2a12:8ec0 with SMTP id vj2-20020a170907d48200b008e52a128ec0mr9457794ejc.31.1678960704057; Thu, 16 Mar 2023 02:58:24 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:9827:5f65:8269:a95f? ([2a02:810d:15c0:828:9827:5f65:8269:a95f]) by smtp.gmail.com with ESMTPSA id l9-20020a50d6c9000000b004fc649481basm3614242edj.58.2023.03.16.02.58.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 02:58:23 -0700 (PDT) Message-ID: Date: Thu, 16 Mar 2023 10:58:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac Content-Language: en-US To: Guo Samin , linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis , Yanhong Wang , Tommaso Merciai References: <20230316043714.24279-1-samin.guo@starfivetech.com> <20230316043714.24279-5-samin.guo@starfivetech.com> <93a3b4bb-35a4-da7c-6816-21225b42f79b@starfivetech.com> <9038dba0-6f72-44a1-9f57-1c08b03b9c31@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/03/2023 09:28, Guo Samin wrote: > > > -------- 原始信息 -------- > 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac > From: Krzysztof Kozlowski > 收件人: Guo Samin , linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org > 日期: 2023/3/16 > >> On 16/03/2023 09:15, Guo Samin wrote: >>>>>> interrupts: ??? >>>>>> >>>>> >>>>> Hi Krzysztof, >>>>> >>>>> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes, >>>>> and the JH7110 SoC is also applicable. >>>>> Maybe just add reg/interrupt/interrupt-names to the required ? >>>> >>>> You need to constrain them. >>> >>> >>> I see. I will add reg constraints in the next version, thanks. >>> >>> I have one more question, the interrupts/interrup-names of JH7110 SoC's gmac are exactly the same as snps,dwmac.yaml, >>> do these also need to be constrained? >> >> The interrupts on common binding are variable, so you need to constrain >> them - you have fixed number of them, right? >> >> Best regards, >> Krzysztof >> > > Yes, JH7110 fixed is 3 pcs. Thanks, I will constrain them. Then just minItems: 3, maxItems: 3 here should be enough Best regards, Krzysztof