Date:   Thu, 16 Mar 2023 11:04:32 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 07/16] can: m_can: Implement receive coalescing
Message-ID: <ZBLpsG/NTq/0Bo+7@corigine.com>
References: <20230315110546.2518305-1-msp@baylibre.com>
 <20230315110546.2518305-8-msp@baylibre.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230315110546.2518305-8-msp@baylibre.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DHOuj0ap0+U2yCaBH1Uzn3K75zitmyRcHPpAXnSuxDg4livOY3i4Eexc/Ub/?=
 =?us-ascii?Q?6qM+/DQTkS6TcsiLFeKx0OtDHnIUTD35Mr1F7hxfnDiqb9SsY0CsTfvFc6Iw?=
 =?us-ascii?Q?z6QvII9Xm4UgwCDWBD+hCI5fpyIY/yU19IsJG1VPdo4zzZBqQHUfB9kPDO6M?=
 =?us-ascii?Q?oHAUMUdH+ZKd3xTNcKFn/DYETzfSsoVUaFIugrfSfJUMltM0pOkQq+K6/TqL?=
 =?us-ascii?Q?E+s26uZzZjTuCDyvDQWRONlewczKznrXN2g9dKszTLMkoyZoGmw8QKhN9unG?=
 =?us-ascii?Q?vvYsdRjDAk8K+X7V8NrejGDp5UJ55jAOdMRV5RAgszZOY3rqXUV7MBtnyv37?=
 =?us-ascii?Q?kCJSBGR0WB2dzJ9yxUryjN9ztvM9QDutZ+n94reVPlZzc/0uuSmOOpZo623G?=
 =?us-ascii?Q?JtlYln8nzKRY4NZIH0vf4TPpn8OBMfGOx3k+V6O7GzbkgiWaQFdLawRBZBRI?=
 =?us-ascii?Q?K5ITgL6btKmRRFvnC4R5Xe0ejQXJ4E1egL8GzJqClu32BjIybBrN6chl8O9W?=
 =?us-ascii?Q?F9jTghesRm78vM395fMz6JUfUM0VtKKsnysk8xXW5aOidMaJQrHjpes06KG3?=
 =?us-ascii?Q?2rmsQJGd68vtSzzfYdozyWJorqLyORX4/+vBLmRL8V2MCnp9q/4x9L+EhRzE?=
 =?us-ascii?Q?+3eDpU4e1Ubv8l7alkGekgEKDbRQ8fMrikhcL69YlKtfsDqSDhBiQGCqHmRY?=
 =?us-ascii?Q?vT3b7C8D98BmEgZDtlgDyUryTbF8PlmRB/n6ABKqP0M6cBBjZgBJ3UKu+G/E?=
 =?us-ascii?Q?mBjIliNWIPDMEE+kSH658prU7+d691yfRGgRO13Li6CwRfwWrsEziqxJrGMI?=
 =?us-ascii?Q?CfuEzWnmCL/tBZg9PVtJrOC5h1bDPptf8B7oFfsxgUNuKQeVQbCjnU1VxuX/?=
 =?us-ascii?Q?348UOAZKpVsBVuKw1pHcZr+O1/6SQKdnpv50n7VJnKOrisftQ7HCDq4BOi/d?=
 =?us-ascii?Q?Rifoiv+j8ZXST18zx9s/ADMYbA5kxNDKbpUlOfFMnTGulLHlUoPhjTDkKzYT?=
 =?us-ascii?Q?BcIGHlNewCFTzeFq9ytEU/QRyxHi5G5Fh2N0QiGNynVr4Jk79eEyRcG49QUw?=
 =?us-ascii?Q?bneQ+WYkq497B+6R284DHdoC9AfBf3VyXNwP0Mg7S2mzCxz7yAqlSEAzEGb/?=
 =?us-ascii?Q?Q5stzoXNzkOHqcL7rlJ9GMn8bRtxBaaMh2zjaClfemK/T36HNUVvoUBPe6vK?=
 =?us-ascii?Q?YISC6m0K45UUOUzGSlzQFaCqxhNiJKg4Y+ZRnz5pQiQRxnjfac7DNN6ST7Er?=
 =?us-ascii?Q?gCB85aFZTVs96QghYonjllMZlRWWOy3C2/f1G5jbpjCCqDb+WHoCp3MhSgly?=
 =?us-ascii?Q?yqWWxiwlDMfNScD1RkfPobOX3sclt7Zyd4LZ/4k9diOj6tICMfcL/xFzt5S6?=
 =?us-ascii?Q?aT5K254tlnamEn1wNXrKuBc0Na6d544dlTO+eCTXWaNTKrC3OdlGBtG+7crF?=
 =?us-ascii?Q?Jz3G8LyP5F19MXC25WgSmbozGwz84IBIJ4MjngPpwnuMRlmuwpeEtx4tL8T/?=
 =?us-ascii?Q?bf7Iktq4HwHXToFzSoju2ecPnepjWtNHI2hp/9WG0R1mRf3KLV0UHBlutWfE?=
 =?us-ascii?Q?fp52awYorhO3CpkeeiDk/pyFwQu5e/2pq689cPjo2jXfv0WWTo1kaZYkrqK/?=
 =?us-ascii?Q?ruLGjzZqb/SF5D0ttC++2Cn7bf5CSr3Mk2z4BA1qSVoNycDlmdVAq1ISuoRz?=
 =?us-ascii?Q?511SZQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: deed7669-d2b2-421d-9d6c-08db2605da4d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 10:04:38.3518
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WR4wEgsy6+KxhDA9n7K5CJOHuu8j75IMbkDmCyDe8eZLbsowzgy1eSBTIj57QgclScr7T5DgEWqGaiELPFqY9ighvGWkByIhkCdKmezSGks=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB4066
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 15, 2023 at 12:05:37PM +0100, Markus Schneider-Pargmann wrote:
> m_can offers the possibility to set an interrupt on reaching a watermark
> level in the receive FIFO. This can be used to implement coalescing.
> Unfortunately there is no hardware timeout available to trigger an
> interrupt if only a few messages were received within a given time. To
> solve this I am using a hrtimer to wake up the irq thread after x
> microseconds.
> 
> The timer is always started if receive coalescing is enabled and new
> received frames were available during an interrupt. The timer is stopped
> if during a interrupt handling no new data was available.
> 
> If the timer is started the new item interrupt is disabled and the
> watermark interrupt takes over. If the timer is not started again, the
> new item interrupt is enabled again, notifying the handler about every
> new item received.
> 
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>