Date:   Thu, 16 Mar 2023 11:05:59 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 08/16] can: m_can: Implement transmit coalescing
Message-ID: <ZBLqB1FOrQqZluoA@corigine.com>
References: <20230315110546.2518305-1-msp@baylibre.com>
 <20230315110546.2518305-9-msp@baylibre.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230315110546.2518305-9-msp@baylibre.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uzHTGaUtKpSQnnFdKtNAxM3XGQdY5VXzXZg06oP+vmmJWrmcUSm2YNBPam/Z?=
 =?us-ascii?Q?LY6bbrwfke/AGsXeIoHo+YZ/+o8PnsYzrMveRw3Seuir52B/IXxyyKemwPRc?=
 =?us-ascii?Q?Uqxi5OXdx+SML/0bHLfcjiPUYdk0Ptx23B7DZysn+HaVVUO8ebL7kcG6nkyx?=
 =?us-ascii?Q?a8kf1F14H8Xv5Zqimaw+sluPvixmaEFaOnc/4jCNMJTwrQiJGtFVUo/uX6fe?=
 =?us-ascii?Q?j0pyXt3C/jAM/LmVOe0ecJ9cR4VI9SS7qN10KqNOdRta/idxoESduagu98eC?=
 =?us-ascii?Q?ToRDiZ4zyM52ykVZs2j2xfcLKxdzYhp3XBM+haCeoGChLpT0tp9rLYG325uT?=
 =?us-ascii?Q?rWZLvENUvqGvp18D97Jiqz5da14QUzjgsBlQI7417s3bd/er7TeNnk65O7/T?=
 =?us-ascii?Q?A7Tg5NQaZKgMttAZ6bQzwhLOR4UOyEbjuwyecpIER+U9/q99hkhFxuwG4V/S?=
 =?us-ascii?Q?AHWECdJF+HrQ/uTCHqyDYNP1Rn+rOh9PbteBMFYSp1mBK5Y5KvPQe5fR14oX?=
 =?us-ascii?Q?do0IOU7bAxErqqe3mWDzgTESvil8hQHMCjFXKkagDelz6l/LdYmmfVyvvu2z?=
 =?us-ascii?Q?p0IWtq4q3bfG6upKL1VhnTetYBLPtwY2l1AC7+J8WlqBhD8uKWwuWaFmnZqE?=
 =?us-ascii?Q?HxZmLUDYj/NXjdWdL6xsKKZPFJoLfz32lSC5CmupmhSPZyBMdD1i5CEIytvf?=
 =?us-ascii?Q?LnhUe1YGh/BnQzjykjuCIBWASs0L19ZZuqaRVj6eYDfAMKmBGBXpSF9Juhrp?=
 =?us-ascii?Q?hWq1WazL4Cj6BYB4dExe5s63y5KIWLx1l57bE37zX7xUPLa4zUoafYZrbKE1?=
 =?us-ascii?Q?RCnGcvTb3Q5Hr8aLm1LYZQxUt4lH4vt0yEzWKJQn3A9BPNtpHA9yN82jbiyE?=
 =?us-ascii?Q?JZ69OASO4hmAwPBLqb+6ZHgyAwAlix59ja+OVwnv4cOnSjR+W4UBkf8cPunc?=
 =?us-ascii?Q?g2dRB1N74kUxdMlpac39U+5e9huYCUdIGbiHPXQy2BBS/o0yorYsYLuOhBrh?=
 =?us-ascii?Q?neVPjdvqogl/4VChBnKpw2iQnypAh3TFR86CXqoDY4qVOFHp3MYutjuhvomy?=
 =?us-ascii?Q?+WfuW13zuABA3jIQKYzGn8YTW8QurxcdVZcHnBYlipeLYr4OLV31VMnZunY4?=
 =?us-ascii?Q?Eyfyzjl5ZJhDnVtHXnizMLqVR0WsM2h+nAPyMKOKSdDtZL8ZxwtOwFF71kPC?=
 =?us-ascii?Q?UQ5dnOQnuYYJpEhDbimIrMyC+nq7zGeHPJwMYAQYDJdz1Mg6ae9IWMZ8J63/?=
 =?us-ascii?Q?85EfCySG/mkgJ/ERl+IQvJ79LhWLPIkKgZgXNpxaNQa2fA9cwRgf3eb077FV?=
 =?us-ascii?Q?2ut7TTO0b6gDzoTDNTWcBs8l4XDDTf5jhO1xck3lwlgIkpaR9EgqxVo9q7Pk?=
 =?us-ascii?Q?PElZvNfc15JEIiNgiFFzwJ1yQuf57jAO/JnyfHYKkvD6lKedySjT5bGrdSzj?=
 =?us-ascii?Q?GD3KayDbWpK0K4xzla96BL23OpIct94uzx/keY1ozxPebKRgTs15HL24q11p?=
 =?us-ascii?Q?9YY9SE8cJmF/26AoCsAzU+vn+dacUIHfKmuGGhfuz2n2UKnHnIYsCLXBqeeF?=
 =?us-ascii?Q?nMo+ZaFKcppz2mImwKoz/MnbN9II9Rx6elXB7oipQd9Lh/JVvVAUE2DB3FQd?=
 =?us-ascii?Q?8GMmPJxX3ega/xEVUFOwPPHyf1l8syXO7A7McdEJ7V97R+d9lBZfy/4eDGDp?=
 =?us-ascii?Q?vB7yPw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef9f92f6-94a6-43b2-9002-08db26060e04
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 10:06:05.1302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h6n9z+K/SBAMCtJ6umPQ6mEjoESQsI4SH8zmafp3bj0sF1i8mYGUcwJo6qzEAmudN1pHNmIR0+5Q6wzj0eLG2fdaDnkf0O7BYL0OYLYLyiA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB4066
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 15, 2023 at 12:05:38PM +0100, Markus Schneider-Pargmann wrote:
> Extend the coalescing implementation for transmits.
> 
> In normal mode the chip raises an interrupt for every finished transmit.
> This implementation switches to coalescing mode as soon as an interrupt
> handled a transmit. For coalescing the watermark level interrupt is used
> to interrupt exactly after x frames were sent. It switches back into
> normal mode once there was an interrupt with no finished transmit and
> the timer being inactive.
> 
> The timer is shared with receive coalescing. The time for receive and
> transmit coalescing timers have to be the same for that to work. The
> benefit is to have only a single running timer.
> 
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>