Date:   Thu, 16 Mar 2023 10:51:26 +0100
From:   Lukas Wunner <lukas@wunner.de>
To:     Francesco Dolcini <francesco@dolcini.it>
Cc:     Vignesh Raghavendra <vigneshr@ti.com>, Bin Liu <b-liu@ti.com>,
        linux-serial@vger.kernel.org, Zeng Chao <chao.zeng@siemens.com>,
        Rob Herring <robh@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        ilpo.jarvinen@linux.intel.com, tony@atomide.com,
        andriy.shevchenko@linux.intel.com,
        matthias.schiffer@ew.tq-group.com, linux-kernel@vger.kernel.org,
        Max Krummenacher <max.krummenacher@toradex.com>
Subject: Re: Wrong RS485 RTS polarity in 8250 OMAP UART Driver vs DT binding?
Message-ID: <20230316095126.GA4235@wunner.de>
References: <ZBItlBhzo+YETcJO@francesco-nb.int.toradex.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZBItlBhzo+YETcJO@francesco-nb.int.toradex.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Mar 15, 2023 at 09:41:56PM +0100, Francesco Dolcini wrote:
> We have working hardware, using another UART that expect
> rs485-rts-active-low, and the exact same HW, when using OMAP uart,
> requires rs485-rts-active-high (the HW is modular, so we are really just
> changing the uart, keeping the same RS485 transceiver / connections).
> 
> What's going on there? Is the semantic of the 8250_omap driver just the
> opposite as it should be?

Yes, sadly, for historic reasons.

See these threads:

https://lore.kernel.org/linux-serial/20220329085050.311408-1-matthias.schiffer@ew.tq-group.com/

https://lore.kernel.org/linux-serial/2de36eba3fbe11278d5002e4e501afe0ceaca039.1663863805.git.lukas@wunner.de/


> Am I doing something wrong in the device tree?

No, but regrettably you need a separate device tree depending on which SoC
you're using.

Thanks,

Lukas