Message-ID: <612dfdd2-7de1-12a7-c47c-7569c3466224@suse.com>
Date:   Thu, 16 Mar 2023 12:17:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 1/1] Guard pci_create_sysfs_dev_files with atomic value
Content-Language: en-US
To:     Alexander Stein <alexander.stein@ew.tq-group.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Oliver Neukum <oneukum@suse.com>
Cc:     Korneliusz Osmenda <korneliuszo@gmail.com>,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230316091540.494366-1-alexander.stein@ew.tq-group.com>
 <106b5618-908f-becc-6eb3-75ef136a48e4@suse.com> <6131694.LvFx2qVVIh@steina-w>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <6131694.LvFx2qVVIh@steina-w>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bG92cFYxbjhGQ3VscEszcnVWdVBjalNrSFpQOUQycEtaMkMrSW5XRjBEemFu?=
 =?utf-8?B?cEJmQk5FTlF6dllYRDFVemZ3aXJPK2crcXhMTGJZTFdDTVl3d2V1cGFRUGlP?=
 =?utf-8?B?d1BzT0VxbjNNNHNISE1CWWVzaExkUVBxQmNQV3E4NklkMk1rRitFUkJKTnZ1?=
 =?utf-8?B?STZXQ1F0bm0vK0NwTjVqTVlPWFB0L2lmTTI4Y2RUTnVVdDZqL1lBK2tOdTFT?=
 =?utf-8?B?U0YyMkYzVVJ5TEw1cTNkNzR2M0tjMmttTkdDMGxSaUhhQ0FOS2lrcVE2a3Nl?=
 =?utf-8?B?a21UalFoZC9MVlF4emx6czl5NmFPcmNzWGdvaUNMSW5EK0J1YS93dEVKckxu?=
 =?utf-8?B?cnowd3MydDVQaUZvTkREMnNBMmFWTVVUZXU4WGM4VHNwbWkycEFXZjVnbzVH?=
 =?utf-8?B?UjJ4OG5LU1h2QzJpMHlVUkEzc0FuMVVxeElkeTVvZlNuVGlVWnNVVkdKamRt?=
 =?utf-8?B?aU16TTZ3aWxwVVkxT1NObW1WY0JIM2p0NzdkNWYzb3BSK0JmMnFCc2JINHk1?=
 =?utf-8?B?WVUwL2J0SmQ4VklWU3VWcjdNRWNzZkRUOFpPYm1NYzBrTHd5blRnL21iNk5S?=
 =?utf-8?B?RCtrTSs1MTEzazZET1VJVE5ZbmNwdkhRR242UVhFOEhMK3RuQkI4bDU4RnVt?=
 =?utf-8?B?ZWgrdmM2NVUrNVpQWnpOTldLYmovWG1CMEFSRFVnbGlycStUQytPem8zek5D?=
 =?utf-8?B?eDE3RjhFQzJmMzNZYnFjeExWWWpJTTlqQkR5cXByU3hNOVAzMU5WSzVaR0tP?=
 =?utf-8?B?dy9uNUU4TlZtYVg1Vlc4STVLVGpnZDV3WmZ3cXJkZUZxRHJqSDNSeWZKeHpP?=
 =?utf-8?B?VmptV0F3WDY1Q1hPMjVJY1g5SE1lbExMNVFCbnRNMGxxU2twcjVOaFpRQjY5?=
 =?utf-8?B?SXlnRmdYUkw5ck9LQnlUVlQ3K0pXSXdCRkhCK3dGc3Jhbk5lclRxRUVCWWhZ?=
 =?utf-8?B?UVZWWFZ4cXVOZlhQWnhEVlJqdm9HWDVaTFNhMzgzL21ZcmhyajM3dG9LQk5o?=
 =?utf-8?B?RnlQNkl5QnZOL29KbnV3MlA1aUp4SWg2VnpPQVc0anBLNlhodzhpTXhHK0VC?=
 =?utf-8?B?RXJjR1RpNTBkQ3lPb25oWkNaUXU2bEZCcXpsUVBqc1BSZzl2ZTd4aTNzbUJI?=
 =?utf-8?B?VHZjUXkvNS84SnU5TXFnOHhLNm1ONVk1L080K3MxNFZHODZoalpxOEhFSjZP?=
 =?utf-8?B?K2NscktQaGZvc3g1OG1oUHZWMURObG5ENFFIZUVjbEFla2c5NFFOUE1vS1Ns?=
 =?utf-8?B?TXJ4aERWWjVldlE3cVlQNGdiVnAvdjliZkorYWVVd3JNcG1pcWlXVmQwUnlN?=
 =?utf-8?B?RFM5TGpXQnk3dGp0K2tIbkZ6R2NOd2lSenZYVGtjd0orN01KUkxYN2M5aVdt?=
 =?utf-8?B?WmtBcWszK2VqdkFCNktxU29MVk1Jck9weWNtQWxCTzZiemJKaXJQMlhVWkk2?=
 =?utf-8?B?Qk9IbW5mZnBoUkxocGRQdkZuR1FqRXlqSjQvQUUvTkJKTEFZb2VUTGt3cUZx?=
 =?utf-8?B?MWR3dHMvZnUwTHdZeDhYK2drODNjME1CZVJtM1RBbDk0MlU4ZWhLUXpKTmVK?=
 =?utf-8?B?WjZvT01wY1MwbEdHejdWdE1tSlROYnpBVnVMYnJoTGI2ME4rOVBBRzhISFVB?=
 =?utf-8?B?bnk4MG9RRnZyM0tFKzhNcGJ3eDZGUHVHNGxGY0w1c3Q5OFZobVJBWEZYTjdq?=
 =?utf-8?B?cGRJanBTVFRWanR2eWdEaitveFNEdm05TWJQN1lVYzh2OVFpVEMvL21JbXFJ?=
 =?utf-8?B?bCtPNGxDbGZ4Y0Y0N3ovQjVqRzJPWFlWWEllM2xkeXN6bFZCRXJWT1RzeVQx?=
 =?utf-8?B?NWROL0FKN3NVTjJEQkttY2djY25EZ21tcXN4bU5mVFJGRjFkWVZyTGh3NE5R?=
 =?utf-8?B?aktpTWFaaDU2N3hBSk4xOU1TVVc0aVFTdlE1VjRnSDBtaEpvcnFPdjlOZE9w?=
 =?utf-8?B?Mm1CL0JNVGo1b1Y5OUtLNW9QUC9BNnFoS04ySzJUSk9PeEVRZGd1emxQUWlE?=
 =?utf-8?B?dnloME10MkZVL2ZIdFJlVGxsTEFPQXdFYVVsNDN6c0NPeEdROFZobjlmUGV6?=
 =?utf-8?B?b2ROdEZmZ2pYTEJwVkdwUGtFbW56QU5DeER4dW5iU1pKM3I4bjBJWlQ3cWk0?=
 =?utf-8?B?V2wzS3BEeGJaWCtSQVMrV0xhL0JBM1lFSFRvdkZGTjMzQWVmTUdJWm1PVWk5?=
 =?utf-8?Q?vmsYVrjMMCRPk1zKiZDBP0fnTEOs3rbcB0evkgd77tEz?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2aa38ca8-4d21-4b5a-96b0-08db26100a9f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 11:17:34.4354
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +6HzenMw5iK1m3hqU1c9p8p9csqfvgN2AhPFS3c6fQhT8ksjKR0ynP0m+1Tkg8X3mW6GnBfRgTP0DdzRw71hIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9973
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 16.03.23 10:33, Alexander Stein wrote:
> Hi Oliver,

Hi,

> 
> Admittedly
> I would like to get rid of these two pathes for creating sysfs files in the
> first place, but I do not know the pci subsystem very well.
> IMHO for_each_pci_dev(pdev) in pci_sysfs_init is part of the problem as it
> unconditionally iterates over the bus, without any locks, thus creating sysfs
> files for each device added to the bus.
> Any ideas?

First of all, this existing code is a mess.

If I understand you have the issue that your driver adds a bridge
in dw_pcie_host_init() and the generic code in pci_create_sysfs_dev_files()
populates the directory before or while your driver does so and
the devices are effectively discovered twice.

It seems to me that you must not add a bridge before pci_create_sysfs_dev_files()
has finished. Now you could add a wait_queue and a flag and wait for it to
finish. But that is not very elegant. From which initcall is your driver
probed?

	Regards
		Oliver