Date:   Thu, 16 Mar 2023 16:55:21 +0500
From:   Khadija Kamran <kamrankhadijadj@gmail.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     Nathan Chancellor <nathan@kernel.org>,
        Alison Schofield <alison.schofield@intel.com>,
        outreachy@lists.linux.dev,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: initialize timeouts in probe only
Message-ID: <ZBMDqXMWpjNzsf4p@khadija-virtual-machine>
References: <ZA9mThZ7NyRrQAMX@khadija-virtual-machine>
 <279821116.9N5E1g01tA@suse>
 <ZBLsoTBeKbuYbhCi@khadija-virtual-machine>
 <1902746.IobQ9Gjlxr@suse>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1902746.IobQ9Gjlxr@suse>
Precedence: bulk

On Thu, Mar 16, 2023 at 12:39:31PM +0100, Fabio M. De Francesco wrote:
> Hi Khadija,
> 
> Sorry for being here so late.
> 
> I just saw also your other messages with further help requests.
> Please do other work while waiting for help on a specific issue. 
> 
> If I understand you correctly, you are saying that you can only build axis-
> fifo in-kernel because you cannot change the '*' to 'm'. Correct?
>

Yes, corect.

> If so, you have probably touched other configuration options in a way that 
> forces that driver to work only if compiled in-kernel). Therefore, I'd restart 
> from scratch.
> 
> Please delete your current .config and make a copy of the one from your 
> running kernel. Then check the three options Alison and I were talking about. 
>
> Remember that you cannot see the axis-fifo module entry (CONFIG_XIL_AXIS_FIFO) 
> in "Device Drivers" -> "Staging Drivers" section if you have not yet enabled  
> (either with 'm' or 'y') CONFIG_OF and CONFIG_HAS_IOMEM. 
> 
> Now you should end up with a visible CONFIG_XIL_AXIS_FIFO that can be enabled 
> as a module with 'm'. 
>

Hey Fabio!

I am on it. I have undertood the steps. I will let you know if this
works.

Also, with the help of Nathan's feedback I was able to reproduce the
warnings. I have changed the files to remove the warnings and it works. 

I will submit another [PATCH v5].

Thank you!
Regards,
Khadija Kamran

> Let me know if this procedure works.
> 
> Fabio
> 
>