Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82599C6FD19 for ; Thu, 16 Mar 2023 12:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229955AbjCPMt0 (ORCPT ); Thu, 16 Mar 2023 08:49:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbjCPMtY (ORCPT ); Thu, 16 Mar 2023 08:49:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 710FE36FEA; Thu, 16 Mar 2023 05:49:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E37D362000; Thu, 16 Mar 2023 12:49:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF12BC433EF; Thu, 16 Mar 2023 12:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678970962; bh=2hIIa27J4OufttFD58aRpuD3JQNUHcSmgwP80p7hQDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZdGIneuWnom/b6edum2ICmxf9259ZsE/zcc1wnP4XX4bt94xlSUpUokRxEBTgpnYZ dvlD06MCX34+PpBfnp7xcrc86g7kv3zVy09Gut1+RdEnEYmURFLNAdBU3QNFWN9zYi PaWIinxcjc6N6f2VVRl7oCs5TGb54Om9vhaHJ7rE= Date: Thu, 16 Mar 2023 13:49:19 +0100 From: Greg Kroah-Hartman To: Herve Codina Cc: Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v2 2/7] drivers: misc: Add support for the Lantiq PEF2256 framer Message-ID: References: <20230316122741.577663-1-herve.codina@bootlin.com> <20230316122741.577663-3-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230316122741.577663-3-herve.codina@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 16, 2023 at 01:27:36PM +0100, Herve Codina wrote: > +EXPORT_SYMBOL(pef2256_get_byphandle); You have a mixture of EXPORT_SYMBOL() and EXPORT_SYMBOL_GPL() in the same file here. As this one: > + > +void pef2256_put(struct pef2256 *pef2256) > +{ > + put_device(pef2256->dev); > +} > +EXPORT_SYMBOL(pef2256_put); Is just a wrapper around a EXPORT_SYMBOL_GPL() function, please revisit and perhaps make them all EXPORT_SYMBOL_GPL() calls? thanks, greg k-h