Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Joel Fernandes <joel@joelfernandes.org>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH 1/1] rcu/rcuscale: Stop kfree_scale_thread thread(s) after unloading rcuscale
Date:   Thu, 16 Mar 2023 09:28:31 -0400
Message-Id: <2B9F2C1A-B274-41EF-8ABE-1E660521BCE4@joelfernandes.org>
References: <IA1PR11MB61714FEEAF2C46639891401A89BC9@IA1PR11MB6171.namprd11.prod.outlook.com>
Cc:     paulmck@kernel.org, Frederic Weisbecker <frederic@kernel.org>,
        Josh Triplett <josh@joshtriplett.org>,
        Neeraj Upadhyay <quic_neeraju@quicinc.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>, rcu@vger.kernel.org,
        linux-kernel@vger.kernel.org
In-Reply-To: <IA1PR11MB61714FEEAF2C46639891401A89BC9@IA1PR11MB6171.namprd11.prod.outlook.com>
To:     "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
Precedence: bulk


> On Mar 16, 2023, at 9:17 AM, Zhuo, Qiuxu <qiuxu.zhuo@intel.com> wrote:
>=20
> =EF=BB=BF
>>=20
>> From: Paul E. McKenney <paulmck@kernel.org>
>> [...]
>>>>=20
>>>> How about to pull the rcu_scale_cleanup() function after
>> kfree_scale_cleanup().
>>>> This groups kfree_* functions and groups rcu_scale_* functions.
>>>> Then the code would look cleaner.
>>>> So, do you think the changes below are better?
>>>=20
>>> IMHO, I don't think doing such a code move is better. Just add a new
>>> header file and declare the function there. But see what Paul says
>>> first.
>>=20
>> This situation is likely to be an early hint that the kvfree_rcu() testin=
g should
>> be split out from kernel/rcu/rcuscale.c.
>=20
> Another is that it's a bit expensive to create a new header file just for=20=

> eliminating a function declaration. ;-)

What is so expensive about new files? It is a natural organization structure=
.

> So, if no objections, I'd like to send out the v2 patch with the updates b=
elow:
>=20
>   - Move rcu_scale_cleanup() after kfree_scale_cleanup() to eliminate the
>     declaration of kfree_scale_cleanup(). Though this makes the patch bigg=
er,=20
>     get the file rcuscale.c much cleaner.
>=20
>   - Remove the unnecessary step "modprobe torture" from the commit message=
.
>=20
>   - Add the description for why move rcu_scale_cleanup() after
>     kfree_scale_cleanup() to the commit message.

Honestly if you are moving so many lines around, you may as well split it ou=
t into a new module.

The kfree stuff being clubbed in the same file has also been a major annoyan=
ce.

 - Joel=20


> Thanks!
> -Qiuxu
>=20
>> [...]