Message-ID: <6aa169fe-4453-2eff-4c41-8e650d11c22f@amd.com>
Date:   Thu, 16 Mar 2023 10:28:30 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 1/2] drm/amd/display: make is_synaptics_cascaded_panamera
 static
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        alexander.deucher@amd.com
Cc:     Xinhui.Pan@amd.com, Abaci Robot <abaci@linux.alibaba.com>,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
        airlied@gmail.com, christian.koenig@amd.com
References: <20230316095143.73368-1-jiapeng.chong@linux.alibaba.com>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230316095143.73368-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkVoZUJnbzVBU1BOYXFCT0pydlFTdWUzdmtyS2ZBVjcyNnRIL0N6NjQyclZk?=
 =?utf-8?B?WXFJZHRzOXlrVmx0TmtoVDM0emh0eGRPdWpkeitmeVlJd28rOERKNTNIcGgw?=
 =?utf-8?B?cEtEcmhXSDkyR2Z1YzB5ZWtINHpDbEZ5TjdUSGExcm05NVFGOGUwbWFySzZZ?=
 =?utf-8?B?OGtkU2w3aFVDL3g2aDNicWNFcEtNbFgwd2xSYWtOREdYcHdQUGkyaE1FTXRG?=
 =?utf-8?B?bjkzZnpjekR5WFNRSk1LcUlaVHFBSXFtelgxMWZuZkkrcnBEUVdTL3ZqNjJH?=
 =?utf-8?B?MjQvOU5HQ0RVazJJVVBYUnBQdGROdE5UWVhtWmt0ZnNTRkRFZGJ0U3c3MkpV?=
 =?utf-8?B?NXZ0V3BUYUw0S1BrNFczM25QTDlFNHVXOVRUV25lejBpTXZtaFYrR25VZzhV?=
 =?utf-8?B?aTRaQjNtYWJyOUV3Nk1wTGFkdU9oNHdlVVQ1TCs4VnN5SmhDSHgwbzB4S0I1?=
 =?utf-8?B?ZVN3T1YxQTR1ZEE1T2gwMS9iNS9Ed1F5dnhwWEVyNHJka01MU3FVbUhVaUhP?=
 =?utf-8?B?OXRjK01IOWNBZkEzTmlxTFk2dWQ5anZtaDB0eVpyWnhRbWRPWmlaNmJtdFhv?=
 =?utf-8?B?TFJTYy9XSXVHWERUek50ektGM3lrcE5Sd3VSVkk2ekcrVytEQkF0UnIrN01z?=
 =?utf-8?B?MTltSEcvSUZYK0NFZU5PWUE2ZStuOGRwNzd4QlhOQnZ5cUpmMWtGWXR1VHFK?=
 =?utf-8?B?bXNBREsyV2VWTW4vZ0VXTGlrNTlWR0xlOE11SjZ2b2xmbU11TEtvUGlvd1Q4?=
 =?utf-8?B?bFdRR3BtaDl5OStwTlZOeWh0c3dRYXVjNmkyYkc0UDMyS3JqcDhVcFMzR2lH?=
 =?utf-8?B?TklaWjlIbFpxY3RpM3FwbENyYStqY3ZVOGdTYXk2eDFwclFaaTY2aWkxOTBX?=
 =?utf-8?B?RUxyeEc5eFZGbjk0ejQ1dTdidXlISW96YjliR1F6Sy9INkZyZmM4QmZHc29N?=
 =?utf-8?B?RVpnQ1Q3ME5NcGpiQ2tKUVU4MnZSN1BTK1ZPeEd5MXppNmFFRzlCQ29HQ0Zr?=
 =?utf-8?B?WGVxdERBZnZTemlubnhmWHBROGIrbysyRW1yUVRNdGFqVGxOdEdaNlBYeGNu?=
 =?utf-8?B?bFYxQUZyTFVvdlQ0RDlNL3g5ald2dWhOUUZidjZtNTJiTUJwenNNSVp1VXdR?=
 =?utf-8?B?c29LMm5NaXhBU0toS09yeGp2MnBGREVwTTBKemFDbVNwWnRqb3RFSkRBMjhQ?=
 =?utf-8?B?ZGxlVmZySTdDWkc2WWJzVGdiSVN3NjNsOWZrbHpYcFlVNFFkc3N3aWl1MUx5?=
 =?utf-8?B?VElFVXhLdGxSY3RYakoyZkZya3ozRnhoWlJnWnhNYVJlUkFYOVdUT1dSMTYx?=
 =?utf-8?B?WERsd2p0YVhMUmVSZGhJblExc3dEYm84QW9lNnZ6VjBxWDl2Sjc3SStMc1hr?=
 =?utf-8?B?bHN1QWZmQVMrbU1XSXpIbXJIZ3BLSnRhaFR3SG9DKzZLZ21JS21ZMG56bFFs?=
 =?utf-8?B?ZjBzV2xtVVhCSFhoM1k3Qm9aV3Rxemx2OEkxZE5IK2hZdlBBN3k2ZEtyQXpV?=
 =?utf-8?B?ekxEMkpFa0ZGdE5rUVBjeHJZeHl2RnVtTTlaRUNEcU1YUUVDek1LSmVCVlpv?=
 =?utf-8?B?b2g2clIxL211RUVyaDd5TE90NFM3eWVwQzFhb1BtTXkyWlBVTHRtTGN0cUpv?=
 =?utf-8?B?UURYVFVUa3cwbUVTSTZDVHhwYzZKR2dnY1hGMTdTV0VEMmcwZ2ZaNHhSK2o3?=
 =?utf-8?B?dGhsS3NEQVFuVFlGbGNLL1k5aERvbkpWd0N1QTVOQk9zYkFQMWwxajVDaWt5?=
 =?utf-8?B?SFlDeFNuWVJsSTBodkplclpGak9hMU1vR2kxakJNT2FNSTJ0a3NuTzRWMmNj?=
 =?utf-8?B?L3BMWTlFQ3FCMXFIeFlGRzJ2Y3ZPUVZmN1dTdFhVaU5TYjhPNGN1bDNvaVNx?=
 =?utf-8?B?dmd0bGJLbFJuL0JNMjhwVUlUcVh1V1kxNUFVZjllV1RkUGFnUTRkU1B2OXg1?=
 =?utf-8?B?THlwUytQVTFvSlRXZzVSaUlLYUY3ZU5NZFpOWlNZN0NMVnZNY1NnNXJ3VDZO?=
 =?utf-8?B?b085c2laZ3lPN3hBbzVNM0dHczlKbFNZajNpMWJVN2s5T1hsU3dhNGgxbmFq?=
 =?utf-8?B?M2JZYXRjNnNLVWp5QU0rU1psT3o2dnJYZTJ2Q0t4aE4wdlc0cmE4aVBwdkpx?=
 =?utf-8?Q?mBH24p2ljhwU0k/6PTTywu1Yj?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ff93055-b440-4e51-e4eb-08db262a9c22
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 14:27:45.6366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L2JtR0Q8PIJ2iPZQTdyKq+gxEgYPcoJdEjTZtTLIz53ZDWCa5nJdU+u4sET+UeULhNnL/uz+/sNVoP/gM2dZ2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8714
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/16/23 05:51, Jiapeng Chong wrote:
> This symbol is not used outside of amdgpu_dm_mst_types.c, so marks it
> static.
> 
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:211:6: warning: no previous prototype for ‘is_synaptics_cascaded_panamera’.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4548
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

I applied the series, thanks!

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 6378352346c8..994ba426ca66 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -208,7 +208,7 @@ bool needs_dsc_aux_workaround(struct dc_link *link)
>   	return false;
>   }
>   
> -bool is_synaptics_cascaded_panamera(struct dc_link *link, struct drm_dp_mst_port *port)
> +static bool is_synaptics_cascaded_panamera(struct dc_link *link, struct drm_dp_mst_port *port)
>   {
>   	u8 branch_vendor_data[4] = { 0 }; // Vendor data 0x50C ~ 0x50F
>   

-- 
Hamza