Date: Tue, 18 Sep 2007 11:46:40 +0530 (IST)
From: Satyam Sharma <satyam@infradead.org>
To: Borislav Petkov <bbpetkov@yahoo.de>
cc: Jeremy Fitzhardinge <jeremy@goop.org>, Muli Ben-Yehuda <muli@il.ibm.com>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] unify DMA_..BIT_MASK definitions: v1
In-Reply-To: <20070918060854.GA14903@gollum.tnic>
Message-ID: <alpine.LFD.0.999.0709181145060.14771@enigma.security.iitk.ac.in>
References: <20070918042919.GA8998@gollum.tnic> <20070918055803.GB4640@rhun.haifa.ibm.com>
 <46EF69B1.8020801@goop.org> <20070918060854.GA14903@gollum.tnic>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1004
Lines: 31

Hi Borislav,


On Tue, 18 Sep 2007, Borislav Petkov wrote:

> On Mon, Sep 17, 2007 at 11:01:21PM -0700, Jeremy Fitzhardinge wrote:
> > Muli Ben-Yehuda wrote:
> > >> +#define DMA_64BIT_MASK	DMA_BIT_MASK(64)
> > >>     
> > >
> > > This one does not do what you mean. You need an explicit mask or a
> > > ~0ULL here.
> > 
> > Yeah, I was just about to comment on it.  Its possible the compiler
> > might decide to shift by x%64 = 0.
> > 
> >     J
> ups, i knew that this might be a corner/boundary case. Thanks, updated patches
> follow...

Please fold all three patches into a single patch in the updated series,
otherwise git bisecters falling in between these patches will see the
"redefinition ... previous definition was here" warnings of gcc ...


Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/