Date:   Thu, 16 Mar 2023 16:30:06 +0100
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= <linux@weissschuh.net>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: turris-mox-rwtm: make kobj_type structure
 constant
Message-ID: <20230316163006.7f04b400@dellmb>
In-Reply-To: <20230227-kobj_type-firmware-turris-v1-1-e97f79827db1@weissschuh.net>
References: <20230227-kobj_type-firmware-turris-v1-1-e97f79827db1@weissschuh.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 27 Feb 2023 03:18:50 +0000
Thomas Wei=C3=9Fschuh <linux@weissschuh.net> wrote:

> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>=20
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>=20
> Signed-off-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
> ---
>  drivers/firmware/turris-mox-rwtm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris=
-mox-rwtm.c
> index 6ea5789a89e2..2de0fb139ce1 100644
> --- a/drivers/firmware/turris-mox-rwtm.c
> +++ b/drivers/firmware/turris-mox-rwtm.c
> @@ -104,7 +104,7 @@ static void mox_kobj_release(struct kobject *kobj)
>  	kfree(to_rwtm(kobj)->kobj);
>  }
> =20
> -static struct kobj_type mox_kobj_ktype =3D {
> +static const struct kobj_type mox_kobj_ktype =3D {
>  	.release	=3D mox_kobj_release,
>  	.sysfs_ops	=3D &kobj_sysfs_ops,
>  };
>=20
> ---
> base-commit: 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
> change-id: 20230227-kobj_type-firmware-turris-6cd4a66bac19
>=20
> Best regards,

Reviewed-by: Marek Beh=C3=BAn <kabel@kernel.org>