From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com,
        Arun Ramadoss <arun.ramadoss@microchip.com>,
        Russell King <linux@armlinux.org.uk>,
        Marek Vasut <marex@denx.de>,
        Oleksij Rempel <linux@rempel-privat.de>,
        linux-kernel@vger.kernel.org
Subject: [RFC/RFT PATCH net-next 0/4] KSZ DSA driver: xMII speed adjustment and partial reg_fields conversion
Date:   Thu, 16 Mar 2023 18:12:46 +0200
Message-Id: <20230316161250.3286055-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?coVAqSKaXw0K8aLmWxw7tZ1b4W2ynFNKVY4m/UvqWbdeFkkydDBLQbCaUzJU?=
 =?us-ascii?Q?XPRx826kAwFINsR4ukYCnMjJ0omALzOi143sNOZu/ZUyHmAs2k9kbljvlCdI?=
 =?us-ascii?Q?pqbLgehd80g30sQraDdDVnjBT2XcUgM240GnLrp+7LTUtxVvaQYe5SgCZIHe?=
 =?us-ascii?Q?3NJhfe5Q3ik+sG+K2bF05qqWKpsWCC7350SbmO2SNw7pxhoxqQtxdDVKf+Hi?=
 =?us-ascii?Q?otGPTiotefHDWjbRwpQehp9angJ2R543hGyjYWrBtvEoDUlIFfpIyMfSd6iO?=
 =?us-ascii?Q?7oxL6lQQueEHnwbS4L2xrVA5X51ElKF0oTfv/fukQJ7a6Jr91lsXxN//9UiK?=
 =?us-ascii?Q?5xiR4OU7aYYfmzQD+5N7V/WIdZVRHn5uYPfol8QEsfvsuo74warMeN4oOrHm?=
 =?us-ascii?Q?eqv3J4gdCRYOGA5MI99OqggO4tBzVdKz8aGfftLZxLW2u3bKiVTKLrIGT9WJ?=
 =?us-ascii?Q?XoKxbxUu9uLU3LMyy/xGg8VbmnRPm+/i/WHgmunmUHacmtFCdFyzyW4OpZYL?=
 =?us-ascii?Q?PuIB5GfqpOP3naSa7eAmzbp+HLONPukaZEF8gLQihB7Ibe8Pg+6eOUAZR0Jq?=
 =?us-ascii?Q?TtPNN1vNZG+ZkPBt5m+3RtHTKYqhuYiuk6WMnkdO9Ij/YaXbKR+cOhRxfQR1?=
 =?us-ascii?Q?ppDEDWdjtnoCUqc2oacpX4MstEL0DKYSGh0CYlVkpGVsbjVA/2xYqlusx5m1?=
 =?us-ascii?Q?ed9HuVjxMKbzQjiGhBJVJ1DWNumj/eUmLU4McaDWk7Tf8cJJxczxTTaPe67q?=
 =?us-ascii?Q?FftqEG4fUc+U+su3DhqUGg/Co7Xp1QomxLxCV7Gf2jCsb6Qqf7+GqSsanJUA?=
 =?us-ascii?Q?dvc5G8CVXQBUrFIGpAL1s7ej/5nwSUk1a3Ztm2Ff+2R6lZ+keCJ334OhlKvU?=
 =?us-ascii?Q?QoT8qkVumU1uuMQ21fT7bzpgrcjjTVys3wi2jO8aRRM2W3Pr+zRHgXAUegiI?=
 =?us-ascii?Q?7REUlHKZSVfFjjrUJyhf15m4jmz9CZoKXDUKL4iXbcZ6ywxzPTWU1Dles+M0?=
 =?us-ascii?Q?SPNJI2fCbzhLDTQpao+U+m8vE0sWv7uyi0w69uz//qOFhzNdQKlW/8hl+sB4?=
 =?us-ascii?Q?/MZKCAvEcwQGl+povFvIH+pxbH1FD349Sf9ZS4Z5F3GXVQtiLDZ7wppl44hs?=
 =?us-ascii?Q?GqrZ5dYywnwEnoB2gqUt0gZwVZb/Xsd1hl1GEgmkCkURibt1Y4jZYgw8uEc/?=
 =?us-ascii?Q?2tcdPlwzyFruomPXzKRFuOUliZENI5NLWiJ7kIFV94W5AFtocgW7tTFPdkfw?=
 =?us-ascii?Q?w/8wFhlFCNb11btJ2mXK/BqQSU/rLJnDJbue4hh1A8E98VHj+oQtvIRoy7I+?=
 =?us-ascii?Q?1gX1NCq/zHBaJWIR41ZgaMiDks0Il+2lixH5quFq+PLT/0XMcDEzxF5K3v6q?=
 =?us-ascii?Q?DRe3Ka3bP7r4SndbnZWRhu/+Kffg3Vw9i1hx7SY9xrbR5zZn7mNaOPPbAptf?=
 =?us-ascii?Q?lseRhhwqcvnK5k85H0WbwshL0Zs/qVGrfZPwkjAq5f9xdciKWtec8LtmyFyw?=
 =?us-ascii?Q?xeONUTbRysxwpoCZgotMW+0lF3ThUnRpMPi3ZUbQyNpCn/9Vd8/Z8AbfjqvG?=
 =?us-ascii?Q?X89/vJghJ//f7GhTx/nE1BgtSCOdPYUggYoutcTN0YZhv44M6W+ekleREQqP?=
 =?us-ascii?Q?ow=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 374f949a-2d9d-4d55-ac12-08db263954c6
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 16:13:08.2698
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BLmLZ+xySVI0ecUkm4EIHl8l2DsBkiKCF6VA6rKunSztz464YGtENmXf9fVrNl3GBAwoIYmG4gt+uIYTHg/79g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7861
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

Yesterday I picked up this patch and resubmitted it:
https://patchwork.kernel.org/project/netdevbpf/patch/20230222031738.189025-1-marex@denx.de/
here:
https://patchwork.kernel.org/project/netdevbpf/patch/20230315231916.2998480-1-vladimir.oltean@nxp.com/

and today I'm trying to address the rest of the points brought up in
that conversation, namely:

- commit c476bede4b0f ("net: dsa: microchip: ksz8795: use common xmii
  function") stopped adjusting the xMII port speed on KSZ8795, does it
  still work? No idea. Patch 3/4 deals with that.

- Mapping P_XMII_CTRL_0 and P_XMII_CTRL_1 to the same value on KSZ8795
  raised some eyebrows, and some reading shows that it is also partially
  incorrect (see patch 2/4). This is also where I propose to convert to
  reg_fields.

As it turns out, patch 2/4 is a dependency for patch 3/4, even if 3/4
may be a fix.

Patch 1/4 is a dependency of 2/4.

Patch 4/4 is something I also noticed during review. I left it at the
end so that it won't conflict with something that could reasonably be
submitted as a bug fix.

ABSOLUTELY NO TESTING WAS DONE. I don't have the hardware.

THIS BREAKS EVERYTHING EXCEPT FOR KSZ8795. Any testers should test on
that if possible (due to both patches 2/4, and 3/4).

Vladimir Oltean (4):
  net: dsa: microchip: add an enum for regmap widths
  net: dsa: microchip: partial conversion to regfields API for KSZ8795
    (WIP)
  net: dsa: microchip: allow setting xMII port speed/duplex on
    KSZ8765/KSZ8794/KSZ8795
  net: dsa: microchip: remove unused dev->dev_ops->phylink_mac_config()

 drivers/net/dsa/microchip/ksz8795.c      |  45 ++--
 drivers/net/dsa/microchip/ksz8863_smi.c  |  11 +-
 drivers/net/dsa/microchip/ksz9477.c      |  24 +--
 drivers/net/dsa/microchip/ksz9477_i2c.c  |  11 +-
 drivers/net/dsa/microchip/ksz_common.c   | 256 +++++++++++++----------
 drivers/net/dsa/microchip/ksz_common.h   | 110 +++++++---
 drivers/net/dsa/microchip/ksz_spi.c      |   6 +-
 drivers/net/dsa/microchip/lan937x_main.c |   8 +-
 8 files changed, 299 insertions(+), 172 deletions(-)

-- 
2.34.1