Date:   Thu, 16 Mar 2023 17:19:35 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Valery Zabrovsky <valthebrewer@yandex.ru>
Cc:     Guo Zhengkui <guozhengkui@vivo.com>,
        Aaro Koskinen <aaro.koskinen@iki.fi>,
        Alan Stern <stern@rowland.harvard.edu>,
        Mian Yousaf Kaukab <yousaf.kaukab@intel.com>,
        Felipe Balbi <balbi@ti.com>,
        Alexey Khoroshilov <khoroshilov@ispras.ru>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org
Subject: Re: [PATCH] usb: gadget: net2280: fix NULL pointer dereference
Message-ID: <ZBNBlwc9lt+pLFkd@kroah.com>
References: <20230316155356.13391-1-valthebrewer@yandex.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230316155356.13391-1-valthebrewer@yandex.ru>
Precedence: bulk

On Thu, Mar 16, 2023 at 06:53:55PM +0300, Valery Zabrovsky wrote:
> In net2280_free_request():
> If _ep is NULL, then ep is NULL and is dereferenced
> while trying to produce an error message.

How can that ever happen?  How did you test and hit this?

> The patch replaces dev_err() with pr_err() which works fine.

That's not a good idea for driver code to use, sorry.

> Found by Linux Verification Center (linuxtesting.org) with SVACE.

As I have said before, your testing framework needs a lot more work.

good luck!

greg k-h