Message-ID: <56836a10-570e-a6da-0456-20dd58fa4b28@microchip.com>
Date:   Thu, 16 Mar 2023 17:20:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH net-next] net: macb: Reset TX when TX halt times out
Content-Language: en-US
To:     Harini Katakam <harini.katakam@amd.com>
CC:     <davem@davemloft.net>, <claudiu.beznea@microchip.com>,
        Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
        <kuba@kernel.org>, <edumazet@google.com>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <michal.simek@amd.com>, <harinikatakamlinux@gmail.com>
References: <20230316083554.2432-1-harini.katakam@amd.com>
 <ZBL1X1U3BJEAEIrX@localhost.localdomain>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
In-Reply-To: <ZBL1X1U3BJEAEIrX@localhost.localdomain>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 16/03/2023 at 11:54, Michal Swiatkowski wrote:
> On Thu, Mar 16, 2023 at 02:05:54PM +0530, Harini Katakam wrote:
>> From: Harini Katakam <harini.katakam@xilinx.com>
>>
>> Reset TX when halt times out i.e. disable TX, clean up TX BDs,
>> interrupts (already done) and enable TX.
>> This addresses the issue observed when iperf is run at 10Mps Half
>> duplex where, after multiple collisions and retries, TX halts.
>>
>> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
>> ---
>>   drivers/net/ethernet/cadence/macb_main.c | 10 ++++++++--
>>   1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
>> index 96fd2aa9ee90..473c2d0174ad 100644
>> --- a/drivers/net/ethernet/cadence/macb_main.c
>> +++ b/drivers/net/ethernet/cadence/macb_main.c
>> @@ -1021,6 +1021,7 @@ static void macb_tx_error_task(struct work_struct *work)
>>        struct sk_buff          *skb;
>>        unsigned int            tail;
>>        unsigned long           flags;
>> +     bool                    halt_timeout = false;
> RCT

Yes, might not pass the netdev checks.

> Otherwise looks fine
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>

Likewise, this fixed:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Best regards,
   Nicolas

> 
> [...]
> 
>> --
>> 2.17.1
>>

-- 
Nicolas Ferre