Message-ID: <ae8e8b61-b00a-1ec1-8212-7194c5ae4b30@microchip.com>
Date:   Thu, 16 Mar 2023 17:22:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH net-next] net: macb: Increase halt timeout to accommodate
 10Mbps link
Content-Language: en-US
To:     Harini Katakam <harini.katakam@amd.com>, <davem@davemloft.net>,
        <claudiu.beznea@microchip.com>, <kuba@kernel.org>,
        <edumazet@google.com>, <pabeni@redhat.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <michal.simek@amd.com>, <harinikatakamlinux@gmail.com>
References: <20230316083050.2108-1-harini.katakam@amd.com>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
In-Reply-To: <20230316083050.2108-1-harini.katakam@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 16/03/2023 at 09:30, Harini Katakam wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Harini Katakam <harini.katakam@xilinx.com>
> 
> Increase halt timeout to accommodate for 16K SRAM at 10Mbps rounded.
> 
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>

Fine with me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Best regards,
   Nicolas

> ---
>   drivers/net/ethernet/cadence/macb_main.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 51c9fd6f68a4..96fd2aa9ee90 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -94,8 +94,7 @@ struct sifive_fu540_macb_mgmt {
>   /* Graceful stop timeouts in us. We should allow up to
>    * 1 frame time (10 Mbits/s, full-duplex, ignoring collisions)
>    */
> -#define MACB_HALT_TIMEOUT      1230
> -
> +#define MACB_HALT_TIMEOUT      14000
>   #define MACB_PM_TIMEOUT  100 /* ms */
> 
>   #define MACB_MDIO_TIMEOUT      1000000 /* in usecs */
> --
> 2.17.1
> 

-- 
Nicolas Ferre