Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AF62C6FD19 for ; Thu, 16 Mar 2023 16:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229987AbjCPQr2 (ORCPT ); Thu, 16 Mar 2023 12:47:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230377AbjCPQrZ (ORCPT ); Thu, 16 Mar 2023 12:47:25 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 27F182B9ED for ; Thu, 16 Mar 2023 09:47:23 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A81542F4; Thu, 16 Mar 2023 09:48:06 -0700 (PDT) Received: from [10.57.54.186] (unknown [10.57.54.186]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ACF213F885; Thu, 16 Mar 2023 09:47:21 -0700 (PDT) Message-ID: Date: Thu, 16 Mar 2023 16:47:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 1/9] coresight: Use enum type for cs_mode wherever possible To: James Clark , coresight@lists.linaro.org Cc: Mathieu Poirier , Mike Leach , Leo Yan , Alexander Shishkin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230310160610.742382-1-james.clark@arm.com> <20230310160610.742382-2-james.clark@arm.com> From: Suzuki K Poulose In-Reply-To: <20230310160610.742382-2-james.clark@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/03/2023 16:06, James Clark wrote: > mode is stored as a local_t, but it is also passed around a lot as a > plain u32, so use the correct type wherever local_t isn't currently > used. This helps a little bit with readability. > > Signed-off-by: James Clark > --- > drivers/hwtracing/coresight/coresight-core.c | 7 ++++--- > drivers/hwtracing/coresight/coresight-etb10.c | 3 ++- > drivers/hwtracing/coresight/coresight-etm3x-core.c | 6 +++--- > drivers/hwtracing/coresight/coresight-etm4x-core.c | 6 +++--- > drivers/hwtracing/coresight/coresight-priv.h | 9 ++------- > drivers/hwtracing/coresight/coresight-stm.c | 6 +++--- > drivers/hwtracing/coresight/coresight-tmc-etf.c | 2 +- > drivers/hwtracing/coresight/coresight-tmc-etr.c | 7 +++---- > drivers/hwtracing/coresight/coresight-tpdm.c | 4 ++-- > drivers/hwtracing/coresight/coresight-tpiu.c | 3 ++- > drivers/hwtracing/coresight/coresight-trbe.c | 3 ++- > drivers/hwtracing/coresight/ultrasoc-smb.c | 3 ++- > drivers/hwtracing/coresight/ultrasoc-smb.h | 2 +- > include/linux/coresight.h | 13 ++++++++++--- > 14 files changed, 40 insertions(+), 34 deletions(-) > Looks good to me. Suzuki