Message-ID: <e70030cb-e0b5-41ba-4913-361a2038e58a@intel.com>
Date:   Thu, 16 Mar 2023 10:40:26 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v3 6/8] platform/x86/intel/ifs: Implement Array BIST test
Content-Language: en-US
To:     Hans de Goede <hdegoede@redhat.com>, <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <rostedt@goodmis.org>,
        <ashok.raj@intel.com>, <tony.luck@intel.com>,
        <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>, <sohil.mehta@intel.com>
References: <20230214234426.344960-1-jithu.joseph@intel.com>
 <20230301015942.462799-1-jithu.joseph@intel.com>
 <20230301015942.462799-7-jithu.joseph@intel.com>
 <628e092c-793e-96ce-71f5-80392ad69569@redhat.com>
 <9dde72aa-a28d-2b0e-7b90-6b1996dbf202@intel.com>
 <f45c26ae-865b-b7b6-0f2a-5906d9c0a349@redhat.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <f45c26ae-865b-b7b6-0f2a-5906d9c0a349@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3EzQUJOamtmcUlsRmFQVjhZME1mU1ZTMmJhbUxtcUxkNzBSVE8rdWlmRzg1?=
 =?utf-8?B?Y3VZcFl6eDlxUXdBQ2FCb3llSnlZTU1tcGNnQWRDSWJtbTk0WEtCY2VqVkRi?=
 =?utf-8?B?Unc3RnhCbzY3Mi84T2YzeHFZZ0FqN1Znc0VyMk1DdG1LOGF3aTU1NW8wWWhs?=
 =?utf-8?B?b2VHd0s3VGlSOFVmMjFscUJRUnpjekJ0NjJWT1d6MlZnVWtmdmVpL0dyNXIw?=
 =?utf-8?B?SnBkZEdKaGRJdW51ZEZ6NU1KR0tSTXdSU1ErSzJzcGh2b2lZR3oyT2lEbnhH?=
 =?utf-8?B?ZVhlVE82dXhzVEViQ3NBZEVmWENTU3NlZlZKWlhMV0tkRDNmRDBJSUoxMS9J?=
 =?utf-8?B?YU93VVdqU1pwMEFHdHRRMVdCRXJrbE1PM05pckZWSVEraDRwRWJUTVJUSTZq?=
 =?utf-8?B?OWVqWjBOUXF5NkVRc21xWURhWlYzYm1qM1VoWWxkUlNxdDc0bFVkaFpneGhX?=
 =?utf-8?B?RXdSWDNNN1M4Wnp6VGV6emJYU29wcUFGbThrZXdqSERlekQ5cWlxOThVelF1?=
 =?utf-8?B?eGZRd0IvTGxTZjI5M2NUMzJCdlhnSFluOWJTZlE1cWp4OEprOXh5cTl1bWVi?=
 =?utf-8?B?VFc2aExhN0cxazk3bFlGVzlHOEZoL0o3OHJCUFRoZUd6Z1puaEhTUzk5djJS?=
 =?utf-8?B?WWxkKzRHNXNQNzgzK2lrMWdpcnltVWN1cEhvTlQrcWY3TzJPRWlydVRVWXp6?=
 =?utf-8?B?dkdBNWxDSmE1a2VhZGZPSnRlSzFxeXhMSWVjalJFL3REbm5NSGRiakxhOXRv?=
 =?utf-8?B?YndBbWVWYW9nZUM0UzVxVFpaSGU0MDlIZzlYVnhjK0JCRzh0Z2xtdjVQUjZr?=
 =?utf-8?B?dmRIMWRsQlR6VmU5Z1hrRkJEUzluM1VCZHBKSzByS3JScDUwRVZycVY4cW1i?=
 =?utf-8?B?Ulo4c0FJM2FSZStQcTd0WVhzM3BSVDdpNU1oS1JuTG9vaEMxWUNPQnpGWWNB?=
 =?utf-8?B?cTR1RHdiMkNFY0xaaEpZL1dzYkQ1a0tGWG5xVW92QXd2MEU3RDNHc2FQOU8v?=
 =?utf-8?B?c3FEUGRqWlJXK0FiVC9YM2w3VGRDb0lXQnEyN015WE4wSU9zWnNrTytuOS9T?=
 =?utf-8?B?akh2Wm9DSVV1eTlmWHV4NVhFOURTemNrWDZxQjZYeXlKTHhkeTd5ckRUUGJa?=
 =?utf-8?B?M0ZwOVJUcFZ6TUpDVlRIdDFZVUtzRVRCR2tBZUFwYytDVElMRzdqeHB5bGw3?=
 =?utf-8?B?RzlJNnRQK0lpb1BDMWp2MUZXNS96ZTFpdEMrMlNhMFFjbEtOV1F2TzlwREtp?=
 =?utf-8?B?dWhWQU9yMFlMN3AySm9SMG85eklYRm1pMmQra2llUTV3TzRCZzA0YStsS3A1?=
 =?utf-8?B?bTlMcHhRUGhDVEpaS203WVA4SUxncHZoNHpoY3NObjJMZ1NrQUlGSUpsVWpz?=
 =?utf-8?B?dUNBUVR1RzQ1TWJNZytLRk9ZL2RnWVZiakE1UUhNODdPRFRQQ2JweEVhdTFt?=
 =?utf-8?B?c1lzZVQyME1SS0VFUlhGalk3QktmMU5VQmdjZzJzcHFLUVFLQWF3VTdoTTh6?=
 =?utf-8?B?cHZBU2cramQzaFNSZFRRdDlXNzdDMFlVYWdaV2NuMUdjSVBIQWZ2SVZHSVpp?=
 =?utf-8?B?QzNhcm9JUjM1blBPbWRDclJzaGdDbHBqdGN5aVV2ZGxqWGpsRzVVamVMTTc0?=
 =?utf-8?B?QXAzZW95d0t3MkdsQlBtQUFuZlNGV0UyMDNPU2VRNlhkWVVOdlUzTWtqSE5R?=
 =?utf-8?B?L2tKZVNEZjBUUFR1WUZDZjVGTUsxbiszRFp5bFI5UG93Sm14a01PNDFaNWdV?=
 =?utf-8?B?L0pnNnBmZ3luY01MYld3RVFQQnovQUNmelJ4T21TR0N5cS9ubVgzTVZYeUl4?=
 =?utf-8?B?MVRZSHB3bWV6bGdvTi9uR0w3T082bjlmR3QvdXFJcmxKTG41RGl0QmIyMjBS?=
 =?utf-8?B?QllxY253QmhRUUhPU1JUN3hCSkpvQTh3VGR4S2l1WHl1RDZmRGlwdWJTZlY3?=
 =?utf-8?B?VGl5Z0d2UW5hMFFvbFVSSTFQL0NRL25qVlpkUnNZRFAzRWNMR3MyYmpsWXV1?=
 =?utf-8?B?UVY5WER5WTVjYW9DSjF4Z1FTb2NoVWZKZk53SGRXNWkzcjBPUllGcE5udklk?=
 =?utf-8?B?bHhJZ0ZYOThYN0FaQlNZbzNHRUwzL1YwYUNldmJqOXNkZUpMeTkvUk5RenJQ?=
 =?utf-8?B?UUVtL094RlMweFpXWjhid1VtbU84dXhleU5aL0VmQjVYTmdoVFNnYWhoRHEv?=
 =?utf-8?B?eXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eba71a7a-039e-4930-831f-08db2645886d
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 17:40:29.0127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jWZmJBnH1VXuxnYoY6dHzLwEWB3T6MPZakK2Y31piX0lg1WM0QLa570AvSWHOcailkfHF4bEqc7Jog8FYqBkkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7551
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/16/2023 2:59 AM, Hans de Goede wrote:

>>
>> Only one IFS test is allowed at a time. This is done using "ifs_sem" defined in sysfs.c
> 
> Ah I see.
> 
> After taking a closer look I do see one unrelated issue with this patch
> sysfs.c: run_test_store() does:
> 
>         if (!ifsd->loaded)
>                 rc = -EPERM;
>         else
>                 rc = do_core_test(cpu, dev);
> 
> But AFAICT the loaded check really only applies to the first (intel_ifs_0 device) test type and the 
> Array BIST test should work fine when loaded is false.

This is true, the load check only applies to first test. And the patch (5/8) in this series adds the
check you are suggesting to allow the second test to proceed (as given below)

	if (ifsd->ro_info->test_num != IFS_TYPE_ARRAY_BIST && !ifsd->loaded)
		rc = -EPERM;
	else
		rc = do_core_test(cpu, dev);

It is possible that the snippet you pasted above was from an earlier state.


Jithu