MIME-Version: 1.0
References: <20230316174818.1593588-1-zyytlz.wz@163.com> <a1ad3c9e-ee3d-7d30-fe8e-bca2eed77872@linuxfoundation.org>
In-Reply-To: <a1ad3c9e-ee3d-7d30-fe8e-bca2eed77872@linuxfoundation.org>
From:   Zheng Hacker <hackerzheng666@gmail.com>
Date:   Fri, 17 Mar 2023 02:03:15 +0800
Message-ID: <CAJedcCye9HsDBrao=VEsN=qxkV3HCmGPTix3g8BL+K6oCCaE=w@mail.gmail.com>
Subject: Re: [PATCH RESEND] usbip: vudc: Fix use after free bug in vudc_remove
 due to race condition
To:     Shuah Khan <skhan@linuxfoundation.org>
Cc:     Zheng Wang <zyytlz.wz@163.com>, valentina.manea.m@gmail.com,
        shuah@kernel.org, gregkh@linuxfoundation.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        1395428693sheep@gmail.com, alex000young@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Shuah Khan <skhan@linuxfoundation.org> =E4=BA=8E2023=E5=B9=B43=E6=9C=8817=
=E6=97=A5=E5=91=A8=E4=BA=94 01:59=E5=86=99=E9=81=93=EF=BC=9A
>
> On 3/16/23 11:48, Zheng Wang wrote:
> > In vudc_probe, it calls init_vudc_hw, which bound &udc->timer with v_ti=
mer.
> >
> > When it calls usbip_sockfd_store, it will call v_start_timer to start t=
he
> > timer work.
> >
> > When we call vudc_remove to remove the driver, theremay be a sequence a=
s
> > follows:
> >
> > Fix it by shutdown the timer work before cleanup in vudc_remove.
> >
>
> Send me v2 for this patch with adding details on how you found this probl=
em
> to this commit log.
>

Get it, I found it by static analysis. So this might be false postive.
Will add this
to next version of patch

Best regards,
Zheng

> > Note that removing a driver is a root-only operation, and should never
> > happen.
> >
> > CPU0                  CPU1
> >
> >                       |v_timer
> > vudc_remove          |
> > kfree(udc);          |
> > //free shost         |
> >                       |udc->gadget
> >                       |//use
> >
> > Fixes: b6a0ca111867 ("usbip: vudc: Add UDC specific ops")
> > Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> > ---
> >   drivers/usb/usbip/vudc_dev.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.=
c
> > index 2bc428f2e261..33d0991755bb 100644
> > --- a/drivers/usb/usbip/vudc_dev.c
> > +++ b/drivers/usb/usbip/vudc_dev.c
> > @@ -633,6 +633,7 @@ int vudc_remove(struct platform_device *pdev)
> >   {
> >       struct vudc *udc =3D platform_get_drvdata(pdev);
> >
> > +     timer_shutdown_sync(&udc->timer);
> >       usb_del_gadget_udc(&udc->gadget);
> >       cleanup_vudc_hw(udc);
> >       kfree(udc);
>
> thanks,
> -- Shuah