Date:   Thu, 16 Mar 2023 11:15:47 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>,
        David Hildenbrand <david@redhat.com>, linux-mm@kvack.org,
        linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] mm, treewide: Redefine MAX_ORDER sanely
Message-ID: <20230316181547.GA6211@monkey>
References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com>
 <20230315113133.11326-11-kirill.shutemov@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230315113133.11326-11-kirill.shutemov@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EPDgoc/H9Skm4brhIXY3WQPnZ74NPy+YLG08eM/JADlOAB1AOaZDNeBFmMIi?=
 =?us-ascii?Q?6FbBWXH71pY8Rw2OgoQ/2GKZ0eE3CXjs+s2p37sUzScw1AFbDXzXXSGcj74I?=
 =?us-ascii?Q?Q+FoCNQAcdoeHoRfBGbigIJECbxlggSukgUXGTAkW/ANzpm32FTGcs+mIDws?=
 =?us-ascii?Q?4IfGVN11z1cOuc+mdNRm5A0uH4hyQ6aPAMYm2qgWqgHWWx3xEQeqhBYI8I37?=
 =?us-ascii?Q?iXXDC5KOr9GmeRCUJ7kqrHxkU7JJCv6tTDe6QYR4mAG/Ag5ApS57gae323Ad?=
 =?us-ascii?Q?p45KsAMaBZYZ4jPp1jSF0ie15wZdMFV7BXTeTeaUKPzhlKgQVxDiu0/UzT3N?=
 =?us-ascii?Q?iaTx4kMUKrvzhi2mUC5uu40MQHxvSOEhEMS+PKfAhpErfsurT0OJz6V5tiDU?=
 =?us-ascii?Q?Z7mp9Dbv5cBO3E2OAOaMeRDNJ4sCVlGj4EffQAakak0dqRTAr/rxti4Jjdk+?=
 =?us-ascii?Q?IFKAGET4VCww+d3fvJLE1t1c2es449lQLyUeI1bVQO/XS7ftIBCsogMrYX2n?=
 =?us-ascii?Q?3hZWdx3T4QXMGWFObkrvpzkdPETrPRZDOq0oU4CtZMA5Vvr6JkdlcyXJ2MTj?=
 =?us-ascii?Q?5rekmG0jWpXHzVRGTAAcuHYBFahJ4DFJvtrszgMiWRfF5uFswJUMUh/wCc++?=
 =?us-ascii?Q?mZEWqiH/X+i51AHSzn+h7fnrj5tTUlhwXJSSmcFWN7GHgD7rkvFdaMKk7eRH?=
 =?us-ascii?Q?KGS3HA+AN8sEAmzCQU0hxgfEnDBImzBEyCmW8E7PzotODAuAZnKI8OY49oWq?=
 =?us-ascii?Q?4m20bm3jex4xs1YjgpmqEqf+yj6ZhMKaMq4CfWEmQqsXwjqkRi56XhrQHR1c?=
 =?us-ascii?Q?qmZs+yH4LxFlHA1xoyU6aaIGhteHq8uBpfpayhapBAD1gJkGuW/koNaS3JLh?=
 =?us-ascii?Q?5cSvEycAy7ZHKzJcbJ1xvXAzXXlNSPyphjv2Gm9x5EcgXPRgwuDHTsuabN/M?=
 =?us-ascii?Q?xPviwmePgrvd+/uhlLwlLwu7CZumA7jzgaM985wpl3ANWtCsAPmn6T3Y96GK?=
 =?us-ascii?Q?JrwYoCbQnaUX+r7PokfvDqa2ZFHSqZwSDOailizdKNUWumSwgvbtbbe13H3g?=
 =?us-ascii?Q?pXa6LkAdZt9Vw+4Re4MVs6+6sv1HuyIYcFHT2pEmpUMDl0+9xy8jWMj4tD9B?=
 =?us-ascii?Q?XpmlmajN8JPQbaqpI3XGf4dSYZY9l2tjY/EHZHcASLuNLTLjjYHG4OKB9E9p?=
 =?us-ascii?Q?NwMj+89639/lQHGH448rxBh2cTLmLFcVjLRjZW+w+tz7qYvXQGSVxPlojymu?=
 =?us-ascii?Q?AbRBcLBd51jUYWJtmXmEfMOHhxOfpD958EiwbWZD8mZlwJQoCSDfVIKiWwmB?=
 =?us-ascii?Q?RVPH5W2/pqTpJir7GgMT4kV9d5ErD3aT6RlLyFgYTXgN3rFXMMUibB9LAJdo?=
 =?us-ascii?Q?1YkQtjmvcKzMjCjCfN1+vb1sbpKDhowR+utKZ0OJHoq0/UZvPs+RMaxjSWma?=
 =?us-ascii?Q?nHzHWX4o8q1QTd9aTiy1Ncwo1TLDebQohUVc/dfjHXYhipuhvCcW4eprv7mT?=
 =?us-ascii?Q?g+jn4Q/LNmQLvS38XeWMLxaFjygMCpJdR1ziKwTWAK6JXHnruwrKFhe/OAkk?=
 =?us-ascii?Q?JEZyW7XKYjAeQLHzV/oBIMHhK6ycwN/U1afYD6OylXDQnvokfa6ALUcMYg7I?=
 =?us-ascii?Q?qA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?Bzs8Qwl/kEYoLG3/kjh1oTKmrmzZ5HR0Fhvv/5I6iARkPOA3qD11Zh9KiDYK?=
 =?us-ascii?Q?YCXiaW34kSdm2MQGzbmdgQkfuXIBxJkcrugp+oWdXDg4dci877ccaBo1yA1d?=
 =?us-ascii?Q?0r8/ju7ZnGhnZznLSe958CrmSeByk7n2FKkVIwgnyEfNvve8jQZSy7A7D8KI?=
 =?us-ascii?Q?r6b39EWWqjyps1h9ntypn6k0eCUBeF4XG309jns870AyhITN5LVglp6XA8s9?=
 =?us-ascii?Q?vE53s2f9P3OswQA6ZmEIDluy0RDK7A4COGvazfhHwVl6EQvhCwth/4yTTZ+R?=
 =?us-ascii?Q?8LmFQPZXnpyvGhDKhZkU3H6avqi3eLcmrTshrHKI4eyMkH/NQwcv+C8hgY3+?=
 =?us-ascii?Q?HG/YVAWkHRbPnZIbnZqrLQnQnUsHbMbvfHOChg9S+0xMS3id0Xe/WkQmSXO4?=
 =?us-ascii?Q?K9ty6LdpnOYierk7f1vzus9DgE+SSnBQ9rAHpdFyH8dFyNmpH8sRD7xLdN2Q?=
 =?us-ascii?Q?W7FWZzXGKXxcjDzNthZjoSvJXnt71anYFkN4dd4LMq5jEH8qPS8LzqDBE4+t?=
 =?us-ascii?Q?wDjlIzGRXdD+civwjQjJ3S2FkhlNe5vyZgWAAImYU8NR90xSvrnkYIwDuV/e?=
 =?us-ascii?Q?24SIndAdgoTRK50tGyVeSjHNQo14OFTwVCK0dH+YQkdEcdTLaZm/ZhpSq0gi?=
 =?us-ascii?Q?G7IwsOBXi0u9WyoWU8JaYYkmHf8Dkm0amO5l3mC+cN+H0BoQBRtgRDgHgh0k?=
 =?us-ascii?Q?PTQzuEgvWbkePTQW6CIMjFy0RT/rNSqihdsTYW1hQhyUaEfkdoXcrSV9sKnG?=
 =?us-ascii?Q?3CwKwGlHAT0+E+OS8m3ZCBi6leDokKPASh17gq1tPBYhH4vfoXdFfGoP0dEL?=
 =?us-ascii?Q?3gLulrpvHRrxyYYIDWzOkYFzktNW4P66klM9PUGPsRuYPnTKZaBlmBkpl6vp?=
 =?us-ascii?Q?BimSuWzEov4/MH7wLycaiLKZR8glO4H3QHGGCuPyXhR8Vp/E4ZkiBt7Z5EvU?=
 =?us-ascii?Q?2sNaR7EZlgbxXxzVT2jq5Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d1d59fb-ebc4-4431-0eeb-08db264a794e
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 18:15:51.1244
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pd5WnIzV0Kqz6QyAmsmZ6HV8lN8R+oy4HfRav3acsmiQoM9L+DAJ2w+ZM4XhZp5m8ahTW7/1LKSRH11qRL85/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5698
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-16_12,2023-03-16_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 bulkscore=0
 suspectscore=0 mlxscore=0 mlxlogscore=755 adultscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002
 definitions=main-2303160141
X-Proofpoint-ORIG-GUID: X4gdT7VCshWkc10hyexNuolqLpWcwxIu
X-Proofpoint-GUID: X4gdT7VCshWkc10hyexNuolqLpWcwxIu
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/15/23 14:31, Kirill A. Shutemov wrote:
> MAX_ORDER currently defined as number of orders page allocator supports:
> user can ask buddy allocator for page order between 0 and MAX_ORDER-1.
> 
> This definition is counter-intuitive and lead to number of bugs all over
> the kernel.
> 
> Change the definition of MAX_ORDER to be inclusive: the range of orders
> user can ask from buddy allocator is 0..MAX_ORDER now.
> 
> --- a/arch/arc/Kconfig
> +++ b/arch/arc/Kconfig
> @@ -556,7 +556,7 @@ endmenu	 # "ARC Architecture Configuration"
>  
>  config ARCH_FORCE_MAX_ORDER
>  	int "Maximum zone order"
> -	default "12" if ARC_HUGEPAGE_16M
> -	default "11"
> +	default "11" if ARC_HUGEPAGE_16M
> +	default "10"

Is this Kconfig file wrong (off by 1) today?  It seems like it wants MAX_ORDER
to be sufficiently large to allocate 16M if ARC_HUGEPAGE_16M.  So, seems like
it should be 13 today?

-- 
Mike Kravetz