Message-ID: <bdf5705c-9b79-80fa-a31e-6317e4f2c0bf@intel.com>
Date:   Thu, 16 Mar 2023 12:44:06 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v3 4/8] platform/x86/intel/ifs: Introduce Array Scan test
 to IFS
Content-Language: en-US
To:     Hans de Goede <hdegoede@redhat.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "markgross@kernel.org" <markgross@kernel.org>
CC:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "Macieira, Thiago" <thiago.macieira@intel.com>,
        "Jimenez Gonzalez, Athenas" <athenas.jimenez.gonzalez@intel.com>,
        "Mehta, Sohil" <sohil.mehta@intel.com>
References: <20230214234426.344960-1-jithu.joseph@intel.com>
 <20230301015942.462799-1-jithu.joseph@intel.com>
 <20230301015942.462799-5-jithu.joseph@intel.com>
 <7f82f241-39ee-15e0-1ae7-e98e50730c95@redhat.com>
 <275d2f04-782f-2c9d-187a-7a510bf34f41@redhat.com>
 <SJ1PR11MB60831C996C2EC462262948CDFCB99@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <363aa89e-de06-6fc4-e396-d8cc311017b9@intel.com>
 <076097bc-1e7e-72d9-efa9-79d6a94d3f0a@redhat.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <076097bc-1e7e-72d9-efa9-79d6a94d3f0a@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1RoUGN3dGJrWjlxSUJkcURwQkRUYVFCeDhDV05BSk45MXdxL2hNSW1MSGNt?=
 =?utf-8?B?SU5Jbk5mSDB2NVJybHZyb3plaXMzb3E3c0hRVDdvbVorY3c0a0tYZitDdnhl?=
 =?utf-8?B?cTZvUTlpVjVwU0pxQUExeW1VWllJYjIzRWZhaFdFcmpZVWhmamxlbmd0dWR4?=
 =?utf-8?B?MHpTZVRLQjlLTmpRQUFxWThJTnlrYzdpdHFNTmVZYkxnOHVGQ1BDampmY0dl?=
 =?utf-8?B?QnRMUHhHaTVpSlJ6NmhNU0FoN0E4UmltalhWb2xWd01ZMk5aM0lUMXo4V1dC?=
 =?utf-8?B?SVdsbVhCRnNoNUl2VjBCUVBLREdGWXphb2ROZU40ZS91b0hzbXptRUVwb3RH?=
 =?utf-8?B?ZkN1bzY2OGhBUVF6ZUlzTnlXd3dpVnJybWEzYjh0dVI4cGVrQ0VTVVlrYWR5?=
 =?utf-8?B?WVRtcC9yMU10c0duU21qSlFnbmE0dGFQREduMmdDS1RxSUtqTGVBZ3RYN2d5?=
 =?utf-8?B?b3dwNkczeld0TFJjQzRXaEN0T1J3OFFpLzNoRUtMZzFNVFQzQUZPblhuQTFj?=
 =?utf-8?B?dDFzY0xpYVF5ekNXY3BFekt2L3B4NWIweDdvU0FYRWViOWw5ZTg1WFVNRTc1?=
 =?utf-8?B?RDNYT1NMM3BCVFBJQnQxT3U5OGJvb2R6Wi8vekpDNDZYLzdMK1Q3bGJZNGpG?=
 =?utf-8?B?WFBEeXFPaHAzeURJUlpVY1JtZitKTXpwR2Z6c1NmWXJWMXBDdlRGdzRrdFFH?=
 =?utf-8?B?NSs2YVIxYVl2T3NabXpJNmVmRy9YZ2xJNmZtTEFXWTFZNGxWWjFJWU9FTVMv?=
 =?utf-8?B?MDhkbWFxL0RuRVRMRCtWYUkraCtYdmFZM2p6Lzh0QVhZSmpCM0xSTWpPN3pR?=
 =?utf-8?B?VjhSS0xyRytsbGZUaHp4U0YzYVdrQWc3UDRHa1ZTd0ltL2ZmdGpLRDhZMjI3?=
 =?utf-8?B?Mk5Hc3BjUldkUW8xS1BaaUo0K2hWVHFkVkhSTWdUWFR4cTdTbDQ1bEVQMnZX?=
 =?utf-8?B?ZmNjM1VkakdwWXlvN0RoT25VQXNwMVdhaDNXV2ZQbVhXekl2R0ZOMmVudFRt?=
 =?utf-8?B?dXJCeXdiTnR5SnpyTHZhZjFOa3hDTzhHT2xRZjhwVFRieFYwa3kzUEgrMGFE?=
 =?utf-8?B?Z1Y4WTBubCsybG1zYnZQUWk1ekJoWDBzWlIyUGRHd2FTc2xlaHl0d2N5ZFNr?=
 =?utf-8?B?R0ZENnZtcWJOZmk1SDFXTER4eWxsUlNLL3I5T2pNOWdCOWlHTkVOL0ExbDdr?=
 =?utf-8?B?bXh1bWdja3prT29hRFNUa093Tnc5N0Jaenc5dVBRYjRjZzVLQlJ2eGd4a3Fr?=
 =?utf-8?B?VDNnZG5reVBUdmVoMlNTOFkyWTlwTFMxOXpmaEtVOHdGZ0N4MVBMN2MwbE9s?=
 =?utf-8?B?MG1UVjdTZGsrcCtsK2FxcGJ2ei9BdGJTbVh2Zy9vbGY3QzhQNFB5WjBIenFi?=
 =?utf-8?B?R29tYXBkYkEvQURlQ0dZYlFXSzQ1WVFaN2Z5dk5YdVF3dDdlSzV5aDh6bjBN?=
 =?utf-8?B?K3FxVy94SVNDT1hDcHV0VUR4S3NaUHJScVIwQzVQUTB1dmFtU1paQXZ4dUVp?=
 =?utf-8?B?b1VqNys0MW9HV3FkdnZwdTkrT1cvK3lvTFF3cStCdUhEb1VwL01JY3JIMXVp?=
 =?utf-8?B?RzF1RU1NeXo0TjJpOUQ1SmtJS2xzcjBCNlZRZ1JRQWJjYzF0OCtSRXlDRUdh?=
 =?utf-8?B?OURmeC9Mby9sUENaZWx4OVlqbDFJV3plL2xnemF2UmVQU0xwM0tKd3lyZE9Y?=
 =?utf-8?B?Qzl6S2NEZW9KVVdseE5pV3JNQk5tZ0dIN2JJTzJGRCtYNUVod0d5RUt6b1Ro?=
 =?utf-8?B?cGxpNXlUS3FKZTNLVnBNUUwzRURPYWdpbmJqWjEzck1UZm9rL3cxTEcrUFNs?=
 =?utf-8?B?aXZLUkNIcXZFVzBiM3ppY09OcXRURFhFRHlvSG04ZlZIbTY4VVlWdy85dlVk?=
 =?utf-8?B?RDB2MHJMODV1Qzh5TGpTUVFhRUlPMVBiYnhTUEQ0Uko2SzJWOTlJY0xqN3RD?=
 =?utf-8?B?R1htWGRaSE13WEdVQ3BaM0R6Qm9PNDNxcitteStIZ1FGc05RL3JKOEZ0L3cr?=
 =?utf-8?B?V3dNMDJidDVTMjArRDlYNDBxSnc2N0h1U2FHaUVXbW5sRDhNSlQzM2VVS2xw?=
 =?utf-8?B?U3ZXb2NYcE9CdXFkMzgydmdTc2JZVXJLNjNncU9lTkJPUzl3N1dZMHhtZ3FD?=
 =?utf-8?B?VGFUOWppeXd5UUhtN2FVUzRYSm8vQ2ViVUJITENmazZyMC82RWc0SGRtM0FM?=
 =?utf-8?B?ZFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 558fe9cf-e706-450f-070f-08db2656cfc2
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 19:44:10.1605
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BHoB0BojlDDqluwC8jq8Fiap432GtS2xbuqo2P49U/VtgDQlchKEBylP89laMWu4XYty3Ypx/DUYgrbOeebLDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6761
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/16/2023 2:50 AM, Hans de Goede wrote:

> Ok I see, lets go with 1 intel_ifs device per test-type then.
> 
> If I understood things correctly esp. also with the /lib/firmware path then the <N> in intel_ifs_<N> basically specifies the test-type, correct ?
> 

Correct

> If I have that correct please add this to the ABI documentation in the form of a list with
> 
> intel_ifs_<N> <-> test-type
> 
> mappings. And also add documentation to each attribute for which test-types the attribute is valid (this can be "all" for e.g. status, to avoid churn when adding more test types).

Will do. Thanks for the review comments

Jithu