Message-ID: <69230fab-349f-0666-de67-59b11001094d@gmail.com>
Date:   Thu, 16 Mar 2023 13:07:39 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH net v2 1/2] ravb: avoid PHY being resumed when interface
 is not up
Content-Language: en-US
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>,
        netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Michal Kubiak <michal.kubiak@intel.com>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        linux-kernel@vger.kernel.org
References: <20230315074115.3008-1-wsa+renesas@sang-engineering.com>
 <20230315074115.3008-2-wsa+renesas@sang-engineering.com>
 <78e0a047-ad0a-2ca6-10f7-9734a191cefd@gmail.com> <ZBN2rE8WxLoQ1DVX@shikoro>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <ZBN2rE8WxLoQ1DVX@shikoro>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/16/23 13:06, Wolfram Sang wrote:
> 
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> Thanks!
> 
>> This is a pattern that a lot of drivers have, for better or for worse, it
>> would be neat if we couldcome up with a common helper that could work mostly
>> with OF configurations, what do you think?
> 
> I am not so experienced in this subsystem, so I only could identify 4
> drivers which need this pattern, with one not using OF. So, while I
> trust you with a helper being useful, I'd like to pass this task to
> someone more experienced here.

That seems entirely fair, I have one such platform, so may come up with 
a helper after I debug this other issue I am looking at :)
-- 
Florian