Message-ID: <4af7feb7-7663-7bab-33a4-7ffce092f55d@intel.com>
Date:   Thu, 16 Mar 2023 13:41:50 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.8.0
Subject: Re: [PATCH v3 2/7] x86/resctrl: Remove few unnecessary rftype flags
Content-Language: en-US
To:     <babu.moger@amd.com>, <corbet@lwn.net>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <167778850105.1053859.14596357862185564029.stgit@bmoger-ubuntu>
 <167778867236.1053859.12920879751317268318.stgit@bmoger-ubuntu>
 <1a45fc82-9339-d086-2e70-27fd91906b8a@intel.com>
 <edcb0810-df39-669b-ebf2-5988a71525e9@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <edcb0810-df39-669b-ebf2-5988a71525e9@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWZwWFBHRVlublpZZ09HL2JzRk8zWlJNS1JpUUxqbWVLMnZaandOL2FncVgw?=
 =?utf-8?B?SlJvT1hDV0F6NTJ2ZVlISGlXaXZZWGJvOFBGSk1LSTMrMWFOdFhObDR6MkJa?=
 =?utf-8?B?WVZVUnk1NG1tZUpVaG1MUjR1TlZTeE5rWWxJLzhVcGpGREpVUHpEV0IyblFk?=
 =?utf-8?B?cGRCa2s2OStjQ0ZOajFmQk1JZGpoSGFBWTFMYjB2QmRWaitURW1XMFJDaFRR?=
 =?utf-8?B?Yjc3VGFUS2locVV3ZkZSc1N3djdWdTZuRW4wWFNNKzVYQUt1TkVrb3VCNUl5?=
 =?utf-8?B?NzBDc056NFQ5KzloVHk2NVZ6MDFGVlc0SldjZi9mQW1mQVRYbXR1b3laYlJ6?=
 =?utf-8?B?Qk1SOURseWtxQmVOaUZBR2Y1MituSlB3eGozcHNJOGMvYWFoeUM1UmtEajhn?=
 =?utf-8?B?UWRiM1haMmlZRnVCbEVjVzZEbDNZeWlrYzdGSjZBQmNhTVo1bmVyWHpuSXQy?=
 =?utf-8?B?K2ZneWRuVUpnbXJXQ1F0YzhmNUpUOHVzT3R2VXBsMzB6UTlZZG43Uzl2RE9u?=
 =?utf-8?B?TFUzd1BrY3NTTDA4M0RmWTB2T1R4aVdLVTJtMDZNa1A3akgyWTc4SlFUZFds?=
 =?utf-8?B?N2k5L012dG01T016YkpyemFPdFluQ3J0bXR1MUpEWDZaZzU0WmFkcmI2cmRD?=
 =?utf-8?B?UEhra3prMGFtNEluOWw0SlJTVWZpU3BET0Zqd2dsMEFQTHdxUldDSldWTlRE?=
 =?utf-8?B?TE9rZU5ndjhZeVpUOVg4SVg4L3Q3aWdqeFlVZEhBaklSNTZEVnZ6UkVMZHJK?=
 =?utf-8?B?Tkw3Qjc0Tmp6bFZwdTZDWStHOFVER0M2Z29PK1ZtVmY3TFlOZmZYdGRjVTE0?=
 =?utf-8?B?bUxRMDlpQWFuMDkwK3FnRjlxREp6aVVXQ3RFT2pQRSt3a1NmbTR5S0c5T0xW?=
 =?utf-8?B?bi9NOWxhZHY4UG1OcjczQ2puZmdMb1BScEhIRngyUEF6dEdSbXBUbzdNTk5U?=
 =?utf-8?B?WWlKQ0g0UTU4bUtNN0NaR3BZNnkzeEFWN3NaNjd3MTFYaGRUaUh4WlRVUjh5?=
 =?utf-8?B?TlRVNlkzT0RBQlp2OE1GMlBvclhpQjlkVkJkdkVsd3l1UlI0dm8xeDYxMnA1?=
 =?utf-8?B?Sk1QMHorL3FvRGFRclI4N05IQUw2TU1obHBTNDNOSXB6aFoxR2NvcGRvSFlO?=
 =?utf-8?B?S2ZNam0zNnNJVDAzWmJjZGVGMzBseDhSNEZxRzY5ZkRHN0xPODQvYTlFZk5R?=
 =?utf-8?B?dUozTlp2eVdWYm92VHZ3MEJFZkNMaEhabVpzQlFoQm5Qb1N4T0trVUNITjFT?=
 =?utf-8?B?aXdHUnhsczhkTjhwMktCRU1DVk5nWSt3aWQ0dk9yYUV1TlVFWlZoTlo4SGMw?=
 =?utf-8?B?YWZjYlNIUW9WcVIrajREbUpQQjNlbVNBdWt4ZUFGMXNUVjZ1QlBNVWtGR29t?=
 =?utf-8?B?N25HcVJMVmNvdGpQMkd3ejZHR0VNcGFtQWZCT1duRzRxbVBjallTMWdlRWI2?=
 =?utf-8?B?aGdwK2YrUEtIZWtrT0d0ZHd6OERrL0RxQUtZNkQ2SzByS0hnMHdReUs3TXFj?=
 =?utf-8?B?MzQ3YUY0alpYKzJxMUVhWGFhNTlOTGNjZ2lvODJtUnZ6TEJIZlNxcFgwbWtw?=
 =?utf-8?B?dUVWWDhOR3ZsWXQyRGR1NWV0Sk5kUWNZaWFOMUpkVlVndlJ3eVdUclFMRnBF?=
 =?utf-8?B?MG5TRTBDNkdscER6cEEzZDhDU0V5SWthM2dEZ0tMeXFQdGFtbHVMRFhZbzBL?=
 =?utf-8?B?aWk4WkV4ZVdUUVluTXdQYUtxTlRqeC8zR3VvcEFWZkNsV0RyVzJtR1d4NXZ4?=
 =?utf-8?B?cXJxc3F3MTl0dGFta2k2dVpsenU0d2ZEVkttZkpRK3RlVExmZzVxNDd6TUZH?=
 =?utf-8?B?SkZ5cDk0OUlVbVoxTUtEd0FIMFg0M3ExUFJnZHV5QzVqSHU4cFpHS1A4YjBQ?=
 =?utf-8?B?RnBtdUU0MDd4dHd6c2E2QUFjZGdLVzJwRi9uc3pJaVh3TnpvR1kxSEhGNFR3?=
 =?utf-8?B?bkdBWkpwdXU4b0gzdFY4by8vbFR5VHdZR0dlc08rdWxGTVVvMHg4S1djdG1s?=
 =?utf-8?B?ZjEybXI3OGdKLzd1QjNpcWpQRk9EeVJ4SGdCYVkzMGUvRmdFMWQ3aXFsaFRS?=
 =?utf-8?B?WFVlN0V4NU5ZbVppaXphRG9xTVlJUjFBcmsrVHhNTWE4dVpoZE94T2hIYStS?=
 =?utf-8?B?TmRCa2IwSGE4MlhINWhkQ0hxRGpNditQQmlDc2N4TWF2N2RyMy9JRUhsUnJj?=
 =?utf-8?B?enc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 919ea05e-0c43-4869-b407-08db265ee090
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 20:41:54.2699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OxbzuKAq3rMFwAMb4WB3WLeUhr25xpVdtDThUKt/2Nd4sBywkpWEL2AFDrKjlEWK2psSl+n/73futnmTs/+R6lnc95OPaURi81EnYc7+OUQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4569
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 3/16/2023 1:31 PM, Moger, Babu wrote:
> On 3/15/23 13:33, Reinette Chatre wrote:
>> On 3/2/2023 12:24 PM, Babu Moger wrote:
>>> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>>> index 15ea5b550fe9..3c86506e54c1 100644
>>> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>>> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>>> @@ -3163,7 +3163,7 @@ static int mkdir_rdt_prepare(struct kernfs_node *parent_kn,
>>>  {
>>>  	struct rdtgroup *prdtgrp, *rdtgrp;
>>>  	struct kernfs_node *kn;
>>> -	uint files = 0;
>>> +	uint fflags = 0;
>>
>> Hoe does changing the variable name from "files" to "fflags" simplify
>> the code?
> 
> I should have said readability of the code. Its actually fflags we are
> passing to rdtgroup_add_files. While changing flags below, I changed the
> variable name to fflags.

You are correct in that it is the actual fflags parameter but what it
reflects is which files will be created. I do not find that using "files"
makes the code unreadable. 

Reinette