Message-ID: <b2587ef0-38da-6714-f26c-5b8a16fba340@intel.com>
Date:   Thu, 16 Mar 2023 14:17:48 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.8.0
Subject: Re: [PATCH v3 2/7] x86/resctrl: Remove few unnecessary rftype flags
Content-Language: en-US
To:     <babu.moger@amd.com>, <corbet@lwn.net>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <167778850105.1053859.14596357862185564029.stgit@bmoger-ubuntu>
 <167778867236.1053859.12920879751317268318.stgit@bmoger-ubuntu>
 <1a45fc82-9339-d086-2e70-27fd91906b8a@intel.com>
 <edcb0810-df39-669b-ebf2-5988a71525e9@amd.com>
 <4af7feb7-7663-7bab-33a4-7ffce092f55d@intel.com>
 <c07dfb04-4502-47d8-ad89-9f9c7898f246@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <c07dfb04-4502-47d8-ad89-9f9c7898f246@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dng4QU02UGowVDdSN05kVjFJZlBMY09GMnl1Q3gxTDErVlpibFdENE1GaXBC?=
 =?utf-8?B?UzMyOTlkQVZLWDVRQ24yblNBV2ErV0RuQnVmK3FJUFRqK1B0bVBTMThlYklH?=
 =?utf-8?B?WnBxMW5VVzJ5dDlTSWE2TGk3R1lDZUFYbktTc09qOFZsRW5Vc2V2YXltV1hL?=
 =?utf-8?B?Z2Jma2dtWlRicFdJNDBQajVLWVZKbjBZSUdtZy95VG1oRDMyMEVLbHN3M0Z0?=
 =?utf-8?B?OEx1TzF5REhXYmN6VHFiRGRXbGJwMEFRd3FZRFlzS3dmdzhnNjNNa0huZU1j?=
 =?utf-8?B?SUt6SFdnUmxDaXJIdHo5ZDhvYnVRTTd2bm5BV3dYTFAyQnp1YXZuSUoxVDlL?=
 =?utf-8?B?VDU1UnZTRzE5MkNSTXBTK3ZTZUw4NGwxUUF2cytEK01GL1NPMlJsZjlkdDNz?=
 =?utf-8?B?d0hmNzgzYTlSTCtvNXQ3TnIzZWZkWXRQc0E5RHVPbFZtcDZaZFE0eVRMaXkz?=
 =?utf-8?B?R3NKR3dxMXhUUzdQb0NSRXp1dEtmMEpBd1diSEl6bkVwOWQvZ0UzcVVjMDZm?=
 =?utf-8?B?ZnZTQURjeTR0c3JCZ1ZlQ0RlNklIUWxzT2VrR1RGbWluVGtXYzAwSXh6SUZj?=
 =?utf-8?B?emxJM1ZDUzA5UDRObzdxWFo1YUkwWW5lNkRWcGhsUzNPa04vYTQxcXJueHM1?=
 =?utf-8?B?OWl1SWgwWTBBajVPQWRIdDRrT21oS2g1UEE1bnA1YytTVGdjZEtkbFUzaStO?=
 =?utf-8?B?UTkyaENyMWZvcThNbE5EcmxyYjZwRWJ2QkIxbDRoUmx2cjZFMS9HYlpISGM0?=
 =?utf-8?B?SVJ6b1cyRURuOFNUSWI1V0ZhR0lJL0dicGFyR3hKQVRzS245TVVyUHhScTVH?=
 =?utf-8?B?UWpkYlBINCswQWVXMCtPYVhuNFQrWThxTlBIUUFhVE4wYXhRcWZ3NnhBdTFj?=
 =?utf-8?B?VU5GMkNFZTdWODEzWmptN0JoNzZzUEc1eEp2WStnOG9QWkJINkVra2hMY0tw?=
 =?utf-8?B?YnhCZzAwRFREVVRlUUNJU1c2bUZ4cUlMa1NRZEliZWdtQmc2RklMYTRieHdv?=
 =?utf-8?B?NTdLVSs1bmQ5bzNRTTBsYlJGV0svcnhWNXUzbk9WQmxudnlCaERMRWcrQWRi?=
 =?utf-8?B?QnNoa0w1ZVpVc0tpVDhSSVJMMmhsUXVTR3lsV0NYa3RUKzZEa0FpcHByMjJp?=
 =?utf-8?B?SnhtYnVrdzV3TXBFRjJzZEI4K0pOYU9DQTg5cytoZU1tNXRWYk9uUEJYWStI?=
 =?utf-8?B?TytHWjJSaUpFVDNpOGlCUEwzS2FhVURDaFhUY2t0VU45MUVkdDd1OGJRaVV5?=
 =?utf-8?B?cEZubWRFRmdVQjFZbklCQk40UVdtdENLcTk1YW0yZW1jWFU2VWhyRmVYYjJx?=
 =?utf-8?B?aHA2MU43c3VET3pHelpmZVNpOFVtckRZUnZ1SXQ2S2QyeGhBMnh6dnlTWVBQ?=
 =?utf-8?B?THpucFhqenc2TUhOOW9yMGl2dS9QS3F6ZzJLcUg2VWpPRUVrVzV5M0I4L2Vp?=
 =?utf-8?B?Qkpsa3ZqRVBGT1plMEdxaE1kUXhQMlJIQWNjVDk5MjduZFp0eEl5bHFGY09U?=
 =?utf-8?B?b2FpVFIwZWJtOS9KMm9oZ0cwRnhHUnBEdXNLaE4rZ2NsaU1JNVhPQzM3blFG?=
 =?utf-8?B?dWtDYkg4b1Nudm5MVGRTWWFvZnVvNFRpUDVrbHM5RmVhZzVFVTFiMmIwSzFj?=
 =?utf-8?B?VzBGSUJzRUJiV2phNjB0b3loa2g1UEpJeE91b2ZSSWlnSmhwWkJUUzcwYStk?=
 =?utf-8?B?KzRUdE1QTy9GOTZBQVlkVlcrSk56UHdHa0tNWDYxSStxakpvdm5IZHJNTGlw?=
 =?utf-8?B?aHJlRWI0eXRuVWZ0bTBuNDh2dzRwS2JSYjdSL3ZLcytSdmJlazJnZXZDaGRr?=
 =?utf-8?B?d01XK0o4UWZZSzQ4cjdPcHhySFlOMVpIbW1mT2tjdm5hL1VIUm9pWmo4OUV2?=
 =?utf-8?B?K2M0VTNtc0RxUmNqZlVTV0JWY3BpeDNuQVk2RHRIVmVvL3FzZXRvOUphakJh?=
 =?utf-8?B?MFhqN0xLdG8vSmdxZVlxOUpiNTNORE1tRkdtY1hRcEdJYnRpd2pnNlBKVEZt?=
 =?utf-8?B?VUhhRkIrQjRLYXorQmJwVnpra21WOWVNMzQ5bllhbUgwRytQblVMWlJpR0Qx?=
 =?utf-8?B?WGZGOHFZM0JVVUIvWnowSzJlUG1WWUtjNWdURXRqa2FMZmRtcUpFSjBiZjZC?=
 =?utf-8?B?UW00TmlPVjVndzRWVEw2N3FXczFoYkRrVXJYcUV4dllZemRuWVhTTDJXSFBj?=
 =?utf-8?B?cHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ad313c0b-7aac-410c-81f9-08db2663e739
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 21:17:52.8949
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xWqYejAjgR+VUOL6Ja8jvDaYkUgqaoAeQGc02KgB/x14bsMTndzLl2vSym4ThP/N5zeLBOCO9lOU3k8jptB6PLNVua2AZJgbceD0zWqJ8a8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7831
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 3/16/2023 2:11 PM, Moger, Babu wrote:
> Hi Reinette,
> 
> On 3/16/23 15:41, Reinette Chatre wrote:
>> Hi Babu,
>>
>> On 3/16/2023 1:31 PM, Moger, Babu wrote:
>>> On 3/15/23 13:33, Reinette Chatre wrote:
>>>> On 3/2/2023 12:24 PM, Babu Moger wrote:
>>>>> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>>>>> index 15ea5b550fe9..3c86506e54c1 100644
>>>>> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>>>>> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>>>>> @@ -3163,7 +3163,7 @@ static int mkdir_rdt_prepare(struct kernfs_node *parent_kn,
>>>>>  {
>>>>>  	struct rdtgroup *prdtgrp, *rdtgrp;
>>>>>  	struct kernfs_node *kn;
>>>>> -	uint files = 0;
>>>>> +	uint fflags = 0;
>>>>
>>>> Hoe does changing the variable name from "files" to "fflags" simplify
>>>> the code?
>>>
>>> I should have said readability of the code. Its actually fflags we are
>>> passing to rdtgroup_add_files. While changing flags below, I changed the
>>> variable name to fflags.
>>
>> You are correct in that it is the actual fflags parameter but what it
>> reflects is which files will be created. I do not find that using "files"
>> makes the code unreadable. 
> 
> Everything helps. I changed it because I was already changing few things
> in this function. That is not the only change in this function. Here is
> the main change in this function.

I did read the patch Babu. I trimmed my response to focus on what
I was responding to. Our opinions differ on readability of the current
variable name. This patch can focus on just removing the unnecessary rftype
flags.

Reinette