Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF7EC7618E for ; Thu, 16 Mar 2023 21:22:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229902AbjCPVWw (ORCPT ); Thu, 16 Mar 2023 17:22:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbjCPVWq (ORCPT ); Thu, 16 Mar 2023 17:22:46 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9798DCD660 for ; Thu, 16 Mar 2023 14:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679001720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nOiJMs6jGjsIK5mURzzO91u2urF7NRidfMKLLbVDxmI=; b=Kep5berdbyn9mfhIyF8BV6BbgGQMJqq27LFgHrvANvkK52xEedWDNLqgtHZGbXrmjyZepZ CB4A5R6suaklCLO/M/xHPZHgnh0o6xF0AsUFTqBlxd3gIpWjZD7hna4EZ7URS+OMPnTdAX vg+7Ohg1bjzyM//fOHNwTu675ZSdSgo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-444-U1vkmoP_NjKzPR5dpAkY1w-1; Thu, 16 Mar 2023 17:21:56 -0400 X-MC-Unique: U1vkmoP_NjKzPR5dpAkY1w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D4ABE185A791; Thu, 16 Mar 2023 21:21:55 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95B8C140EBF4; Thu, 16 Mar 2023 21:21:53 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <4EDC79DC-0C32-40FD-9C35-164C7A077922@oracle.com> References: <4EDC79DC-0C32-40FD-9C35-164C7A077922@oracle.com> <20230316152618.711970-1-dhowells@redhat.com> <20230316152618.711970-28-dhowells@redhat.com> <3DFBF27C-A62B-4AFE-87FD-3DF53FC39E8E@hammerspace.com> To: Chuck Lever III Cc: dhowells@redhat.com, Trond Myklebust , Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeffrey Layton , Christian Brauner , Linus Torvalds , "netdev@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Anna Schumaker , Linux NFS Mailing List Subject: Re: [RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <818649.1679001712.1@warthog.procyon.org.uk> Date: Thu, 16 Mar 2023 21:21:52 +0000 Message-ID: <818650.1679001712@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chuck Lever III wrote: > Therefore, this kind of change needs to be accompanied by both > benchmark results and some field testing to convince me it won't > cause harm. Btw, what do you use to benchmark NFS performance? David