Message-ID: <dd26836f-d54c-65d1-0acc-8a09745bb066@wolfvision.net>
Date:   Thu, 16 Mar 2023 23:29:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 7/7] dt-bindings: display: add panel-timing property to
 sitronix,st7789v
To:     Rob Herring <robh@kernel.org>,
        Gerald Loacker <gerald.loacker@wolfvision.net>
Cc:     dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Maxime Ripard <mripard@kernel.org>
References: <20230314115644.3775169-1-gerald.loacker@wolfvision.net>
 <20230314115644.3775169-8-gerald.loacker@wolfvision.net>
 <20230316215735.GA3940832-robh@kernel.org>
Content-Language: en-US
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <20230316215735.GA3940832-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ky8xbkh1c3dQMElDdVdwaEdSUlpKTnRORUNTRERZK3V0OXhoNUdHalk1bXF1?=
 =?utf-8?B?SjQ4TVh4L1FUVThQT2QvdUpXelJQWDJYclFydUt3MVgwOXFyTnRqVDU3bWNM?=
 =?utf-8?B?QWRTSmRvTzNaalFzZnd6VnBDWmNyMklveGJiWEMrV2paYjNQRVVRcy9MUzBK?=
 =?utf-8?B?MGw1UEtDWG1VZ1FlMVJhZ2cwMURWZ1FHbDJ0UHY5LzZjNUVRMFp5UkxhbnF5?=
 =?utf-8?B?SzhGT1Q3Qy80QWNXOW1JNkVpd1h2SStReit4dW92Y2YzUzhiRHNwMncwSDdT?=
 =?utf-8?B?clZUTmllcDlZdnJCakF2QjZZWVR2QkxGdisyTk1tVEs4dnNQbnA1d3hZblBE?=
 =?utf-8?B?NjJaRjVraTQwb0lTb25IaGI4YkZ4WTNvR1FjMkxGbWtSWEppUmR2aElrVXBJ?=
 =?utf-8?B?azZJQ3BXWFRpb1dLMlFDWlJrSGVKTC9tOVZjdFJDRXlFYUsxL0JZYUtSSUl3?=
 =?utf-8?B?dHRFN1BzS3cwZlZGanlPRXEyK2hRdVk4T1l0eEFjak5kY3U0MGNEdk5yRUhn?=
 =?utf-8?B?QmtlZ01wS2svcDBnN3FDWEtiTEtJd2xGWFZhUGlMTHJ4ZTlPWDcvMExGL2lD?=
 =?utf-8?B?VlE2TUJWdktqalA4emtuUzFKVUZLaGpYbEx6OVFwdnZvMEhZR1lVYktPWUJG?=
 =?utf-8?B?bHUvU1lWV3BtbWU3dmdJdXVoZUs1QnhwcG1tai8wT3dGN1BibTczVzNpV3NC?=
 =?utf-8?B?Zmd6dmpNemJtVkdYMHhJRHdiNGJiN1lDaU9mQnFuWlk5OVorTXd6aUFHNW9y?=
 =?utf-8?B?SWY5NDE4cUM2UUxObUI1dFc0djZ1emtxRHoyeWZoSGh4VS9oQlU3YnZGQkhq?=
 =?utf-8?B?R1dPYWxyUEJtd25TWWxWNkQxQnkwRW1FckxlVUc1OE5nOEpBVXNZdVdmMDNK?=
 =?utf-8?B?cG1pQTkrNjVyTGNkZlF2TkEweXY0RVlydHpaQlJIY2ErK29NOHE5WFdmekE1?=
 =?utf-8?B?eFVMOEZZaUV4WDRyMEszTHRZSThXTE43QzRPdzFvRWxjZTdKNnRDRjFadkhH?=
 =?utf-8?B?VTlOVExNNG93SkZZTVlCQzl2eUlvSlJXbVBscTd1aDMvZjhzSnhuV2k5ZFNx?=
 =?utf-8?B?Tnh5SmNrRVZJcWt4YlRLdXd6U3UycVRVeWM4NHpTb0tCYkcyRENJWk0xMUNE?=
 =?utf-8?B?RHM3VVNnTWRrTlZLZ2d5MlRGamZVcitjUVhJVlV4SmVYTmsrOXlMbTcyaTNn?=
 =?utf-8?B?NVpScW1SZ3lEZWlNL3E1bHFIY0dTUTdxZm5yK2xyYWlYTk5pZSt0ZHgvUzV0?=
 =?utf-8?B?Q2JDYm51SDl5b29pTjVoQnFadDdVQnJVZmtIUFZFTjFxc3BHVWIzN0R6QUE0?=
 =?utf-8?B?NXNEcVYvYVhrOW5yeDhhTVhpNUZlQUlQZFRiMWJzQ3VxN0ZVTHJHWGplZm5B?=
 =?utf-8?B?NUVNL1JnWG1sbnk3Q3FVb1dnSE5xUm9sVzBIbXhreVUrQUIvNnIxSW5DUit1?=
 =?utf-8?B?TytEaTdHOXNMQ3ZWbjhFdWtva3NmdlRDMHNtZXNDQkZCaFlEcmxiWXU1dkRR?=
 =?utf-8?B?UC9IOFo0WE8rYVhTeU5CT2F4c3dJbTBQVnREc0J4WUJnNHV2eHNxWDR4bEpF?=
 =?utf-8?B?VC9jRjQrM2xoQ1VxQ3kvdi9TQ2tvWUxuNHZjSmRTVDNEWGN5Zi9kc0crRkda?=
 =?utf-8?B?T1g0dSs1SXJqYmV0LzRHVEpMd2VlRUVacjM3K3dPSjYwYnBrK1U0MExZeSt6?=
 =?utf-8?B?YVZPTm45OWt6TnZ1YUJQYktvRmM5MFJ1L3JINHcrcWg1bjFOVnBNcWY1TTVM?=
 =?utf-8?B?SnVoam5MM0FVWTFuNGVnVnFFYUJzYlNYQVgyZmJSZ3dIelZTTE8xeFZMU1JE?=
 =?utf-8?B?dUozQTR1aVBpMDJVUk9iZWhoaGRWT0hzRHRWVnVmTE13VVljd1FwbTB6Zk9K?=
 =?utf-8?B?RnZTKzRZK2g0cGJ1NW5MWktDV0hlYS8ySHRXR1cwNXVCVzMrdW1hT2k3UTN6?=
 =?utf-8?B?WWNOaVNWRUhOSytTV0RoWGR3dlVscHY1M0ZINzJmbEEzT2FkaVViMmdPWHk2?=
 =?utf-8?B?ZGlFaFhTaG5lM0prTFpQZWI0cTlOTnRVd0pYUFNQYXhPamtjbXp5OTVadTZG?=
 =?utf-8?B?aFJSTlc5cDdjMDdWOG1WdG54K2lNVU9YcVNHTXB6Y3VNZHozSG1oVXN1VVpZ?=
 =?utf-8?B?K3JxanltVFlGNjRMMTdMcEdSQ1VTMURTZDF6N0o2NDB1NFlEWjVzUHkrSE1s?=
 =?utf-8?B?M2xicGdIaXovdEJKdWZad0w2SmZWQnNESTdrNGNFQVFoSXNtSmtCZU9nc0Yw?=
 =?utf-8?Q?gjXLIEd2lW+AM9ClUTfGg2e0Fo7rkIrzolwhDX/CVE=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f601704-4a95-43dd-9667-08db266df834
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 22:29:56.1950
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zSW/DLxbgybNSXK0S/J1LoierR7fyJVu6bH48hxp9wefQeWQbGtqLqiQbuPUntK8BDzUXKFH31I7tJ6hp86+icrrUq0bLzkXVCz6smwQExM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9460
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

On 3/16/23 22:57, Rob Herring wrote:
> On Tue, Mar 14, 2023 at 12:56:44PM +0100, Gerald Loacker wrote:
>> The sitronix-st7789v driver now considers the panel-timing property.
> 
> I read the patch for that and still don't know 'why'. Commit messages 
> should answer why.
> 
>> Add the property to the documentation.
> 
> We generally don't put timings in DT for panels. Why is this one 
> special?

For now, having the timings in the device tree allows for setting the
hsync/vsync/de polarity.

As a next step, we aim to implement the partial mode feature of this
panel. It is possible to use only a certain region of the panel, which
is helpful e.g., when a part of the panel is occluded and should not be
considered by DRM. We thought that this could be specified as timing in DT.

(The hactive and vactive properties serve as dimensions of this certain
region, of course. We still need to specify somehow the position of the
region. Maybe with additional properties hactive-start and vactive-start?)

What do you think about that?

Thanks and best regards,
Michael

> 
>>
>> Signed-off-by: Gerald Loacker <gerald.loacker@wolfvision.net>
>> ---
>>  .../display/panel/sitronix,st7789v.yaml         | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
>> index ed942cd3620f..8810f123dedf 100644
>> --- a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
>> +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
>> @@ -21,6 +21,7 @@ properties:
>>    reset-gpios: true
>>    power-supply: true
>>    backlight: true
>> +  panel-timing: true
>>    port: true
>>    rotation: true
>>  
>> @@ -54,6 +55,22 @@ examples:
>>              spi-cpol;
>>              spi-cpha;
>>  
>> +            panel-timing {
>> +                clock-frequency = <7000000>;
>> +                hactive = <240>;
>> +                vactive = <320>;
>> +                hfront-porch = <38>;
>> +                hback-porch = <10>;
>> +                hsync-len = <10>;
>> +                vfront-porch = <8>;
>> +                vback-porch = <4>;
>> +                vsync-len = <4>;
>> +                hsync-active = <1>;
>> +                vsync-active = <1>;
>> +                de-active = <1>;
>> +                pixelclk-active = <1>;
>> +            };
>> +
>>              port {
>>                  panel_input: endpoint {
>>                      remote-endpoint = <&tcon0_out_panel>;
>> -- 
>> 2.37.2
>>