Date:   Thu, 16 Mar 2023 16:00:03 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>,
        David Hildenbrand <david@redhat.com>, linux-mm@kvack.org,
        linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] mm, treewide: Redefine MAX_ORDER sanely
Message-ID: <20230316230003.GB6211@monkey>
References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com>
 <20230315113133.11326-11-kirill.shutemov@linux.intel.com>
 <20230316181547.GA6211@monkey>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230316181547.GA6211@monkey>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xNQXuZL4mT4NrQKxPGfUWZeCkZpbmdVQtgAcXs70ji+3h15rY7utxrRAYEjM?=
 =?us-ascii?Q?rBaCXsrLljsiScFij1HOfoXpsOqtAhaNYqdCGBdE5IbT4LbD3MExEZ+tnMQj?=
 =?us-ascii?Q?z7nJozFQddAcG7Y0OWAWETOAngYB9KSpyeLZry4cJMHePo7SXwRmQJUMghGX?=
 =?us-ascii?Q?FRK6BA9yBZPTjYgq7J8SVKVEAdWOXlS2KbkKREmBnUgfxTci4UR1wOESanVe?=
 =?us-ascii?Q?JMy9Af6CilwlTpnbDz+FwTvOojFoxir8YPTRL44NBSMQl01B4GYxJTo+WJn5?=
 =?us-ascii?Q?8b9YfHvmsKiWmBrk4ErAL8hn7YPbU2WJjPxOxmZBgHHo9MBRJe/IfYKTFXEP?=
 =?us-ascii?Q?uikh2AERGU9/upG5ilK/tv7SRuy+6EuEIWyFH7rMNcJNK2RYqN4zm8+sLDoJ?=
 =?us-ascii?Q?Jt/DeXynHFZZQGhC3Hw8sOaqF8H9U4mq+64AWJoOaEBalkjVzIYXUNpqDllp?=
 =?us-ascii?Q?jJ9WUfD/D8ZEfauAzyCyQ9tJwvie+7W64e/o2rkn9l4hHysqADF2r0uf18SR?=
 =?us-ascii?Q?ykEfChyId439Ol1JhtOoaYDUFR5V40wjFEOHul0omRjtpAh3tgZTi7Embhns?=
 =?us-ascii?Q?wKghoRMS5B8Nfc+iNKtusfty8INRL0ETNOB3eFr+7lUYeF+G+metoh4s87pZ?=
 =?us-ascii?Q?ADzVnWsaWS3Nghei83PlhNQulG5vFGwCuuF5QHuJy5mkJQK9XZD3cOSp2L7J?=
 =?us-ascii?Q?E6PuH9Wi2VmnyiK6i8MjPAhApwV0yCGah17lLm+JBbb/dwVk7uvxFLo/ueg4?=
 =?us-ascii?Q?+WhG6qAjpP4bYe0rQ7pTs/nZRFGcsF6DPZrke4UKrnto03qgct+g2w9OpcO9?=
 =?us-ascii?Q?6HpAA0YphMBOc5j/XhR3dh4IYcRyYLTESdXWW7KmXjok/bTywmQ9hPdqt1BA?=
 =?us-ascii?Q?KG9iq/l5RG0tliYggXd3JB+WuCViRr2gK7MA+olotJmB4X3E0C6V2dn8r/AK?=
 =?us-ascii?Q?R3eQPbWXCuMbW85MdbaFl4gUEMn09RZcp2QIsxzAAw4cG3OMG73hqaatyD0o?=
 =?us-ascii?Q?e6YWl2NAKMQb3zf8BE+s4NdxCB/81CdY4jvUjboVUdD+BO7mG42s08FO8bVc?=
 =?us-ascii?Q?hV6bum17/Ao2hnCaKNSOcS6xpc2XgxNVlbSGuKgrOSPQ2mdf9mJ2YX3srP+K?=
 =?us-ascii?Q?+rVQYQjpo2aUJi6o481QoyQ2B06m1zJhf3CP7NARmOd8A8cElGVnPkBKpDrn?=
 =?us-ascii?Q?8ojQw22A5BOzaCzbJqvBt6+AaWd3HlWsSsf03qpzU/eCpDI82qwQsYCRS1xO?=
 =?us-ascii?Q?2DZgE0AZy7sE9hXH6MTcMrJHjVoJnKoSxliZQE1K12opoiW2CNUA3d4IckNw?=
 =?us-ascii?Q?rKZc/yz1WtV+izVsf+cckLx+HOAy6qvN82UPTs6mxPkg2xlIxtKWKmjrZt2u?=
 =?us-ascii?Q?5t7f2mqzncvNX/mPcq9BYbrOk1HKD6Az9O/ixYrzv+8LCCP3ED6xDXShPH6/?=
 =?us-ascii?Q?C64lfeACIB0Ulgn0+qpZerKc6N+rxHlbhEoJLB3zwrZPNZZ+N9stqp13lByq?=
 =?us-ascii?Q?I/CL+/96bM0QbYwQzI+bXxDuGKrl65BAZeav5vtlHwUlPtYyKubphtK9pA5D?=
 =?us-ascii?Q?HFaP675KnoA9BD4ubvJaxEv8Q4Yzv0cnKZWy1mprDCQ42EgugbEZ8cQ1mZzm?=
 =?us-ascii?Q?HA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?GpgFGT1JpUpz/ivWhvODol0Mdh7zMRxrP/LouKlYfHm4pynfIn8BS6lG7YpK?=
 =?us-ascii?Q?1ihKAPoSPLH1sbd+ry09E9ZjOfMnvkl0rd/KZ1dNxzlyBexv1dAK9WV82m6f?=
 =?us-ascii?Q?m/s2IIw+S0Am3bnxVowvjX1nW2YiUEOWZPrYhl1oPrjNGqF6qkXxb7TutwVY?=
 =?us-ascii?Q?KH9UvOruEBHxbKZc1Drev6qXmLnc5R1ORgSS5+Sv0vLQd7V1oIFs9i70Vt+R?=
 =?us-ascii?Q?8MtQ8vB4zW4rVIc1D8DeYBZf30KVUE+ulhiI47Wfv949Na+AepXESBwvEJPi?=
 =?us-ascii?Q?0dA0PF6kMI8ksoRsOIZ5UFXVhnRlcZ0Xz7FBb+YYrp0d4uUcsvJOIoIzteQn?=
 =?us-ascii?Q?EQvdTXVlBhvr0aGjU3CErnp7UPo8fzBz1386HwlGPaqQ5XiwNtjW8ZBrXr90?=
 =?us-ascii?Q?V41IK/75/b5ZNevVs+T4ujxKQ5D+991GJ7dBfWExW4rZXJlVDpyRqEHVzU/y?=
 =?us-ascii?Q?7iMv2oghHthO9mMayyaP1X4+/Mw4ZInvaQiA5v2d4LeXlyR8nrM3c1PaYK3G?=
 =?us-ascii?Q?XC5L+DsdPsQRMXgR26asTZsl/QpZLE/0dEYhlU2kuLEmDFP1yfd0Cj8x9ddf?=
 =?us-ascii?Q?K/vTh96lmygtTmHNVqk0TGTFQUx8MALlaptpyunt9fUHDvTpmozY8E10PGD5?=
 =?us-ascii?Q?7eLq8KgFb+mXwExDK0Pjxrb8zRCY+dC/YiHBRf/vfPeY9Ieh28xKUabejIZz?=
 =?us-ascii?Q?KXupwxgz2L+5EgJvaP9utZUh0atCThT+rBhRaL2J1BRFxiuQZwBCc03LEMJF?=
 =?us-ascii?Q?KqySuX2/N9bxn2Xca2qmhmVnIrrCLfzjaLZbWaJblBupDdNfqHeiBpT+pVwv?=
 =?us-ascii?Q?UYGbdf3S9vziW4mwFN7AZoiBjpY+fKIzdeETy/FWkT4GUI0c7Z7kLN5R4fQK?=
 =?us-ascii?Q?f9Vw0DBeqintcg5l2QiOBNDpebGedCiAYpNNYRtyW0F/TjA80N+yk7ialZEA?=
 =?us-ascii?Q?16bsrHesdSlambV8M9E3Vw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b619786-0a76-4879-4a2d-08db26722f02
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 23:00:06.2810
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZIcf5nqDj0HTVQoVrVgu0VmEtPC6l633mOYzZQrHa0OaApfy5vPD/WTqCto2O5KSeHGv/zh9BATTLrBkxI4G9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5567
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-16_14,2023-03-16_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0
 bulkscore=0 mlxlogscore=887 malwarescore=0 spamscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002
 definitions=main-2303160173
X-Proofpoint-ORIG-GUID: bN7OBVDJfRpF_OK1Yz1TdeIeC5e3rjQF
X-Proofpoint-GUID: bN7OBVDJfRpF_OK1Yz1TdeIeC5e3rjQF
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/16/23 11:15, Mike Kravetz wrote:
> On 03/15/23 14:31, Kirill A. Shutemov wrote:
> > MAX_ORDER currently defined as number of orders page allocator supports:
> > user can ask buddy allocator for page order between 0 and MAX_ORDER-1.
> > 
> > This definition is counter-intuitive and lead to number of bugs all over
> > the kernel.
> > 
> > Change the definition of MAX_ORDER to be inclusive: the range of orders
> > user can ask from buddy allocator is 0..MAX_ORDER now.
> > 
> > --- a/arch/arc/Kconfig
> > +++ b/arch/arc/Kconfig
> > @@ -556,7 +556,7 @@ endmenu	 # "ARC Architecture Configuration"
> >  
> >  config ARCH_FORCE_MAX_ORDER
> >  	int "Maximum zone order"
> > -	default "12" if ARC_HUGEPAGE_16M
> > -	default "11"
> > +	default "11" if ARC_HUGEPAGE_16M
> > +	default "10"
> 
> Is this Kconfig file wrong (off by 1) today?  It seems like it wants MAX_ORDER
> to be sufficiently large to allocate 16M if ARC_HUGEPAGE_16M.  So, seems like
> it should be 13 today?

Nevermind, PAGE_SIZE seems to be 8K by default although it appears to be
configurable.  Not exactly sure how the hard coded values above work if
PAGE_SIZE is configurable.  Too confusing for me to make an intelligent
comment.  Sorry for the noise.
-- 
Mike Kravetz