Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF177C74A5B for ; Thu, 16 Mar 2023 23:05:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230107AbjCPXFV (ORCPT ); Thu, 16 Mar 2023 19:05:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229804AbjCPXFP (ORCPT ); Thu, 16 Mar 2023 19:05:15 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A514CE5016 for ; Thu, 16 Mar 2023 16:05:14 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id d8so1895665pgm.3 for ; Thu, 16 Mar 2023 16:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679007914; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UX/KTPHcDdcu6dbgU5HB9yD5ykeUvMNlEFlUDYk+cCA=; b=SF5xfB6kSG39cncDovV1pyUCNotzNarkCKr42WsrRqrv+9fidcfNcsYPs/E/nLYTPi sgP/iHBm74AvHzfnMrAzzmUWvrn9SNnbrKYc5WBLnRJ8pwuz/PqVPl9lzDBLAVPAPU5A Id8hV68bUKBptVKA3NUQfarZihMw+hUjU9uxVsun49Ne/HblwfQ+O1QNHpaX+KBVjxU/ r22m9lmL4OaosAsU5R6KT2QaddJbY9rG+XSNWbWml8bryeqMeZnwijl9K4jd0Ucws+qk 8Q1XJ3Gb+bsrtNOownn3Vxf3W0lbgbCggKodhNKtDgw7Y8Zu7e1tDbGpgJSIFTiUkDzC Vunw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679007914; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UX/KTPHcDdcu6dbgU5HB9yD5ykeUvMNlEFlUDYk+cCA=; b=LXv7ZD7bg3pYUSHFAqksb5Aaz7D+271As+bwG9Zgd054JrCjQmwMO1NYcMIGMN3zCv S6YzH7usTtFbKK9Iahh+gvgw4oPWn2PJuZnA6OyW57YpP4iv7CJ0IaWlejbD1yuNcazF iRm9j96UankpZnz3As/XKDIFo7DLEmq+SUfXz1o72S+KH2CRw3/cTPzOueJveL9+6rFH YXKcR690NEHMKlSF4mzneVwREd8mj1ol6wC+nDBRvsNgz3aC4qpTCBzAqh4fUAEGds7r 70eVLtp+OXyhHBvXa1Z5HksB8ukE6Qa1zzE9IdgGZFvsOP40oOnG75a48vn905tDEFsH IdbQ== X-Gm-Message-State: AO0yUKUQXpdJp7K7/aliQKBryFoa/Get8+RmWhGM+Xijor8wJ32uXMsc SMIwpxwqPQI6z1D9ZrXAGBLrtLzDwZCoT28KExzUZQ== X-Google-Smtp-Source: AK7set9xMU7SWH6Z2EQZMeJm478KkEPP57LvIRya986B0PASt62FSyyKX2NMFas/FBsNA5R+wN1CExGxMYRivLbhMTs= X-Received: by 2002:aa7:88c4:0:b0:624:6e5:1a2a with SMTP id k4-20020aa788c4000000b0062406e51a2amr2437655pff.0.1679007913947; Thu, 16 Mar 2023 16:05:13 -0700 (PDT) MIME-Version: 1.0 References: <20230227201340.2087605-1-sdalvi@google.com> In-Reply-To: From: Sajid Dalvi Date: Thu, 16 Mar 2023 18:05:02 -0500 Message-ID: Subject: Re: [PATCH v2] PCI: dwc: Wait for link up only if link is started To: Han Jingoo , Bjorn Helgaas Cc: Gustavo Pimentel , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , kernel-team@android.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2023 at 10:36=E2=80=AFPM Sajid Dalvi wr= ote: > > Thanks for your review Jingoo. > Sajid > > On Tue, Feb 28, 2023 at 4:04=E2=80=AFPM Han Jingoo = wrote: > > > > On Mon, Feb 27, 2023, Sajid Dalvi wrote: > > > > > > In dw_pcie_host_init() regardless of whether the link has been starte= d > > > or not, the code waits for the link to come up. Even in cases where > > > start_link() is not defined the code ends up spinning in a loop for 1 > > > second. Since in some systems dw_pcie_host_init() gets called during > > > probe, this one second loop for each pcie interface instance ends up > > > extending the boot time. > > > > > > Call trace when start_link() is not defined: > > > dw_pcie_wait_for_link << spins in a loop for 1 second > > > dw_pcie_host_init > > > > > > Signed-off-by: Sajid Dalvi > > > > (CC'ed Krzysztof Kozlowski) > > > > Acked-by: Jingoo Han > > > > It looks good to me. I also checked the previous thread. > > I agree with Krzysztof's opinion that we should include > > only hardware-related features into DT. > > Thank you. > > > > Best regards, > > Jingoo Han > > > > > --- > > > drivers/pci/controller/dwc/pcie-designware-host.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/driv= ers/pci/controller/dwc/pcie-designware-host.c > > > index 9952057c8819..9709f69f173e 100644 > > > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > > > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > > > @@ -489,10 +489,10 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) > > > ret =3D dw_pcie_start_link(pci); > > > if (ret) > > > goto err_remove_edma; > > > - } > > > > > > - /* Ignore errors, the link may come up later */ > > > - dw_pcie_wait_for_link(pci); > > > + /* Ignore errors, the link may come up later */ > > > + dw_pcie_wait_for_link(pci); > > > + } > > > > > > bridge->sysdata =3D pp; > > > > > > -- > > > 2.39.2.722.g9855ee24e9-goog > > > @bhelgaas Can this be picked up in your tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/ Thanks Sajid