Message-ID: <43c53ae9-6cc7-0fa7-584a-7720569179cf@intel.com>
Date:   Thu, 16 Mar 2023 16:57:54 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH 32/36] dmaengine: idxd: use const struct bus_type *
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     <linux-kernel@vger.kernel.org>, <rafael@kernel.org>,
        Dave Jiang <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>, <dmaengine@vger.kernel.org>
References: <20230313182918.1312597-1-gregkh@linuxfoundation.org>
 <20230313182918.1312597-32-gregkh@linuxfoundation.org>
 <76db3d98-2d09-54de-ab46-0ec9d743e05d@intel.com> <ZBLsYNXXCBkb8QlO@kroah.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <ZBLsYNXXCBkb8QlO@kroah.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qy9xRzBFbHA3OVlvaDZ3YU9mZ0xLM1VzV0R1WnpLQU90NEI3YW5td1hFcW9J?=
 =?utf-8?B?cmFOKzJaZmdPc2xHdnJ0UVcyMDhyNWFobkpodTV3cGtkREZ5VWdKMmd5YlVQ?=
 =?utf-8?B?K25OempHaHFPQ1Y2Qi8zRm9xNGZtWFNxbUJIeld2eVNLZVZlalNBOWRLVFdp?=
 =?utf-8?B?a040eWNsTktBWHBYK2IwVUpGSzBZQkdyaU1peGpHd2hvWUlHV3BSRnJaNGVw?=
 =?utf-8?B?UFg4QjBiMURibmtRSHlGNHhib29xdjdjdm53cklabjAwaUtHeVpjemJIM2hP?=
 =?utf-8?B?eUNTWk4yNVY2R0xRVS9MNzBHQmpadnF0NjY1cEttV3ZWUmlON0Mvb3FTQTlD?=
 =?utf-8?B?VEFteXp1bzdWSW9aK094TmpZcENQWmVYM2g2dlBoNEhGUnM1Yks2V2R1Vk9z?=
 =?utf-8?B?V3QwcnNxUTh6WldCNWw2SC9IVjRMM2NYWWo2VWI2UVN0Tm5Cc1ZncTRhaTkr?=
 =?utf-8?B?ZTVqRU8wOGI0SG5IUEdPREdMZnMzR2lNeXBSTTJ3dDMyeFJlTnZWamp1VzZC?=
 =?utf-8?B?R254STR3RUQxTy9HcUFwK0ZYN1dXbVlHTHA4OEx3ZEFlbGtPelBCelNiaWFK?=
 =?utf-8?B?NVF2SzNLcW5KNU83UzBXWGV1aTJvNUgwbnBLVTVmUlVIdm9BR2p1dXIvczdK?=
 =?utf-8?B?UHUzTlVNRjRtWDltRldMWXBtVTRIWmJ6b2pLUTdMZEdSYzJjaFhUeWpYQ0tn?=
 =?utf-8?B?MGt6dzNJbFM1TGtkMnduR3dLYjVudVNIVXdaVWhPWmZkbkFYajFNZk5pOVBP?=
 =?utf-8?B?YU92MVRoblNmeWg2cFNRRzdKOGVma1N2eE5ZMmk5RDNlM0FDUmFrS2dOc3V0?=
 =?utf-8?B?Y3lpNW93RzVUbmNwZ2Q5TTkvSEx1MjNiT1Bta2cxVDJjdkVXZkJBR2R2M0hM?=
 =?utf-8?B?VHlpaGlpVE4rME84cUdhS0szQnpoMWtXeWM4WFlGT3lqTHFJRUFwVEhtWnF2?=
 =?utf-8?B?V0hYdUdoNXZ2M2V1V0NVUFFYSU5NYzJyRWxkT0wvUEpxOEhvVXFhL3NWZUNk?=
 =?utf-8?B?NlViVWkxMkxwNlkzZ2k2cmh1enBDOXF6WktreVprMWY5SlZCbnN0bmZscEpG?=
 =?utf-8?B?ODhXbDJIc0hPZ2lFeHlUNGFDbmlJVXFXMEVCMDVrT1hrWDhzbmhNNXA4Si9C?=
 =?utf-8?B?VlFPNFdHR3lRYW5MOWtoanRKMWFrQ1pCVG0zLzNMY3MyUFo0MGppZlZySUo5?=
 =?utf-8?B?NzV4MUg0S1VPM0xjcHEvWThmZ2lDTzEwblEyQ05QSVJ2L2EyN0FlNXNHVnhL?=
 =?utf-8?B?dDlndkU1OEYyNUppdGd3S1RlZUZsSnZMTmw0YU00ZmJ4bml4ZDBhS091L0U2?=
 =?utf-8?B?c24xb0VJNkxaSG9oTHpUcWlQZGVxMlBuVTJBL1BmQ0hBckJuYys5VEsvSzhZ?=
 =?utf-8?B?Vk9ldEZhZjVkQU9GSU4vZHdRbmdjdFlYZ1dvVG9ONEhUUXR4VnBvUEp2WTFJ?=
 =?utf-8?B?RnJCR1ZJQ2dpSjUwc081K3g4d0xHdWtwZ1hlVzN1VXBHVGhsbTQ2NnRGWkxl?=
 =?utf-8?B?LzJZM2JTTlV0d3AyVkdtZW1yRnJ2WVJWc1hSVE8yVEhHZG1LdERudEtDa2Q2?=
 =?utf-8?B?MTRsM3BDaGcrTGNCUk9nbmFrSUd5SlR3ZVcrKzJKcm9KN1VsbHpmOXpTWlpP?=
 =?utf-8?B?TE9SZnNsaE9helVENFJ5dnN2N0ZIL2tRaUZoUlJuQmtJSlRWOWV4NFlqLzlv?=
 =?utf-8?B?ZHBQdmdwb3plM1Zla2luN1ViRFZ5dXpsZCtWcTArM1hBYlBuV0ROakNLL3FO?=
 =?utf-8?B?c2RSZUdIUjlPNEhHNWdUTjI4VU1ONHNIWVhNRGs0L2haZy9SYkc4bjl3UVdm?=
 =?utf-8?B?MUxDTllSTk14NlkyeVpDWnh3Qm9CWDBTSml1R3luWldBa1RDeGU4bEV4N1FX?=
 =?utf-8?B?TTRURDdrS3ZTK1dZNVZxbGFKYiszMjIweURMS3BoOHhGME5RSlArRkljK05q?=
 =?utf-8?B?QTJXNlVqeE84K1RNQklGelJJMkN6ajdHNUJ6NkxMbTJlNTJDTUxSQjNkKzNL?=
 =?utf-8?B?UkpldEg3YnE2TXZOaTlwSE1uVVd2UXdJV3BWMHhCajBzTXdyYldZdjFTeFd5?=
 =?utf-8?B?ZHFnZFg2eDFsZzRKT2lyNnU2VEpGaHdoSXArNlVlYTZTTmd3VFBLaHB4aVlL?=
 =?utf-8?B?YnpCdXVsUGZTRnZFa1BCN1k5L0Jyejdhdk1zbGZrcHgra0xCZDRsYmV2dC8x?=
 =?utf-8?B?UVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a3f0265a-cc5c-44af-b670-08db267a35c2
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 23:57:33.5219
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V2p4uW5WVO9QS7++J4M8RksjEpKtoILDnOlub7tG/JDUmuxOr7IZo+VK4BGo2dShG7HUx8NOGgyjWinBENlBwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8231
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Greg,

On 3/16/23 03:16, Greg Kroah-Hartman wrote:
> On Mon, Mar 13, 2023 at 12:07:27PM -0700, Fenghua Yu wrote:
>> Hi, Greg,
>>
>> On 3/13/23 11:29, Greg Kroah-Hartman wrote:
>>> In the functions unbind_store() and bind_store(), a struct bus_type *
>>> should be a const one, as the driver core bus functions used by this
>>> variable are expecting the pointer to be constant, and these functions
>>> do not modify the pointer at all.
>>>
>>> Cc: Fenghua Yu <fenghua.yu@intel.com>
>>> Cc: Dave Jiang <dave.jiang@intel.com>
>>> Cc: Vinod Koul <vkoul@kernel.org>
>>> Cc: dmaengine@vger.kernel.org
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> ---
>>> Note, this is a patch that is a prepatory cleanup as part of a larger
>>> series of patches that is working on resolving some old driver core
>>> design mistakes.  It will build and apply cleanly on top of 6.3-rc2 on
>>> its own, but I'd prefer if I could take it through my driver-core tree
>>> so that the driver core changes can be taken through there for 6.4-rc1.
>>>
>>>    drivers/dma/idxd/compat.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/dma/idxd/compat.c b/drivers/dma/idxd/compat.c
>>> index 3df21615f888..5fd38d1b9d28 100644
>>> --- a/drivers/dma/idxd/compat.c
>>> +++ b/drivers/dma/idxd/compat.c
>>> @@ -16,7 +16,7 @@ extern void device_driver_detach(struct device *dev);
>>>    static ssize_t unbind_store(struct device_driver *drv, const char *buf, size_t count)
>>>    {
>>> -	struct bus_type *bus = drv->bus;
>>> +	const struct bus_type *bus = drv->bus;
>>>    	struct device *dev;
>>>    	int rc = -ENODEV;
>>> @@ -32,7 +32,7 @@ static DRIVER_ATTR_IGNORE_LOCKDEP(unbind, 0200, NULL, unbind_store);
>>>    static ssize_t bind_store(struct device_driver *drv, const char *buf, size_t count)
>>>    {
>>> -	struct bus_type *bus = drv->bus;
>>> +	const struct bus_type *bus = drv->bus;
>>>    	struct device *dev;
>>>    	struct device_driver *alt_drv = NULL;
>>>    	int rc = -ENODEV;
>>
>> After applying this patch, warning is reported:
>>
>> drivers/dma/idxd/compat.c: In function ‘bind_store’:
>> drivers/dma/idxd/compat.c:47:47: warning: passing argument 2 of
>> ‘driver_find’ discards ‘const’ qualifier from pointer target type
>> [-Wdiscarded-qualifiers]
>>     47 |                 alt_drv = driver_find("idxd", bus);
>>        |                                               ^~~
>> In file included from ./include/linux/device.h:32,
>>                   from drivers/dma/idxd/compat.c:6:
>> ./include/linux/device/driver.h:129:59: note: expected ‘struct bus_type *’
>> but argument is of type ‘const struct bus_type *’
>>    129 |                                          struct bus_type *bus);
>>        |                                          ~~~~~~~~~~~~~~~~~^~~
>>
>> Should the "bus" parameter in driver_find() definition be changed to const
>> as well to avoid the warning?
> 
> Oops, yes, it needs an earlier patch in this series, sorry, I didn't
> call that out properly in the notes section of the patch.
> 
> So I can just take this through my tree if that's ok.

Sure.

Acked-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua