Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60AF6C6FD1F for ; Fri, 17 Mar 2023 00:01:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230004AbjCQABd (ORCPT ); Thu, 16 Mar 2023 20:01:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjCQABa (ORCPT ); Thu, 16 Mar 2023 20:01:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA6B9DDF3E; Thu, 16 Mar 2023 17:01:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 801016215E; Fri, 17 Mar 2023 00:01:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D02DC433EF; Fri, 17 Mar 2023 00:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679011288; bh=hTYgEnMkyE64wnXsk3avUA5GCBJ8kbqVBwnmO0El23w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mypInJB7USBxQTN7HvThfy/CAw1zfzkM+ju9mTokOdz/uj0tuVPYUCuC+Y5HM3AWi Ar+wZyMFzHVje5vIzYY79u0DpGUqhKOkETv6ZGZb80uT+dGLD3wZcvf9B/rOMjIUrG HbAwQWFw2Yh4V3bu/vDt7XAgb3kJZzUtpNGrheUjeCco69BP9N/QRSFXeDSV6P0Xmd EHlmapHbhpWZbGBo7HJdrRbP3HIIGeJBJUI8HFU61wrTzwQsERKXGSs1XMXza4ULqH lzv8gDeATgqg9E0sHBOOOZ3fQtNSdnpY7ZRUrxWjzFb2hKmMEdwQDBAXJJ3iRCCIdZ SJY7Sq6DgwSWQ== Date: Thu, 16 Mar 2023 17:01:27 -0700 From: Jakub Kicinski To: Michael Sit Wei Hong , Ong Boon Leong Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Looi Hong Aun , Voon Weifeng , Lai Peter Jun Ann Subject: Re: [PATCH net v2 2/2] net: stmmac: move fixed-link support fixup code Message-ID: <20230316170127.5bbd559d@kernel.org> In-Reply-To: <20230314070208.3703963-3-michael.wei.hong.sit@intel.com> References: <20230314070208.3703963-1-michael.wei.hong.sit@intel.com> <20230314070208.3703963-3-michael.wei.hong.sit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Mar 2023 15:02:08 +0800 Michael Sit Wei Hong wrote: > xpcs_an_inband value is updated in the speed_mode_2500 function > which turns on the xpcs_an_inband mode. > > Moving the fixed-link fixup code to right before phylink setup to > ensure no more fixup will affect the fixed-link mode configurations. > > Fixes: 72edaf39fc65 ("stmmac: intel: add phy-mode and fixed-link ACPI _DSD setting support") > Signed-off-by: Michael Sit Wei Hong Ong Boon, since you added the code which gets moved - could we get an ack/review tag from you? Helps increase the confidence in the change.