Message-ID: <4a9b2ed78ed80c15bb8089e2fccaf1b3.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230316154850.wxwiztump5de3xt4@pengutronix.de>
References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-16-u.kleine-koenig@pengutronix.de> <20230316150144.2aap5otmgblj24ty@bogus> <20230316154850.wxwiztump5de3xt4@pengutronix.de>
Subject: Re: [PATCH 15/30] clk: scpi: Convert to platform remove callback returning void
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Cristian Marussi <cristian.marussi@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
To:     Michael Turquette <mturquette@baylibre.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Uwe =?utf-8?q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>
Date:   Thu, 16 Mar 2023 17:31:14 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Uwe Kleine-K=C3=B6nig (2023-03-16 08:48:50)
> Hello,
>=20
> [put the clk maintainers in To:]
>=20
> On Thu, Mar 16, 2023 at 03:01:44PM +0000, Sudeep Holla wrote:
> > On Sun, Mar 12, 2023 at 05:14:57PM +0100, Uwe Kleine-K=EF=BF=BDnig wrot=
e:
> > > The .remove() callback for a platform driver returns an int which mak=
es
> > > many driver authors wrongly assume it's possible to do error handling=
 by
> > > returning an error code. However the value returned is (mostly) ignor=
ed
> > > and this typically results in resource leaks. To improve here there i=
s a
> > > quest to make the remove callback return void. In the first step of t=
his
> > > quest all drivers are converted to .remove_new() which already returns
> > > void.
> > >=20
> > > Trivially convert this driver from always returning zero in the remove
> > > callback to the void returning variant.
> > >
> >=20
> > Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> >=20
> > Let me know if you want me to pick up instead.
>=20
> Honestly I don't know. I expected that the series is applied completely
> via the clk maintainers, but the samsung patch was already taken
> individually.
>=20
> Michael and Stephen: It would probably be helpful if you shared your
> thoughs about this. For me both options are fine.
>=20

I will pick up whatever isn't picked by SoC maintainers.