Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A3DC74A5B for ; Fri, 17 Mar 2023 01:12:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbjCQBMw (ORCPT ); Thu, 16 Mar 2023 21:12:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbjCQBMu (ORCPT ); Thu, 16 Mar 2023 21:12:50 -0400 Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C71676049; Thu, 16 Mar 2023 18:12:47 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=17;SR=0;TI=SMTPD_---0Ve0pgfd_1679015562; Received: from 30.240.112.205(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0Ve0pgfd_1679015562) by smtp.aliyun-inc.com; Fri, 17 Mar 2023 09:12:43 +0800 Message-ID: Date: Fri, 17 Mar 2023 09:12:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 1/2] ACPI: APEI: set memory failure flags as MF_ACTION_REQUIRED on synchronous events Content-Language: en-US To: "Luck, Tony" , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= Cc: "rafael@kernel.org" , "lenb@kernel.org" , "james.morse@arm.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "jarkko@kernel.org" , "linmiaohe@huawei.com" , "akpm@linux-foundation.org" , "xiexiuqi@huawei.com" , "lvying6@huawei.com" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "cuibixuan@linux.alibaba.com" , "baolin.wang@linux.alibaba.com" , "zhuo.song@linux.alibaba.com" References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20230227050315.5670-2-xueshuai@linux.alibaba.com> <20230316072031.GA354196@hori.linux.bs1.fc.nec.co.jp> From: Shuai Xue In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/3/17 AM12:45, Luck, Tony wrote: >> On x86 platform with MCA, patrol scrub errors are asynchronous error, which are >> by default signaled with MCE. It is possible to downgrade the patrol scrub SRAO >> to UCNA or other correctable error in the logging/signaling behavior and signal >> CMCI only. >> >> As far as I know, on X86 platform, MCE is handled in do_machche_check() and only >> asynchronous error is notified through HEST. Can we safely drop ACPI_HEST_NOTIFY_MCE >> and only consider ACPI_HEST_NOTIFY_SEA as synchronous notification? >> >> Tony, do you have any comments on this? Please point out if I am wrong. Thank you. > > You are correct. On x86 the HEST notifications are always asynchronous. The only > synchronous events are machine check with IA32_MCi_STATUS.AR == 1 (patrol > scrub and cache eviction machine checks are async and do not set this bit). > > -Tony Thank you for confirmation. I will drop ACPI_HEST_NOTIFY_MCE in is_hest_sync_notify(). Best Regards. Shuai