To:     Ziqi Chen <quic_ziqichen@quicinc.com>
Cc:     quic_asutoshd@quicinc.com, quic_cang@quicinc.com,
        quic_nguyenb@quicinc.com, bvanassche@acm.org, mani@kernel.org,
        stanley.chu@mediatek.com, adrian.hunter@intel.com,
        beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH v3] scsi: ufs: core: print trs for pending requests in
 MCQ mode
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1sfe4xe2b.fsf@ca-mkp.ca.oracle.com>
References: <1678865517-43139-1-git-send-email-quic_ziqichen@quicinc.com>
Date:   Thu, 16 Mar 2023 23:16:39 -0400
In-Reply-To: <1678865517-43139-1-git-send-email-quic_ziqichen@quicinc.com>
        (Ziqi Chen's message of "Wed, 15 Mar 2023 15:31:52 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?79jdAdfaaflpG/tpHajqKCGeoacYu4EfG+8u4BqRpgVor76CNEjLdlhMpcEr?=
 =?us-ascii?Q?1SkLupeVnd/WG2ALzv+xvy0MB2mBPh/2asti60lfykAX36XG02vydy2oXzs6?=
 =?us-ascii?Q?2MvRka6d2HxkdHAun2ApHAVH/WNO2dbVhESnTvE4UyhF2NdKY7TwA97t2o2a?=
 =?us-ascii?Q?u3dN4OnjWSI+M6ZDaw9MB547hPoVqUYczssCdaOwH6/C12ORE4AhYnn89pir?=
 =?us-ascii?Q?AGFPQbP5pJuq4Y+iO+Liz79kReCmjb8229jCIQSrNL3mjKewNEssJpkKbF2W?=
 =?us-ascii?Q?y4A6MMVBO84DGzHQtV/9i1lusYBjGi0wCXtg/ps23+BpqKTQ4FbZEAoHnELe?=
 =?us-ascii?Q?iAf6QiqP3DyM8a4hCiaHtT7D0uY3GKUS8WplQ15s70viua8KwweY6Gg85bQq?=
 =?us-ascii?Q?PKAwP++7KCk2ig25vnUuGtQ+OQTfC77WC7RLrxjeBARaR/asq8bJXyGzCPgx?=
 =?us-ascii?Q?DLn99Hmsj6LPeAe8Uaa4WeHxlM+goQ+t2MHT5kiVPq53K5tiY9+vbItoclgF?=
 =?us-ascii?Q?UZoVT0TlDBFlBkd7VTzRLCMORsyNYvOWg0TaWbYoi/jNesahCtxC+VDiuR3v?=
 =?us-ascii?Q?ls+YC/Pb7p5J+R7y9OKpk1qbm+cQ8V8rZCg4n8OdINPPZeQUzUsTRhYPI2XT?=
 =?us-ascii?Q?PMjUKgbL3Ey7maU0IiLZk9Ztm3Axysb4dZUUL8s+yT/c/rXUEMostHfgQdap?=
 =?us-ascii?Q?JYZTBjipqdsOUNVvCRFu0RfxZ51ZPB/jUlEgLnhpGO1LOyLOaLgbLqQoTUSH?=
 =?us-ascii?Q?vRTb+A0A3kH1fT9SJPK0hmELGK+lM8n5IVRerPTrbuDXYpQ//FU+NoJPbTEg?=
 =?us-ascii?Q?OsaM9vUwYT2BRU3bm0X1sgg0u+QjZrCCOuow9ktwtsPRPGPmG5MvEudIgiue?=
 =?us-ascii?Q?nOtwPptaR80f2Wf+B60GYqhylEF13sxJWhqPoyj6zQJbl7RcIFlmOgC8jjKv?=
 =?us-ascii?Q?kbLMhlJ9HfpM2+e0uWsZjy7+ijRdJqj9bAlKuhaTlU6uFIcZWsymkf8e+mDd?=
 =?us-ascii?Q?ip0IUXoPMyFdTdUKO+5h1dMSOlf5cdHhcO4WNaIYgZt8d0LHQEjb2gAPiZ/S?=
 =?us-ascii?Q?ZHpkNd5vTnDjc9hvos/xo7D+1VEY3c/ADKjnjiudlp6RnLMESnS3OIOkIBkG?=
 =?us-ascii?Q?jH9nvSzD2OBVF/Xuli9RPcYKNVsicnku2l2le8JeJdGXq7ZbicIHQnBLlgsv?=
 =?us-ascii?Q?oPGgqWz+MThTg5pLEkhxL3u75Btcrz3qJ235nsqaXAZtJzgwo3KJTzWInWA7?=
 =?us-ascii?Q?hM3TnpX53morzmDe/FWvyESd9R3UO6ENafEL46txr2tlse6zvFmAwUyi+udE?=
 =?us-ascii?Q?VnX8qcerIVxjIXEDJmTgvg8kmQT8BmlqgRhl898YWDKlhsGgsq97OOuYXVxA?=
 =?us-ascii?Q?tF+DvdyMd0BMe7Rdpeg8oSAb0UM3z6F+5Bhu8vACCHWxlJK6ZDJyJtiCvzmC?=
 =?us-ascii?Q?pXiGdnChZt+pzqqOveE6eAbPkujzg+zKWss0OxqDMfkWWvrxYqHOFOchB1y1?=
 =?us-ascii?Q?2duhtMG1TDCQpFQW9Wly1d62EjMKwGsrrkWgiY0p//fBPtbR654IjtlASYQw?=
 =?us-ascii?Q?iBaph6KhRrMdFT4emv95KVFmUXKnuextHLy++nEwJczsO+0ikB3xQcD/S8FW?=
 =?us-ascii?Q?wA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?B2o6tpzlZEvMgHy3aWH7ujcFE7XIBTdp4dQXeAYUhYRpVEt6ji3YUT0eNSFv?=
 =?us-ascii?Q?cQH3lGPqZVTpzscGnuYS+izcIPTNwRgTzmhy5G3sn1DTX4dseDN+CvHolsKs?=
 =?us-ascii?Q?VAuY7acStOyziCN5iTn7mHMEG+RzkpNVO81ym+QxCrz5H7q81bj2ORsCBlXM?=
 =?us-ascii?Q?YY0+VOKUU2sDE1f2QXr0Tjs6LcRPSrBBki31xZL/44/JaIIsV9r7LI4rxGaB?=
 =?us-ascii?Q?qFydyXub3nNyQ2K9NItRk7/Qs8PyAYIPs9LSSVF//dH6EdUuKKQt/096vIac?=
 =?us-ascii?Q?7SdhoHOLFGL+XcBl86rJiQ7qjrCN03btp/MGIn9wHuxJ3fOMZAvOY5ekrW9f?=
 =?us-ascii?Q?3OBwMTt6J1yuor9ICvim6s4Y+qnX27rr95eRM3htmeDb6Qs30mA/D7FN80px?=
 =?us-ascii?Q?LJBX2WxxbLeliHKMnrd6coMnLUg7Rf0KMGbgblH0RWHLr3XRjf0/OyT842AM?=
 =?us-ascii?Q?uaj9gnaYdv6ZunT/B3/6PqS4IeyRk9QLNA6/qTO14p0KXauGwPBuP3sY3+gf?=
 =?us-ascii?Q?2XDauNjCHbjTd1lSOsM2LF21l8nbsXe6eVOQcMd1sqZQZ5K3ealeFk7xBqm8?=
 =?us-ascii?Q?BUyCPqg8c+VotxxSoIJHplE4gyys5IzuvNJQOLBSs3pQfFJoZO/UioypWk+J?=
 =?us-ascii?Q?/YT2r8cPOZ2BSD/NU0LsHqsKI5wJ74N3uE2ib0VNMvapmm6zOVGAc7Gn351M?=
 =?us-ascii?Q?ZupkuFVWy7y03OIxJLdI9tnf05751VIQReuhmC+UIZB4CiMl1sAkwnGZb79f?=
 =?us-ascii?Q?TN50OZ2uVWamWYC25oDFDUumR++VJf4+Ehc82SxAC94UUw59udamW3wUUdwI?=
 =?us-ascii?Q?Cm0AIPr3HE3NnIO18N20NqswVH9eXS4yb3NHDHmwHGzgtcunFBK3zUqfx07P?=
 =?us-ascii?Q?iNwnav9xd7BXSsKMXwrI9E+L5mHOp6dWDa5Q8cgs5gDPlmInAZa/y1uqnrHh?=
 =?us-ascii?Q?HC2qNAau2+5jK+zQRRKe0I96WbaOfQ42OEsJt2RWvrDljKSNSxweTEHXgOfo?=
 =?us-ascii?Q?BzbUUN7H4pbYirjVf/Qz3hzaPQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ffbdab76-199f-47b4-4a54-08db269609a7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 03:16:45.3852
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uq5U+sqH38wRxOJIMPi5ePQX5CKGii5Me0JpOwZol+MkDZBFQvXJEWNkCDWLW/ivgPFAUJwNOsXxcj7WGOnbht3Bml7ljw6X86NGZoc5W9Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6555
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-16_16,2023-03-16_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0
 bulkscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002
 definitions=main-2303170018
X-Proofpoint-GUID: wFoomDikUjiy6e0cnyyhOe_Cr4FO3N04
X-Proofpoint-ORIG-GUID: wFoomDikUjiy6e0cnyyhOe_Cr4FO3N04
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Ziqi,

> We don't have outstanding_reqs bitmap in MCQ mode. And in
> consideration of the queue depth may increase beyond 64 in the future,
> we reworked ufshcd_print_trs() to get rid of usage of bitmap so that
> we can print trs for pending requests in both SDB and MCQ mode.

Applied to 6.4/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering