Date:   Fri, 17 Mar 2023 11:45:21 +0800
From:   Chester Lin <clin@suse.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        NXP S32 Linux Team <s32@nxp.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Ghennadi Procopciuc <Ghennadi.Procopciuc@oss.nxp.com>,
        Andrei Stefanescu <andrei.stefanescu@nxp.com>,
        Radu Pirea <radu-nicolae.pirea@nxp.com>,
        Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>,
        Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH 0/3] pinctrl: s32: driver improvements and generic struct
 use
Message-ID: <ZBPiUTFRFry/BAqR@linux-8mug>
References: <20230314134642.21535-1-clin@suse.com>
 <CAHp75Ve=U_rkgL6ohpy1r4RejXK-PqgrqfkPmCrhzK9O3necnw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHp75Ve=U_rkgL6ohpy1r4RejXK-PqgrqfkPmCrhzK9O3necnw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zk90NzEvRkZnZjhUOERuZzlFS1dMaXo3Wjd3ajVqb2dKR0pKaEFiNUFJaVhZ?=
 =?utf-8?B?RzlVWU1BVHVSVjRiUGxRY0Mxcll2SitwTVdxWU83d1NmQnE3VmhNMjVNYUdp?=
 =?utf-8?B?TUxneDlCeWxXc3N6WWIzcC84cjExWkFsV1RLb0g2QzdiODBKZlJWN3BUY1lk?=
 =?utf-8?B?dEpKbElzQnVPZEttSmVjQS83V0FHZmNPcGlEVlVyZ1hYRzliMUxzOVhKQVJD?=
 =?utf-8?B?RXQrQ2NuVlVRZzV0RmNZWnJlVHA1NjNoV01HcE9nb1RxSUtTQVBVUEJqWTZ5?=
 =?utf-8?B?allKeEg4bVRMYnkveGVXc3NvTGk5UTNGREVhemlHMU5SRDd3TzdZbE1RbFV5?=
 =?utf-8?B?bTdlUnd1dWRxV1NGWVE2VHp6N1lZaXZLM0hydmxJa2VTL1JabE1GZ29LQXBW?=
 =?utf-8?B?djhzZ2lHN0tVNWRlUTdla2toeEd6eFhBTWxOQndrN2U2blRmSmtqYlBMVHhi?=
 =?utf-8?B?bEZBRTRZYUpManBPcGRLaUZvYmV1bmtMbXpjSm8yZFM2VG9FRXJURTFITndD?=
 =?utf-8?B?TkdSb2hrYVlHb2ZrQzZQTnBqNWd0dUE5ZmZXbm1oeUlzY3FFRnQ5RHhLMkdD?=
 =?utf-8?B?Zk8xQk1VeG42dVVRYldYNWhVODRPRnYwWmljbC8zeHMra1FycjIySXVrUUlY?=
 =?utf-8?B?VVlsRTNFVUdvb0hKQ28wY2g2blI0VVZKclMwTzlLMlRuOVlINmtsRnlqbzBk?=
 =?utf-8?B?d01QcXdiNmtVeS9lRUYxRFZ3R0paK0J1T3ZvRzFFOUZtbkQ3TTMrK0s1UzAz?=
 =?utf-8?B?Tjc5RFVYY3VYZkJ3dFdaMDZoYlBXcWRiSE02MFl1d1BMZkEwakxUVEtsMEdT?=
 =?utf-8?B?Yk1NMEM3dXRvdFYvd25BWkMxRWo4ZFVMVmQyZ2h6V2hlbUZOd3IyVkxUdmVt?=
 =?utf-8?B?Tkd6V3ZUVnFtSE1UTWdFTy9HLzM1T2F4d25yWmo3NysyQlRUbTBiWGR3a2xw?=
 =?utf-8?B?ZnN5eTBFR0kzZkJoSFJCckJVL1JvMEE0TU1TSUg5cU44RG1ORkI2SFpSYU1h?=
 =?utf-8?B?TXZUaVpMVjFwRzN1dUVmbE9xeGpJYWRVSjdrQnpnM0FJckh2MkgzMVR4MGhv?=
 =?utf-8?B?RGpSUDIyaW9BTkFBaVUzdFVNYSt0ZzAwcGVueEV1bHFJVEpiYXdKbHVxekxT?=
 =?utf-8?B?RkNERE9WMlh4azNDdHEwV1FXYjhieEkzYTBhbjVjVEpTOXhUVW56ODR5WVFP?=
 =?utf-8?B?anhkQnJFUzl1ckJrREZTUXRyOVNIWnRiVWQwUEJyalJjcDlEcmoxd0lqdW1w?=
 =?utf-8?B?ejBWQmFLNlkvdUFvN283VlFnWG4ybVA3QWpKNExDR0N3OGpoWUtKMXArVlRw?=
 =?utf-8?B?L1ZLR3ZKL3pVZVFnd2FoODZMQjFqWEZIcVY4UVJqdUxFY3FUcW1leW5QdlEz?=
 =?utf-8?B?bU9wSzJiVWR2eWpmWGFLMWpPbjZFYzBBaVRhUDNuZmlaT1ZVRjQray9IaGVJ?=
 =?utf-8?B?UVhLSnc5WUhvaFdjeHJ5NnB2WW9PT2VaemFPR3pNNFRMOVQ1NmV0OW9mR1Uy?=
 =?utf-8?B?MlhZNm1ucElyem0rbUkxd2NjUUI3eFZSdDA4TlYybUFUVmVwN041YldncTN2?=
 =?utf-8?B?eUxmR2pPcXBsSEZoOGNvNkJFVEdRdFBUbUNiTnJXMklGZVpUeWVaMTZKd296?=
 =?utf-8?B?Ump2akF6dG0rQ2N3UUFlUXdnQndkU0pvR1FJL1ZZRDd1Y1IwcnVucy9lZjN4?=
 =?utf-8?B?azBFWXdFUGUxcWFSRHZnczNnTGxQMTZNVUJxbTZkZkNvUlNBMktRNXhIVGhR?=
 =?utf-8?B?eHhveGJpUVlPaDBJYlRMakN1Z3prTnd6WDZ3UXFCUGdPV2lrKzNjTVMzNFdi?=
 =?utf-8?B?SVFhMituVXM1dWF3aEEwaTBMamRWWHN5ZjlSUDJrRVpOMVJWR1doOHZsVTdG?=
 =?utf-8?B?MlZ1c1kzZm1rYUZHalppWng5N0hKU2Q5UENrWW5VUUQzaHFHNzZzcG54WHFJ?=
 =?utf-8?B?c09zNG1VbzhhT05IWlJ5aWNyancraVQ1QXV2Wm5WQzc5TzBUcTluR09iS3F5?=
 =?utf-8?B?TlprWUU4YmhGenlPUE9Ea1BwNENXOVVLbEdxVGlPV3pxVUsvajZqMkkxaHZq?=
 =?utf-8?B?UjhOVXEyOVM0V1hxb2gveGhVa2o5L0JCVXE4N3NFTmFSdkhzWE9Uamx5eGVB?=
 =?utf-8?Q?Czi+RSNR+vbhlbB3aFh2+/enx?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 735aff65-9004-452d-53ad-08db269a1056
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3439.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 03:45:34.6156
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cXTZeTxNRT4AT48/ndLjF90epgVAIECfdqw5OwWZ/ttE4Ny1wKcbEP0zXuHD/MRR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8098
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy,

On Tue, Mar 14, 2023 at 07:21:55PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 14, 2023 at 3:46 PM Chester Lin <clin@suse.com> wrote:
> >
> > Hello,
> >
> > This patch series contains some improvements for s32 pinctrl drivers suggested
> > by upstream[1], such as
> >
> >   - Fix error shadowings and improve return value handlings.
> >   - Fix print format.
> >   - Remove unnecessary blanks.
> >   - Use proper macros and helpers to simplify codes.
> >   - Refactor config param parsing and remove config arguments that are never used.
> >   - Use generic struct pingroup and struct pinfunction to describe pin data.
> 
> Overall it looks not bad, thank you for doing this.
> Individual patches have been reviewed and commented accordingly.

Thank you for reviewing this patch. I will fix the rest in v2 soon.

Regards,
Chester

> 
> -- 
> With Best Regards,
> Andy Shevchenko