Message-ID: <1c807f47-70d4-14b3-7a20-8f595edbd99e@oracle.com>
Date:   Fri, 17 Mar 2023 12:14:20 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:95.0)
 Gecko/20100101 Thunderbird/95.0
Subject: Re: [linus:master] [btrfs] 5f58d783fd: xfstests.btrfs.172.fail
To:     kernel test rboot <oliver.sang@intel.com>
Cc:     oe-lkp@lists.linux.dev, lkp@intel.com,
        linux-kernel@vger.kernel.org, David Sterba <dsterba@suse.com>,
        Daan De Meyer <daandemeyer@fb.com>,
        Josef Bacik <josef@toxicpanda.com>, linux-btrfs@vger.kernel.org
References: <202303170839.fdf23068-oliver.sang@intel.com>
From:   Anand Jain <anand.jain@oracle.com>
In-Reply-To: <202303170839.fdf23068-oliver.sang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFpsSTlNSTdGdzRQVlNrakcxcVE2OFVnR2Z6YjFUVFlkZTBUNjI2SGlCbkZj?=
 =?utf-8?B?WjBtYVl6MFM1WjgydUVKK1pjYnJkZzZOYUhHSC9uWXFHVWtHSDVWWGVuRDEx?=
 =?utf-8?B?NVRmbnhwTXJDR1RQZXcwUHM1TnlBU0l3NWhHdzdVYkNoTWxCYXZRMFBJUGlV?=
 =?utf-8?B?WDFTTE9qY3pPZmdPSHRid3VYSURMb3F2K0NtdWp2aStDTXRsS0dMM3VDWjFs?=
 =?utf-8?B?YzUwKzlmcHU0QkVwSE1WbTN5Z1FCN2w2Tk1NS0ZRTnczVVJvWkFnTElCcitv?=
 =?utf-8?B?Q0JSOUxRSGV0UmsvZ1h5d1l6K0lGSHZjamRRNzZmM2NrMUlYYkJwVFFuSzBi?=
 =?utf-8?B?UGhWM1kxVk5uWUJMZ2RDVnJwMm1GZmhJay90dFpXNllIdlkwNDl4eXVhSGha?=
 =?utf-8?B?V0tTT2wyVHQ3SXVZNWJmOUVGRWg1emJ3WjdwbHlLT0R1R0ViVTY2ZER2cEN6?=
 =?utf-8?B?N2FNV0hCRlIrOUxlVzBoZGRqNkhFQWgxNDJDbGROTm5ZN0p4NjZVTlZmaDUx?=
 =?utf-8?B?dHFyWU4wWm5DZTFMVzI1MjIzZGJ4MWQrazk0NzNNZFlHREovaW9OL1ArK0w0?=
 =?utf-8?B?aFVXWWZUY0RaSURuckV2UDF0TkpocXJKK1ZFU0wrTTVpZE4yTTRRSFNXWkcy?=
 =?utf-8?B?RXkvdXdGVDhLZTVKc3hDYmRMYzQraG8yM2g3WUc1MlREYmc4VGhhdFY0TzhY?=
 =?utf-8?B?RjRKYW91elpVQVJXb2ZNZE9STXpuK0pSckhsSVFDdUw3K2dGRlluMXFlYkRj?=
 =?utf-8?B?dXhXT20vaEU2eW9YVWFVb0lhVnJIakcwaVpjM0FOQ1ZsUTVTOGRUUzNnNWo3?=
 =?utf-8?B?VFdIUE9RK0wwRFljSU9MNFhQejE1NkRtbkhxVjMveHhKK2tQd3M3am96byt3?=
 =?utf-8?B?aW5xKzFYa0U0RzM4a2lqWkkvYlRsMmpacXJibFI4c0FnQmU3MXA5S2FEa1Av?=
 =?utf-8?B?RzhteVAxbXA0Q3QwUUZPeFNMTC9Xc1VlNmhYTVpkWGxmQk1ka2NiaUFuNEhG?=
 =?utf-8?B?RkdTM21BNHExa2JVRzFISmMxZ2JPdXZPNDdacGpKOFQ3dUk2b0xnL25RK0NR?=
 =?utf-8?B?d3UwcUQxSExjRGwyLzR2eUx6SmxLQUJienBtUlFoMGt6QVlWMnNpcXZvdG5I?=
 =?utf-8?B?dGpPVW5keGdtMEVSaVB6SU0zWjNjWEsvMnRrdUhFTTFxN2NkV0ZzSlAvYXVP?=
 =?utf-8?B?Uml1cEMyb0FmbTVZNEQzTXRrSlF6eDdWUmNJckdrWnVMVFBxOUV0T3d1UFky?=
 =?utf-8?B?cGhoSDg5V2lhcitianJ5dUVaT3lqcVIwVFVzcVM1NG4rc2dxSk1ySEdTOXpK?=
 =?utf-8?B?OHJkSTRVd3F2ZFZEQXhyNGI0Nkd3Qk9DeW9OUFZXWEJmcWQ0Ni80SGtjY1Zl?=
 =?utf-8?B?YmhTOWVXNk5lY1VXVjhOdWpZdUw2UExvUzZBTUxXd01aak13RHFGTElZRlRG?=
 =?utf-8?B?KzNhaGova3ltOW0vN1ZiTUdmSzIzazdnNzJ5YUUrbGR4WW5GYlBYT0duK2l5?=
 =?utf-8?B?YzNBNGo5aVpaNXJhMDNEeTRhQ29MRXF3Mk9lZ0pJTWVFU2JjNjFEQStsQkNt?=
 =?utf-8?B?TngvK0lTSzdOZXhCZ2l5ZXhjQ1VEOEhacDJQakdBdjE0b0N0bERjNUVRcDFp?=
 =?utf-8?B?bEJ0MVFIMG5kTzVlckxwak1wZHF3cmVWMTdvU1ZXcDhScFQ5R01ySnUxaFF4?=
 =?utf-8?B?UWt4b1hlZjhObTZBaVZLbVlDRTFiK2tEbkNWL3FBd0FSSmFHdmhoUXhCYXFx?=
 =?utf-8?B?allHS3JaQWZ6NFdRNXhoa1FKZERQUXBPTVpDRHNWTG9sNWRlcHZ4S3dLOFZp?=
 =?utf-8?B?clF2Y0xZbEsrZllSR2FqdVJxV2pwdTVtK3FtWThnRFRBRXBVd3RnNDFDQTQw?=
 =?utf-8?B?WStrejMzL0IwUWd6WmFzWkdqUTRhcmtad2NXRVQyVWVzSFE2UXJtUmNRRXZ0?=
 =?utf-8?B?Q1hNOXJhNGR1UjY4em5QSEw0YTUxOGlPOVhVemh0WlNiMzVyTGpLUmJQN3ls?=
 =?utf-8?B?V0R2UjZoN1R5VXRacXcwOWtqOTNJVEhvRWl6M050TkxOVm1kQTJqS2lZZGpK?=
 =?utf-8?B?NEdycG81NFBKcHJvTktsYVNTZE5zcVd5NjZsMHkyNW0rbE4vMGRFUDdDakF2?=
 =?utf-8?Q?a1a0n4rVXHLGfpRQtMio2Zpex?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: NQC4NMttRVCRpNFKF7z/p4aRsovxVdg7iNpiKB0T2W8dOt6t3r1gucEW5szjNL4WnP0t/0DbTL0nlG4DSdYbr0lBTIAGzJgy30eNVAVBnI7qjVJWS/mLoFqiG5HjdqYcNQU0IL9lFHKBk4Hizsr1Be2nkINJXJsLl9UalEA4pFME6w0cqYTOwJ3bDtskni2wEvbfd3Xh13GaSEhAQU7HHZsgnxnd/bq1P5cgkPu55NMzSwhFouWAxXY6LK6uRz2H8H3DuR/zt4xBpWX3Kt70dw1BWqvQINiSk8JVgih4FodUF1/z8uQaM60rP0ABWk1od8mKSmLuH0oy018DpolAHbIZyD0WkgprriPyxydGgxrxWxjr2j+HSqZixudRyWiCkaBRbeq4e2j35tynTsynCbbdA46RsZCD+zI6fhhZbJWwaLbTxxI+7Awqap0uNy+lwkoyBOKpTOIrwj7T8JjWuKnI9d/dYdWVtR6aA51UmZNVelEV0hZxMlh7M+F3fksk9m0drBrJbp+vX7Z0KQM6KZzB1ZW7VTaSJCholUKXbvs+SvLUUnSwLskJbWZpG50/XsvBAytqhpGN1d3TnFQwHEUSMY/PKZFs9uPdCFHnMkxi0m1HbTMBk8J0OyFpsKwI2wK+efq9QNQzNLHgRzZw3SfV198rxnjUpFA7+TkAvhkGXkWcSANmDKM2TGvMG4kVtJx6h+AMAhLl30k+jmoJcUm2symjm95iSHQsmjPXlZF9Vkyoj5TojRJNH3ndWpDu19xd4WNa6Jk4q5DMUQ97sgTyqPVgpCH07lS1bJuS3/O5yVfMHBTlsC+soh+2Ig5GLDces0fWOzvY+en4o73zzZuczXwzkcXALpBt/dkv4z8iqoph8/2OhCftImv0rICabtpThw14Tj9wZGKTiqXQIsD5KLomTbh8tF6jgO2cTKE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d418646c-ff31-464e-fd36-08db269e1a70
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5706.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 04:14:29.7901
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JTszzKnhmZcuHWzKaBqXfgd8qKH5i3JloOkMpw+SvNgrUCcUtRlcdmfKsOqo/Ml358Qpi+7UlOvAfllbs7tFOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB5995
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-17_01,2023-03-16_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 bulkscore=0
 adultscore=0 phishscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002
 definitions=main-2303170025
X-Proofpoint-ORIG-GUID: 572MLLtFbcLEGNV9-uMeLxerKlN_HdAi
X-Proofpoint-GUID: 572MLLtFbcLEGNV9-uMeLxerKlN_HdAi
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/17/23 09:17, kernel test rboot wrote:
> 
> Greeting,
> 
> FYI, we noticed xfstests.btrfs.172.fail due to commit (built with gcc-11):
> 
> commit: 5f58d783fd7823b2c2d5954d1126e702f94bfc4c ("btrfs: free device in btrfs_close_devices for a single device filesystem")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> 
> in testcase: xfstests
> version: xfstests-i386-5a5e419-1_20220926
> with following parameters:
> 
> 	disk: 6HDD
> 	fs: btrfs
> 	test: btrfs-logwrites
> 
> test-description: xfstests is a regression test suite for xfs and other files ystems.
> test-url: git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git
> 
> 
> on test machine: 8 threads 1 sockets Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz (Haswell) with 8G memory
> 
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
> 
> 
> we did this test on i386 and we found the issue doesn't always happen,
> on both this commit and v6.3-rc2, it failed in about half of tests.
> however, always clean on parent commit 519b7e13b5ae8dd3.
> 
> 519b7e13b5ae8dd3 5f58d783fd7823b2c2d5954d112                    v6.3-rc2
> ---------------- --------------------------- ---------------------------
>         fail:runs  %reproduction    fail:runs  %reproduction    fail:runs
>             |             |             |             |             |
>             :14          23%           7:13          33%          10:19    xfstests.btrfs.172.fail
>           14:14         -27%           6:13         -17%           9:19    xfstests.btrfs.172.pass
> 
> 
> 
> If you fix the issue, kindly add following tag
> | Reported-by: kernel test robot <oliver.sang@intel.com>
> | Link: https://lore.kernel.org/oe-lkp/202303170839.fdf23068-oliver.sang@intel.com
> 
> 2023-03-08 04:47:50 export TEST_DIR=/fs/sdb1
> 2023-03-08 04:47:50 export TEST_DEV=/dev/sdb1
> 2023-03-08 04:47:50 export FSTYP=btrfs
> 2023-03-08 04:47:50 export SCRATCH_MNT=/fs/scratch
> 2023-03-08 04:47:50 mkdir /fs/scratch -p
> 2023-03-08 04:47:50 export SCRATCH_DEV_POOL="/dev/sdb2 /dev/sdb3 /dev/sdb4 /dev/sdb5 /dev/sdb6"
> 2023-03-08 04:47:50 export LOGWRITES_DEV=/dev/sdb2
> 2023-03-08 04:47:50 export SCRATCH_DEV=/dev/sdb6
> 2023-03-08 04:47:50 unset SCRATCH_DEV_POOL
> 2023-03-08 04:47:50 sed "s:^:btrfs/:" //lkp/benchmarks/xfstests/tests/btrfs-logwrites
> 2023-03-08 04:47:50 ./check btrfs/291 btrfs/206 btrfs/196 btrfs/192 btrfs/190 btrfs/172
> FSTYP         -- btrfs
> PLATFORM      -- Linux/i686 lkp-hsw-d01 6.1.0-rc8-00284-g5f58d783fd78 #1 SMP Wed Mar  8 11:05:36 CST 2023
> MKFS_OPTIONS  -- /dev/sdb6
> MOUNT_OPTIONS -- /dev/sdb6 /fs/scratch
> 
> btrfs/172       [failed, exit status 1]- output mismatch (see /lkp/benchmarks/xfstests/results//btrfs/172.out.bad)
>      --- tests/btrfs/172.out	2022-09-26 09:38:15.000000000 +0000
>      +++ /lkp/benchmarks/xfstests/results//btrfs/172.out.bad	2023-03-08 04:47:54.134026209 +0000
>      @@ -1,3 +1,5 @@
>       QA output created by 172
>       wrote 5242880/5242880 bytes at offset 0
>       XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

>      +_check_btrfs_filesystem: filesystem on /dev/sdb6 is inconsistent


Thank you for reporting it. I am currently looking into it. It appears
that the device is being freed after it's closed, which could indicate
that we overlooked something at close, just a hypothesis at this point.

-Anand


>      +(see /lkp/benchmarks/xfstests/results//btrfs/172.full for details)
>      ...
>      (Run 'diff -u /lkp/benchmarks/xfstests/tests/btrfs/172.out /lkp/benchmarks/xfstests/results//btrfs/172.out.bad'  to see the entire diff)
> btrfs/190        15s
> btrfs/192        101s
> btrfs/196        163s
> btrfs/206        4s
> btrfs/291       [not run] kernel btrfs isn't configured with verity support
> Ran: btrfs/172 btrfs/190 btrfs/192 btrfs/196 btrfs/206 btrfs/291
> Not run: btrfs/291
> Failures: btrfs/172
> Failed 1 of 6 tests
> 
> 
> 
> 
> To reproduce:
> 
>          git clone https://github.com/intel/lkp-tests.git
>          cd lkp-tests
>          sudo bin/lkp install job.yaml           # job file is attached in this email
>          bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
>          sudo bin/lkp run generated-yaml-file
> 
>          # if come across any failure that blocks the test,
>          # please remove ~/.lkp and /lkp dir to run from a clean state.
> 
> 
>